From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B2E44C51B; Mon, 14 Sep 2026 12:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789387237; cv=none; b=ioo7Xbg/c7jabz0JkbQ2eQDXUGmV/gaFwDLic6b4WZvqq9OX+n9MoUr7Cud0HxQyAeHbHjv5d33UpMBU3EWtOWdFcx7UT7BhEqzZHf0yDYqsjp1O+w2u/zkYOi7JvSzDrOgF6UHzQVEgRXsG5hMARcHrMpXpoKQf7ETEQMSGvYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789387237; c=relaxed/simple; bh=f/k3y5n3no1eg8TLEQuOIMwilRzejIEiYRnSnrzuNg8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hSkwAFLSaPLdnMtEn6P1rY7SRVPDKvUVkxQxsexPRaQHSyHY2DJ9JE8gXFFkFE+EpGak7ROwjGmip1qvJImfyK1pDn/MVR+nOZIC5RGR+ZIoS4QohO9M1dNFyk8u1TAdmEMTXRKk57yc1bceQadDqQSr9XdD5UvcTLQ6vIOg76Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org; spf=pass smtp.helo=mail.mainlining.org; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.helo=mail.mainlining.org Message-ID: <42ef03e8-112a-4689-aedd-eeb7ec9b4f58@mainlining.org> Date: Mon, 14 Sep 2026 14:58:41 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 20/20] arm64: dts: qcom: generalmobile-shamrock: new device To: Konrad Dybcio Cc: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Ulf Hansson , Konrad Dybcio , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Lee Jones , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Robert Marko , Guru Das Srinagesh , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Dmitry Torokhov , David Heidelberg , Dang Huynh , phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, iommu@lists.linux.dev, mfd@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-input@vger.kernel.org References: <20260912-msm8952-initial-support-v1-0-0e742578b524@mainlining.org> <20260912-msm8952-initial-support-v1-20-0e742578b524@mainlining.org> From: Muzaffer Kadir Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Konrad, On Mon, 14 Sep 2026 13:22:52 +0200, Konrad Dybcio wrote: > On 9/12/26 10:39 AM, Muzaffer Kadir via B4 Relay wrote: >> From: Muzaffer Kadir >> >> Add General Mobile Shamrock (GM 5 Plus). >> Shamrock is designed similar to L9300. >> Downstream reference is [1]. > > Please feel free to > wrap your messages at 72 > characters, otherwise they are > a bit hard to read! :D I am sorry to hear that. vim shows it less than 72 and I can't see which line is bigger than 72. Only one I can see is url itself. Should I move url to Link trailer? For other parts of review, I will fix them in v2. Thanks a lot for review. Best regards, Muzaffer Kadir