From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932809AbdELDnC (ORCPT ); Thu, 11 May 2017 23:43:02 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58691 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932365AbdELDm7 (ORCPT ); Thu, 11 May 2017 23:42:59 -0400 Subject: Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support To: Stewart Smith , Daniel Axtens , Anju T Sudhakar , mpe@ellerman.id.au References: <1493907596-11425-1-git-send-email-anju@linux.vnet.ibm.com> <1493907596-11425-6-git-send-email-anju@linux.vnet.ibm.com> <87shkfqvx6.fsf@possimpible.ozlabs.ibm.com> <0dfc6438-374c-3086-3847-832b5396e7f2@linux.vnet.ibm.com> <87a86iizre.fsf@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com, bsingharora@gmail.com, anton@samba.org, sukadev@linux.vnet.ibm.com, mikey@neuling.org, eranian@google.com, hemant@linux.vnet.ibm.com From: Madhavan Srinivasan Date: Fri, 12 May 2017 09:11:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87a86iizre.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17051203-0008-0000-0000-0000012BE4CD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17051203-0009-0000-0000-0000095A6DB1 Message-Id: <42effb3a-e747-97bf-2f78-255e94bbcf47@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-12_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705120070 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 12 May 2017 07:48 AM, Stewart Smith wrote: > Madhavan Srinivasan writes: >>> * in patch 9 should opal_imc_counters_init return something other >>> than OPAL_SUCCESS in the case on invalid arguments? Maybe >>> OPAL_PARAMETER? (I think you fix this in a later patch anyway?) >> So, init call will return OPAL_PARAMETER for the unsupported >> domains (core and nest are supported). And if the init operation >> fails for any reason, it would return OPAL_HARDWARE. And this is >> documented. > (I'll comment on the skiboot one too), but I think that if the class > exists but init is a no-op, then OPAL_IMC_COUNTERS_INIT should return > OPAL_SUCCESS and just do nothing. This future proofs everything, and the > API is that one *must* call _INIT before start. Hi stewart, Yes. mpe did mention this in his review. And i have made the same in the v11 of the opal patchset. Currently we return OPAL_SUCCESS from _INIT incase of type "Nest". Additionally i have also added a message to be printed but i guess we can get away with that. Maddy >