From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: festevam@gmail.com, linux-imx@nxp.com, hvilleneuve@dimonoff.com,
l.stach@pengutronix.de, abbaraju.manojsai@amarulasolutions.com,
jagan@amarulasolutions.com, matteo.lisi@engicam.com,
tharvey@gateworks.com, t.remmet@phytec.de,
u.kleine-koenig@pengutronix.de, t.remmet@phytec.deh,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 00/14] arm64: dts: imx8mp: correct pad settings
Date: Wed, 22 Jun 2022 08:31:48 +0200 [thread overview]
Message-ID: <42f2ba58-acd9-a214-83f2-037f669d8d59@prevas.dk> (raw)
In-Reply-To: <20220622061410.853301-1-peng.fan@oss.nxp.com>
On 22/06/2022 08.13, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> i.MX8MP iomux pad BIT3 and BIT0 are reserved bits. Writing 1 to the
> reserved bit will be ignored and reading will still return 0. Although
> function not broken with reserved bits set, we should not set reserved
> bits.
Thank you, these have really been bugging my while trying to bring up an
imx8mp-based board and adding the right pinmux settings - not knowing
whether there was some undocumented effect from including one of those
bits has led me astray more than once.
One question: E.g. in patch 11, you change the setting from 0x49 to
0x40, which is of course exactly what the patch description says. But
when bit 8 (PE) is not set, is there any effect from either setting of
bit 6 (PUE)? Not that I suggest changing to 0x00, but I'm just curious.
For the series:
Reviewed-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
next prev parent reply other threads:[~2022-06-22 6:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:13 Peng Fan (OSS)
2022-06-22 6:13 ` [PATCH 01/14] arm64: dts: imx8mp-evk: correct mmc " Peng Fan (OSS)
2022-06-22 6:13 ` [PATCH 02/14] arm64: dts: imx8mp-evk: correct the uart2 pinctl value Peng Fan (OSS)
2022-06-22 6:13 ` [PATCH 03/14] arm64: dts: imx8mp-evk: correct gpio-led pad settings Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 04/14] arm64: dts: imx8mp-evk: correct vbus " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 05/14] arm64: dts: imx8mp-evk: correct eqos " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 06/14] arm64: dts: imx8mp-evk: correct vbus " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 07/14] arm64: dts: imx8mp-evk: correct I2C5 " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 08/14] arm64: dts: imx8mp-evk: correct I2C1 " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 09/14] arm64: dts: imx8mp-evk: correct I2C3 " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 10/14] arm64: dts: imx8mp-venice-gw74xx: correct " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 11/14] arm64: dts: imx8mp-phyboard-pollux-rdk: correct uart " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 12/14] arm64: dts: imx8mp-phyboard-pollux-rdk: correct eqos " Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 13/14] arm64: dts: imx8mp-phyboard-pollux-rdk: correct i2c2 & mmc settings Peng Fan (OSS)
2022-06-22 6:14 ` [PATCH 14/14] arm64: dts: imx8mp-icore-mx8mp-edim2.2: correct pad settings Peng Fan (OSS)
2022-06-22 6:31 ` Rasmus Villemoes [this message]
2022-06-25 12:41 ` [PATCH 00/14] arm64: dts: imx8mp: " Peng Fan (OSS)
2022-06-22 7:06 ` Uwe Kleine-König
2022-06-22 8:14 ` Peng Fan
2022-06-27 7:56 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f2ba58-acd9-a214-83f2-037f669d8d59@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=abbaraju.manojsai@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jagan@amarulasolutions.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matteo.lisi@engicam.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=t.remmet@phytec.de \
--cc=t.remmet@phytec.deh \
--cc=tharvey@gateworks.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®