From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA0F33F5A3 for ; Mon, 18 May 2026 05:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779080457; cv=none; b=etHVYT+PdlnLmTU6vrnnR8S3dsTbVrMlNW0CMaCjdpx8XD/8oUcWLacWj8cOOUx+xOb/DEpBtS+0qRj/uwYO83mH05wWg8BxAbg6U6yYrAamRO2Qu0q/DiVezVZ2Gk7Pb2JJdtO3MLN05hYzVs3xw6yOye5a7LEGZBa5S32mddw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779080457; c=relaxed/simple; bh=j5L8abn7trrRnFjiGjawwxdkH3HWpmk2/h8C+GT+bEE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W5r0kP98YnXsIxpb32VOQx6T16AUTpEukLwmSO/rWC9TctZNLGMC2dS0Zb7ZotzPMzeqcy1UX+PpgRdBIsxsx1TThvod3Hv7hNHNEWJCvJmW02k9ACLZSdHq4rq1B4lCdHpeZPxU3W8cNi4ACoHvfRkuXsNMS6F1xbG+gl5OVQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HWdOWxzJ; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HWdOWxzJ" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36810434abaso157384a91.0 for ; Sun, 17 May 2026 22:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779080456; x=1779685256; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1idOwy53kR7o+gaXCnXuC8j6usF8duhi1khMI+JkZeo=; b=HWdOWxzJFabaIewK5kGWuVa0HCY6IwEgL4Fo1Cq5baV38SKg5nKxVkpfFja/3BjJFU X34SOozns2h4+RyFElMPjjHOlCgXAi25ZY0ilp69Qkx/bh3bV+t4DHlBOyFjpXDyWG2G W624EzB6frV7JXUBlJYC3wsruzqezNHDNrInS/J3GOyK/EZ+CHbOCkDDoitYyYgAoASu JY781amg7rtpsq9RDIgqu9X2hcU2kf6Cr+Rgke63bBeNza08RQdrR1g/Mq4JCvi2tiZk lUwvt5FPEkMP8so966tRpFPy4CQ/grc0BCIr8efNB4UlGOClROIU8QVQt9nAxg/R+yOs ywww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779080456; x=1779685256; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1idOwy53kR7o+gaXCnXuC8j6usF8duhi1khMI+JkZeo=; b=bhkYutuW+TtqeSa/PiFnyzrMUbMiG5pynxJhS8L+LQOoR+XpOKQN1Y1VFjt3DQemGJ WHCpnMbQu3CeO9AcMemvX69csO3irQVuA5EFOVnaWFx9tmcpucuCML3WbH/t9HkJfDLn CIcqeBjr/StfrqvVe7H8XamFwEqxfN6Ynv7DSOFJSmOOOD5kLJJl85+D4OM4FScuLlx7 1xgfwL/Z/6ucCQOFV67hRURcIsGBGVT1e/ItqtcE6eSUq3kULIC5jT8ehiJ0tNTmy7gM UQsWdeN62XjiEIDfKA/M2f0rHHcOhrVtt7476PczJG2nbgNe71ODwKb7/Pf/t/UTB7/h 6/Xg== X-Forwarded-Encrypted: i=1; AFNElJ/E6FcBfFrYf2BSoUTq9+7ER08BrjlXG4jTQKZ0FekNR+HHaMhVHznGZe3nGRtkGB3XjjWyCE2Y0gOW9Ho=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/ZJRbCBHzGUsuoyBGy9OA5jAs1GZ8i5lvjni6r+ve91LSFXow tHQcHmQtxcI41nEmhiV4Yg0uOfsd3iFJpoZFZv9t7urZ3HdBOaykZgfY X-Gm-Gg: Acq92OEtlAdtvn23jCaNCKOufeWaR0sL4wNRE9YYGISjQLtc7cwfjFeFYntFyRC5egw 5wLtXxFgp4nEY6sVwAKY4uz3T1tkgoQALXGOz6TSd0qK33Znw4ZQ3UpnYMB2xYEwdaUm4Mo0uNX EZVRvwkSlZcKiqer0cNEn0Bjo96a2VM9MQfzNYv0zGDKtMNUjEOqxNCnRa5tcWtXyUH0hTkM2fc wRExfFK59GU5XYlEwunoCldxqg3XEPXhAsYFK0uqTXSWng8t8P3alPlBBd+RHYtHs4Vr5QBGJWE mw5k6eI5R0eqHYKhIXTGMiY5mjyGdeziryTRHjdc7kJsT7OkBO+50fmlIvQl/Wi95uB7NkN7smw LqEO0MQeJ0uFJAj+sxg8Q3CVTq2kB81WXxKUiXaZMPDtGLgP9PWhadS3YuuSOZ1Onn4occHnyx0 3wW7jTMUXe/J0qxN/OPuyITedDL4m0zM2lzw== X-Received: by 2002:a17:90b:4d0d:b0:368:44d:bbac with SMTP id 98e67ed59e1d1-36951ca93d8mr7318737a91.6.1779080455621; Sun, 17 May 2026 22:00:55 -0700 (PDT) Received: from [192.168.1.7] ([159.192.167.244]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-369517d8570sm9954272a91.14.2026.05.17.22.00.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2026 22:00:55 -0700 (PDT) Message-ID: <42f37513-2686-41a9-ba88-c9bdf67d131a@gmail.com> Date: Mon, 18 May 2026 12:00:51 +0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] USB: serial: qcserial: add new usb-id for Dell Wireless DW5826e-m To: Jack Wu , Johan Hovold , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260518015418.327252-1-jackbb_wu@compal.com> Content-Language: en-US From: Lars Melin In-Reply-To: <20260518015418.327252-1-jackbb_wu@compal.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-05-18 08:54, Jack Wu wrote: > Add support for Dell DW5826e-m with USB-id 0x413c:0x81ea & 0x413c:0x81eb. > > It is 0x413c:0x81ea > T: Bus=02 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#=110 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=413c ProdID=81ea Rev= 5.04 > S: Manufacturer=DELL > S: Product=DW5826e-m Qualcomm Snapdragon X12 Global LTE-A > S: SerialNumber=358988870177734 > C:* #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA > A: FirstIf#=12 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=qcserial > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=usbfs > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=qcserial > E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=qcserial > E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 4 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > E: Ad=87(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I:* If#=12 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim > E: Ad=88(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I: If#=13 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > I:* If#=13 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=0f(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > It is 0x413c:0x81eb > T: Bus=02 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#=109 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=413c ProdID=81eb Rev= 0.00 > S: Manufacturer=DELL > S: Product=DW5826e-m Qualcomm Snapdragon X12 Global LTE-A > S: SerialNumber=358988870177734 > C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr= 2mA > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=qcserial > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > Signed-off-by: Jack Wu > --- > v2: > -sorted by PID and add the newline separator before the Huawei devices. > --- > --- > drivers/usb/serial/qcserial.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c > index 1a930dc668e4..bb1647a17066 100644 > --- a/drivers/usb/serial/qcserial.c > +++ b/drivers/usb/serial/qcserial.c > @@ -186,9 +186,11 @@ static const struct usb_device_id id_table[] = { > {DEVICE_SWI(0x413c, 0x81d0)}, /* Dell Wireless 5819 */ > {DEVICE_SWI(0x413c, 0x81d1)}, /* Dell Wireless 5818 */ > {DEVICE_SWI(0x413c, 0x81d2)}, /* Dell Wireless 5818 */ > + {DEVICE_SWI(0x413c, 0x81ea)}, /* Dell Wireless DW5826e-m */ > + {DEVICE_SWI(0x413c, 0x81eb)}, /* Dell Wireless DW5826e-m QDL */ > {DEVICE_SWI(0x413c, 0x8217)}, /* Dell Wireless DW5826e */ > {DEVICE_SWI(0x413c, 0x8218)}, /* Dell Wireless DW5826e QDL */ > - > + > /* Huawei devices */ > {DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */ > > -- > 2.34.1 > > > > ================================================================================================================================================================ > This message may contain information which is private, privileged or confidential of Compal Electronics, Inc. If you are not the intended recipient of this message, please notify the sender and destroy/delete the message. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon this information, by persons or entities other than the intended recipient is prohibited. > ================================================================================================================================================================ > Hi Jack, DEVICE_SWI is intended for non-GOBI Sierra Wireless devices or DELL branded version of them which the DW5934e isn't. A DEVICE_SWI interface layout has a QMI/RMNET function in interface #8 which the DW5934e hasn't. So the DW5934e does not belong in qcserial, it should instead be added in the serial option driver. thanks Lars