From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125D3C001E0 for ; Wed, 9 Aug 2023 09:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbjHIJDC (ORCPT ); Wed, 9 Aug 2023 05:03:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbjHIJDA (ORCPT ); Wed, 9 Aug 2023 05:03:00 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48D361FCD; Wed, 9 Aug 2023 02:03:00 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37990QBt002136; Wed, 9 Aug 2023 09:02:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=APN9R81y1vkzZ+bon6ieesrBDLEA2EFWpxUvuuoF+0E=; b=MeL0oUWa+w34dUaK4XODCPFKM9LHZg178MZjPkEwqzLNTpmLnMZ5aYiHLePNMA73lnPw EekK4UpHgPuXf+mhOd3v6WdE7vZSYNo2G4QLU1JA3JfhuYsZfVATWBXV/+loRlUchKRg Lp0WDBrS+/f//8VkS+nZyILhCn5EvIrdcY4v7ZcgMt8uIwYB70pQCoRbzV0UtJIG935D BaVpK88LOdsTsedhQbs+qmRKCAUB7u0UMVHLWsVlmVQYfsmQKc3dp2tvnoL9XaBwBNDb uyU2OzVKpTuXbD1eEma4ayUSgkQPKXCyWi+NrA+zuAoTXje+1szuZH23codLk8zX/WVj 5A== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sc0050wv7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Aug 2023 09:02:44 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37992h3V026256 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 09:02:43 GMT Received: from [10.204.118.225] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 9 Aug 2023 02:02:40 -0700 Message-ID: <42f78c02-1ddc-cf1c-694f-abf9059dfb60@quicinc.com> Date: Wed, 9 Aug 2023 14:32:37 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI"" Content-Language: en-US To: Johan Hovold , Kalle Valo CC: Jeff Johnson , Bjorn Andersson , Manivannan Sadhasivam , Konrad Dybcio , , , References: <20230809073432.4193-1-johan+linaro@kernel.org> From: Manikanta Pubbisetty In-Reply-To: <20230809073432.4193-1-johan+linaro@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: uzOrskq2NaRDOacIBiyeeIdxixkzHzf- X-Proofpoint-GUID: uzOrskq2NaRDOacIBiyeeIdxixkzHzf- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-09_07,2023-08-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0 mlxscore=0 adultscore=0 phishscore=0 clxscore=1011 mlxlogscore=780 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308090079 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/9/2023 1:04 PM, Johan Hovold wrote: > This reverts commit d265ebe41c911314bd273c218a37088835959fa1. > > Disabling threaded NAPI causes the Lenovo ThinkPad X13s to hang (e.g. no > more interrupts received) almost immediately during RX. > > Apparently something broke since commit 13aa2fb692d3 ("wifi: ath11k: > Enable threaded NAPI") so that a simple revert is no longer possible. > This is getting as weird as it would get :) > As commit d265ebe41c91 ("Revert "wifi: ath11k: Enable threaded NAPI"") > does not address the underlying issue reported with QCN9074, it seems we > need to reenable threaded NAPI before fixing both bugs properly. > It seems that the revert has actually solved the issue reported with QCN9074. https://bugzilla.kernel.org/show_bug.cgi?id=217536 We were trying to reproduce the problem on X86+QCN9074 (with threaded NAPI) from quite some time, but there is no repro yet. Actually, enabling/disabling threaded NAPI is a simple affair; I'm wondering to hear that interrupts are blocked due to not having threaded NAPI. What is the chip that Lenovo Thinkpad X13s is having? Thanks, Manikanta