From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D0E0225D6; Tue, 4 Mar 2025 10:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741083250; cv=none; b=O+0s7PvFxLv7JoetwJyZ4CgyAXONFDOrkxsl+6RgXMy+BDpBycyEy8fHz6s06AfaAPR5TCWSw7sWPt3/FCp9UXeOOSDj/oKFVOkbgeUjbH4MyAOJ5hrPkZUaFTUhg9u2E1VlSqRjhMWRuZVEvQ+pCgQobXxz/ITPctaKJwMa1yo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741083250; c=relaxed/simple; bh=nVYc677Ele0ikzjRYqh2SrNDdyVzXrYDl80xL+1622g=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=rgzqmYmEWYdt5dDmXVGXI/YUEBUcxPco7AnkL8mKy+W/m3dbgg9BPCOSPLEjgKiD4bZPr57X71EQrheD7NWD4NmTkk598arNOiNFqW4Anhte6bd4TzAT9cbtF0kxLpEW8/8BUeecQzKQxvbYc6QokUSL8C4CLyO3DeYIabUzfHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=aJhuQXFt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="aJhuQXFt" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 524ACQH4005995; Tue, 4 Mar 2025 10:13:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BhKtjnk1MeKajNiWxKWlMEudNu9Ky7L1pBQ8CJDBqEI=; b=aJhuQXFtajRB/mow 7/8veCSnSPKW0DgBHYOKB3dhn/H5lB4xG3QFezdWknALC+SCbJdpXm0X1dwppP+p U01CzBmi0+gT4worMTp9GbnEW+qeEtG8NEhxytUZINQPJAfidWdYdbyMeXcdp3XB NRtKa2M54ocjl79dmUvNQbrP3i+Did7cTn+LcXUCnZpD9dpAM4hWr5htJAmXSKKk FgWkI1NG37NdjFITxINXMSvGaFu/lve02WFiUP3bEfDANwHBm3Bi1hH+Of4LXXFg TxU/O/GwDDJ3IRRcQEYfCoz21ZbQHi1N5NVmMCdmLd8Z0hHUEHJElfjr1AdK5kau 9PpnZQ== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 455p6thfv4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Mar 2025 10:13:48 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 524ADlSp009962 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 4 Mar 2025 10:13:47 GMT Received: from [10.206.97.61] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 4 Mar 2025 02:13:38 -0800 Message-ID: <42fe61c5-4552-406d-b698-aa766f57cfb3@quicinc.com> Date: Tue, 4 Mar 2025 15:43:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/11] arm64: dts: qcom: sa8775p-ride: enable Display serial interface To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , , , , , , , , References: <20250225121824.3869719-1-quic_amakhija@quicinc.com> <20250225121824.3869719-9-quic_amakhija@quicinc.com> <5293f723-2a27-4d2a-8939-059226d460c3@quicinc.com> Content-Language: en-US From: Ayushi Makhija In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=HZbuTjE8 c=1 sm=1 tr=0 ts=67c6d25c cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=KMNGZfKfLVgBrRNt_q4A:9 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: CFNBxu6vzxY5_n2jeI7G68lK64u25Qw3 X-Proofpoint-ORIG-GUID: CFNBxu6vzxY5_n2jeI7G68lK64u25Qw3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-04_04,2025-03-03_04,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 mlxscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503040086 On 3/4/2025 3:18 PM, Dmitry Baryshkov wrote: > On Tue, 4 Mar 2025 at 10:45, Ayushi Makhija wrote: >> >> On 2/25/2025 11:25 PM, Dmitry Baryshkov wrote: >>> On Tue, Feb 25, 2025 at 05:48:21PM +0530, Ayushi Makhija wrote: >>>> Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. >>>> >>>> Signed-off-by: Ayushi Makhija >>>> --- >>>> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++- >>>> 1 file changed, 64 insertions(+), 2 deletions(-) >>> >>> Please squash into the previous patch. It doesn't make a lot of sense separately. >>> >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> index 151f66512303..02d8a9c2c909 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> @@ -128,6 +128,30 @@ dp1_connector_in: endpoint { >>>> }; >>>> }; >>>> }; >>>> + >>>> + dsi0-connector { >>> >>> dpN-connector. It is not DSI. >> >> Hi Dmitry, Konrad >> >> Thanks, for the review. >> >> I will change dsi0-connector -> dp2-connector and dsi1-connector -> dp3-connector respectively. > > Why? It's then dp-dsi0-connector. I think the board has DP2 and DP3 > (please correct me if I'm wrong). How would you name those if you use > those indices for DSI connectors? > Hi Dmitry, Thanks, for the review. yes, you are correct there are total 4 DP connectors and 2 DSI to DP connectors on the device, better to keep the node name as dp-dsi0-connector and dp-dsi1-connector respectively. Thanks, Ayushi