From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: Jens Wiklander <jens.wiklander@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
op-tee@lists.trustedfirmware.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
Date: Sun, 31 Jan 2021 09:13:48 +0100 [thread overview]
Message-ID: <42ff3eaa-d561-93ae-b5c4-28b675bdea4f@pengutronix.de> (raw)
In-Reply-To: <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
Hi Jens,
On 29.01.21 14:29, Jens Wiklander wrote:
> Hi Rouven and Sumit,
>
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@lists.trustedfirmware.org> wrote:
>>
>> Hi Rouven and Sumit,
>>
>> On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
>> <jens.wiklander@linaro.org> wrote:
>>>
>>> Testing need_resched() before cond_resched() is not needed as an
>>> equivalent test is done internally in cond_resched(). So drop the
>>> need_resched() test.
>>>
>>> Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
>>> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>>> ---
>>> drivers/tee/optee/call.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> Can you please test to see that this works in your setups too?
>
> Does this work for you? I'd like to get this patch ready for v5.12.
Yes it does. I also looked at it right after Arnds mail, so for future
reference:
cond_resched()
_cond_resched() (ifndef CONFIG_PREEMPTION)
should_resched(0)
tif_need_resched() (+ preempt_count == 0 for current thread)
while:
need_resched()
tif_need_resched()
You can add my
Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
I also retested on the STM32-DK2 and the problem remains fixed:
Tested-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Regrads and thanks for the patch,
Rouven
next prev parent reply other threads:[~2021-01-31 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 9:54 Jens Wiklander
2021-01-25 9:57 ` Jens Wiklander
[not found] ` <0100017738faac80-87e5cf40-6a5a-4727-9c36-382fb909c8ff-000000@email.amazonses.com>
[not found] ` <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
2021-01-31 8:13 ` Rouven Czerwinski [this message]
2021-02-01 5:02 ` Sumit Garg
2021-02-03 7:10 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ff3eaa-d561-93ae-b5c4-28b675bdea4f@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=arnd@kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®