From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hangyu Hua <hbh25y@gmail.com>,
bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
gregkh@linuxfoundation.org
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rpmsg: fix possible refcount leak in rpmsg_register_device_override()
Date: Thu, 23 Jun 2022 12:57:07 +0200 [thread overview]
Message-ID: <42ff7e04-5e32-7fee-d874-a983dcede4a0@linaro.org> (raw)
In-Reply-To: <2d7eaa45-2193-7fcb-5c9b-6394bab2ae95@gmail.com>
On 23/06/2022 12:53, Hangyu Hua wrote:
> On 2022/6/23 16:15, Krzysztof Kozlowski wrote:
>> On 23/06/2022 09:36, Hangyu Hua wrote:
>>> [1] commit 1680939e9ecf ("rpmsg: virtio: Fix possible double free in
>>> rpmsg_virtio_add_ctrl_dev()")
>>> [2] commit c2eecefec5df ("rpmsg: virtio: Fix possible double free in
>>> rpmsg_probe()")
>>> [3] commit bb17d110cbf2 ("rpmsg: Fix calling device_lock() on
>>> non-initialized device")
>>
>> I think only the last [3] introduced it, because it's the commit missing
>> put_device in first error path.
>>
>
> I see. Do i need to change the commit log and then send a v2?
Yes, please. With my Reviewed-by tag.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-23 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 7:36 Hangyu Hua
2022-06-23 8:15 ` Krzysztof Kozlowski
2022-06-23 10:53 ` Hangyu Hua
2022-06-23 10:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ff7e04-5e32-7fee-d874-a983dcede4a0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hbh25y@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®