mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: "vulab@iscas.ac.cn" <vulab@iscas.ac.cn>
Cc: "sathya.prakash@broadcom.com" <sathya.prakash@broadcom.com>,
	"sreekanth.reddy@broadcom.com" <sreekanth.reddy@broadcom.com>,
	"suganath-prabu.subramani@broadcom.com"
	<suganath-prabu.subramani@broadcom.com>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"MPT-FusionLinux.pdl@broadcom.com"
	<MPT-FusionLinux.pdl@broadcom.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 回复: [PATCH] scsi: mpt3sas: Fix invalid NUMA node index
Date: Mon, 26 Jan 2026 08:33:02 +0000	[thread overview]
Message-ID: <43040a4e-c2e2-4f51-b4a0-13ebd546cf46@oracle.com> (raw)
In-Reply-To: <SE5P216MB338083B78B7FFF35811F70A3FCBCA@SE5P216MB3380.KORP216.PROD.OUTLOOK.COM>

>>                  */
>>                 if (ioc->high_iops_queues) {
>> -                     mask = cpumask_of_node(dev_to_node(&ioc->pdev->dev));
>> +                     int nid = dev_to_node(&ioc->pdev->dev);
>> +
>> +                     if (nid == NUMA_NO_NODE)
>> +                             nid = 0;
>> +                     mask = cpumask_of_node(nid);
> 
> Some versions of cpumask_of_node() handle NUMA_NO_NODE gracefully and
> some don't.
> 
> For the core drivers/base/arch_numa.c version, it returns cpu_all_mask
> (for NUMA_NO_NODE) - so your behaviour here is different.

I sent a series to make all versions of cpumask_of_node() handle 
NUMA_NO_NODE:
https://lore.kernel.org/lkml/20260107094007.966496-1-john.g.garry@oracle.com/

Please check it and provide Tested-by/Reviewed-by tags if you are happy 
with it.

Thanks,
John

      parent reply	other threads:[~2026-01-26  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30  3:14 Haotian Zhang
2025-12-30  7:45 ` John Garry
     [not found]   ` <SE5P216MB338083B78B7FFF35811F70A3FCBCA@SE5P216MB3380.KORP216.PROD.OUTLOOK.COM>
2026-01-02 10:33     ` 回复: " John Garry
2026-01-26  8:33     ` John Garry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43040a4e-c2e2-4f51-b4a0-13ebd546cf46@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®