From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbbIHWAZ (ORCPT ); Tue, 8 Sep 2015 18:00:25 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:58318 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750826AbbIHWAW (ORCPT ); Tue, 8 Sep 2015 18:00:22 -0400 From: "Rafael J. Wysocki" To: Peter Zijlstra Cc: Jiang Liu , mingo@kernel.org, "Rafael J. Wysocki" , Tejun Heo , linux hotplug mailing , Linux Kernel Mailing List , ACPI Devel Maling List Subject: Re: Possible deadlock related to CPU hotplug and kernfs Date: Wed, 09 Sep 2015 00:28:12 +0200 Message-ID: <4305045.rOCzS8rSge@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150908104008.GD3644@twins.programming.kicks-ass.net> References: <55E54FE2.7030601@linux.intel.com> <2165815.z3RZSlC1oy@vostro.rjw.lan> <20150908104008.GD3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 08, 2015 12:40:08 PM Peter Zijlstra wrote: > On Mon, Sep 07, 2015 at 11:33:21PM +0200, Rafael J. Wysocki wrote: > > On Monday, September 07, 2015 11:11:19 AM Jiang Liu wrote: > > Peter, Ingo, some help from lockdep expert is needed. > > > > We have a splat that almost certainly is a false positive (the original report > > is here http://marc.info/?l=linux-kernel&m=144109156901959&w=4) and no ideas > > how to make it go away. Can you please have a look and advise? > > I can't even find the relevant code :/ > > From that email I get kernfs_fop_write() which calls > kernfs_get_active(), but that does _NOT_ call cpu_up(), so that > callchain is shite. > > The actual lockdep splat is also not really helpful, and is spraying > names over: acpi, device, sysfs and kernfs (do we really need that many > layeres of obfuscation for a simple file?) > > So, please, start by explaining the thing proper such that simple people > like me know what to look for. OK, I'll try to get that later this week. Or maybe Jiang Liu can beat me to doing that. :-) Thanks, Rafael