From: Paul Parsons <lost.distance@yahoo.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: linux-kernel@vger.kernel.org, rpurdie@rpsys.net
Subject: Re: [PATCH 2/2] leds: Add ASIC3 LED support
Date: Tue, 3 May 2011 21:25:19 +0100 (BST) [thread overview]
Message-ID: <430965.32751.qm@web29011.mail.ird.yahoo.com> (raw)
In-Reply-To: <1304421107.15687.15.camel@flow>
Hi Philipp,
--- On Tue, 3/5/11, Philipp Zabel <philipp.zabel@gmail.com> wrote:
> About this, see the other patch I sent. This should work
> with the GPIOs
> configured as outputs.
See my response on the other thread.
> I'd just use DIV_ROUND_CLOSEST((ms)*1024, 32000) here.
Will change.
> Could be moved into struct resource definitions in
> asic3.c.
> Get to them with platform_get_resource() in
> asic3_led_probe().
> After calculating the bus shift from the resource size, you
> have
> everything you need to get rid of the
> asic3_write_register() export.
I understand, but my feeling is that implementing a more generic mechanism will add complexity for little obvious gain. If the LED driver ever needs to be more generic then this can be revisited.
> Why not just return mfd_cell_disable(pdev);?
It wasn't always at the end of the function as it is now! Will change.
Regards,
Paul
next prev parent reply other threads:[~2011-05-03 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-30 17:59 Paul Parsons
2011-05-03 11:11 ` Philipp Zabel
2011-05-03 20:25 ` Paul Parsons [this message]
2011-05-04 7:48 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430965.32751.qm@web29011.mail.ird.yahoo.com \
--to=lost.distance@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®