From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] arm64: dts: qcom: msm8998-oneplus-cheeseburger: fix backlight pin function
Date: Fri, 14 Oct 2022 10:36:53 +0200 [thread overview]
Message-ID: <430edaff-2562-0283-d70c-3d26995c56d6@somainline.org> (raw)
In-Reply-To: <20221013210612.95994-2-krzysztof.kozlowski@linaro.org>
On 13.10.2022 23:06, Krzysztof Kozlowski wrote:
> There is no "normal" function, so use "gpio" for backlight button pin
> configuration.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
>
> Changes since v2:
> 1. None
> ---
> arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> index ef2a88a64d32..122f6c25220e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> @@ -35,7 +35,7 @@ &pmi8998_gpio {
> button_backlight_default: button-backlight-state {
> pinconf {
> pins = "gpio5";
> - function = "normal";
> + function = "gpio";
> bias-pull-down;
> qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
> };
next prev parent reply other threads:[~2022-10-14 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 21:06 [PATCH v3 1/4] arm64: dts: qcom: msm8998: add gpio-ranges to TLMM Krzysztof Kozlowski
2022-10-13 21:06 ` [PATCH v3 2/4] arm64: dts: qcom: msm8998-oneplus-cheeseburger: fix backlight pin function Krzysztof Kozlowski
2022-10-14 8:36 ` Konrad Dybcio [this message]
2022-10-13 21:06 ` [PATCH v3 3/4] arm64: dts: qcom: msm8998: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-10-14 13:48 ` Konrad Dybcio
2022-10-13 21:06 ` [PATCH v3 4/4] dt-bindings: pinctrl: qcom,msm8998: convert to dtschema Krzysztof Kozlowski
2022-10-17 22:54 ` Bjorn Andersson
2022-10-14 13:47 ` [PATCH v3 1/4] arm64: dts: qcom: msm8998: add gpio-ranges to TLMM Konrad Dybcio
2022-10-18 3:05 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430edaff-2562-0283-d70c-3d26995c56d6@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®