From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67D6819C542 for ; Fri, 29 Nov 2024 11:45:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732880704; cv=none; b=oKnB293CrM2w+gyEiAhuBO3njJMDrsto1HHtKfvInzjA9LNLguJB2DGUE0dEUyRJ9UT0nnAKSbx3Rsrt8WQoiyXM45dLKbsRxbyb5Kvts7s41qy7uudqzf01b5BGZYIVHfDNHuBJBNu8ac2YZiN+5SXSvbzqW4qZ8Wkjy7xa8Xs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732880704; c=relaxed/simple; bh=vwruG2+sJ1nGAh5frWQN5bFRWPjIzvcKdp9Bgr1gc8w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZoIUZDa/uOJ8U89amuu0EoqJLFowlsY/2DZ/jb+rlfVxDEmzx+ID4jB5Oyk6eToLCUsI23bsr5k1LbAnryDtFhhCzeWBcbzpnzcpBC+tUiY6gjx7hs6LERfOoeiHpdeRLpkkO/5XBAdBagMVKwvQU1I5fdOJNLhgsTObjoAkRTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KFq0wm/U; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KFq0wm/U" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ffbab9bc6eso606961fa.3 for ; Fri, 29 Nov 2024 03:45:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732880700; x=1733485500; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZIubI06rjZ+HsV0fP2YkTawH+ehNtsEbQuHIS42n8ug=; b=KFq0wm/UA11q4JrJZmbJ/WdUVVoYP48BrLwbmZVShWxDCdtLQL3/yeETPxrJnpeURS kpMkxQQDmZnlePnmfldJB5mNM1J4KvVpOaU2yMT6CUlemTweEvvftpS9VEPWq51uep9w aWo0igBl3XhxN3dfPmEvmZBdEjxgF1NiNERmSpjhPVFaGf6VdT2HtGSwQWiUPxCjeP4G w7e0b0h1IvckLZVYfgXr3OgNICphWqumqNuSvdUBPhuwofZX/9cnAyYy98PsyG6zoyda gkZ3rSlLLJxPVzrai2t7CEcFLV4+1bwWr2uu7aSUCRD9eeAq53rZPhfcEMnRmFjSD1yN woUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732880700; x=1733485500; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZIubI06rjZ+HsV0fP2YkTawH+ehNtsEbQuHIS42n8ug=; b=dXbbZvET/efwuIh/RPJKfni2yccU3H2QLKLnJ09v/hn14MZ8wCKvMcn4k5RdgvctSt rQrFYOpUIghdNjDjEyqZYsqwseUYUf/R+1az1dP3GG7T90ThXfm7AbebJW50BuY0QGDL D2nV4i2FswFhd7FY3EjR1gxKvD4V2F6couLAhj57ngmXsc4jQYhdNp8GXDaWrxiZG7HV b0R+ty6xlVuO70MA2AUCW6k7JFbGKUdOsr2ALydcl9pmsuP0Kaq3id8yPPEqioULsEko 1hphfdKPWoaHabMd5Pw7DWRonxDVYFmFcrmfsLYeM4cOtyts1hOPzN9iyry7IT9xKL63 Edug== X-Forwarded-Encrypted: i=1; AJvYcCXBgaSfJyKPkPORJp46dYIT4KrbmYcBNoQP3j6WH+Apvyx0fPCGE3mBDCMUXHKP4xCPqKo1CRkpfK13d1k=@vger.kernel.org X-Gm-Message-State: AOJu0YzOWSmCCaDQEfZZ5MC6Qe3x8mFIbRQ+cAKdp/I1zBh7iXz3vYld 1otr96P2UnOH9sOeEE2LNZUqn5NfxiqB28f0QXOdOWPRIKibh6VdmW0uiDo6194= X-Gm-Gg: ASbGnctIfyVH+HOyIwXNssxD4ihNXJpZgt3UpO3FSyxdla3Ix8QM7WNMBJAV0NQzgx6 XHZuhrM8PWkFtffX3uGgQ9NXMgPy1xy3qbT+FtGiURds+K7qSm0978F25I92EDrK47B/itqOeoT mx7OKZ9rZhiQNkltfqsJEB7LYCBeGprD4qA9FaPY0mUSti0p7qslfgYbav6LMkvQdOfGyorL9ox RTiOVhQWpbwiIG5xy7Z7U6j2xVjZS4a9nu1VvSftTyPazMTfOxHCqAVblPzSjo7pq5IW40wZ5iG LlJ/xMtmnaL/kf+Ci2JDPGRaE8vE X-Google-Smtp-Source: AGHT+IHyQtTPqhAYKXLJIJ4i6stHUjQzZgnRuUAkMJCFZKDMU3bYch34xfZyV7PfFiN8rzCQcIWeaw== X-Received: by 2002:a05:651c:1545:b0:2ff:a8db:4e7d with SMTP id 38308e7fff4ca-2ffd5ffeb04mr12980741fa.2.1732880700431; Fri, 29 Nov 2024 03:45:00 -0800 (PST) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ffdfca127fsm4432851fa.106.2024.11.29.03.44.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2024 03:44:59 -0800 (PST) Message-ID: <4310164e-4000-4cff-a093-7986f71fc02a@linaro.org> Date: Fri, 29 Nov 2024 13:44:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] clk: qcom: common: Add support for power-domain attachment Content-Language: en-US To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241128-b4-linux-next-24-11-18-clock-multiple-power-domains-v5-0-ca2826c46814@linaro.org> <20241128-b4-linux-next-24-11-18-clock-multiple-power-domains-v5-2-ca2826c46814@linaro.org> <9b9bf718-b5a5-4fef-810a-1206743495f6@linaro.org> <7cf4ce25-742c-48ff-99e0-bbbaea370e89@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <7cf4ce25-742c-48ff-99e0-bbbaea370e89@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/29/24 13:39, Bryan O'Donoghue wrote: > On 29/11/2024 11:30, Vladimir Zapolskiy wrote: >>> +    ret = devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list); >> >> Please make a call to the function like this: >> >>     ret = devm_pm_domain_attach_list(dev, NULL, &cc->pd_list); > > Passing &pd_data will cause devm_pd_domain_attach_list() to cycle > through the power-domains listed and do dev_pm_domain_attach_by_id(); Doesn't it cycle for pd_data.num_pd_names times? Which is zero. > instead of dv_pm_domain_attach_by_name(); > > That's what &pd_data is passed here. You want to have that simple > attachment of the power-domain list. I look at dev_pm_domain_attach_list() function with my best efforts to concentrate and see no functional difference between your version and the one proposed by me since v1. -- Best wishes, Vladimir