From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbbKLNph (ORCPT ); Thu, 12 Nov 2015 08:45:37 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:57733 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbKLNpd (ORCPT ); Thu, 12 Nov 2015 08:45:33 -0500 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: DengChao , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Y2038] [PATCH] fs:affs:Replace time_t with time64_t Date: Thu, 12 Nov 2015 14:45:28 +0100 Message-ID: <4312946.SmG7PJzsvD@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1447335641-14768-1-git-send-email-chao.deng@linaro.org> References: <1447335641-14768-1-git-send-email-chao.deng@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:i3vufTi0mln8ETeuoWJKD1c2X46VJhNg5EuTdUQn0LnRY+ydNt8 rV18ZuFFOKPGku/hxcrplK7uA0jOUjrXsaHAtLQZrBXN6j2LP5BnX5uR2YGr7+n+2D8kqn2 JTXYZpJY12eD1aHpjIMy6IHpnyiFoc9ojnYC7Jhs/B8NPRvuNMd1cE0xGZtr4tvrvv7QWny 2M0a9eLfwLHxvmURCnlDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:3PQ9j3zMHBQ=:l5EvkY1Zn3f83IiNziNnj6 NK+BPASMehDxjebhL7SxI8Ou4RANTH7ENUvD8nG46QkCfX2vSCVHNS/Kr5GMx3RcUDzjwwTNo h6cAwfGCCpdpWCp/leEzqA4/fVY2tgRt2J4Q7M1Vq7Dn4Y1KG99mS5sWiEdf7gHkeuh2gpxQ0 /+QnC2nVHO1/0ht4gklHg0KfL8mck9DHn+Q17FWGpuHIJ0236hlGc1xTxTioRHpjwNCCBS9ZK d5d8eN4nmaImTTPq3GKxvBQPOHsdiUmrc3LBNUXAYFLtXwGfV5LhBqWuzthT5usgOsd+cyF+s uE0DqwFaPtQkotUzh+NklDWZ4au/HdDlcMRKwleoVV5ziHgx030y94XR1OoCaW2XHi8K0OsRD kmwrIXd1FiflVMI0lqE4Bhitlhc2OIBoHnyGrkiVHzkpDsRFK/oTOjOlkTHORLNvq8uA/b92w rPPIUCldF0/2Gt+ylpWGZ9ZIpxcbQw7nM3iAca5SYscuabVOKWyLdtI4m+V8iINNg9w1YqeSI 7sHgq0Y1n5K+YTcUdImVSmE0OgdnUQUaraDMWEBq3ZveTZS3P/CC2MOx8u2eVlWW1b0UZMVXg 2GWz/rKz4s5rpVY593K7Uh3k/GXjzl37ox0Fc6RpIt0DJK9E2IxVECzh+mFq4hVL4h1Ks8EFC 49cdrakSJoGx1j5Yko26yoQDCvlnC+udCr0PBlHmm2J5koLXfrJ5NHw7aukCbtPGMgtGE1Cdt G83S+wE3IjfNzmmj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 November 2015 21:40:41 DengChao wrote: > The affs code uses "time_t" and "get_seconds()". This will cause > problems on 32-bit architectures in 2038 when time_t overflows. > This patch replaces them with "time64_t" and > "ktime_get_real_seconds()". This patch introduces expensive 64-bit > divsion in "secs_to_datestamp()", considering this function is not > called so often, the cost should be acceptable. > > Signed-off-by: DengChao > Looks good, Reviewed-by: Arnd Bergmann Is anyone picking up patches for random unmaintained file systems, or should we put it into the y2038 tree? Arnd