mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Yong Li <sdliyong@gmail.com>,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	k.kozlowski@samsung.com, mranostay@gmail.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: tmp006: Set correct iio name
Date: Mon, 25 Apr 2016 20:33:51 +0100	[thread overview]
Message-ID: <43150fbd-37ac-2d51-dd87-f41670417b96@kernel.org> (raw)
In-Reply-To: <1461296584-11918-1-git-send-email-sdliyong@gmail.com>

On 22/04/16 04:43, Yong Li wrote:
> When load the driver using the below command:
> echo tmp006 0x40 > /sys/bus/i2c/devices/i2c-0/new_device
> 
> In sysfs, the i2c name is tmp006, however the iio name is 0-0040,
> they are inconsistent. With this patch,
> the iio name will be the same as the i2c device name
> 
> Signed-off-by: Yong Li <sdliyong@gmail.com>
Peter, this looks right to me, but could you take a quick look as I guess
there might be a reason you did this in an unusual way originally?

Jonathan
> ---
>  drivers/iio/temperature/tmp006.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/temperature/tmp006.c b/drivers/iio/temperature/tmp006.c
> index 18c9b43..17c8413 100644
> --- a/drivers/iio/temperature/tmp006.c
> +++ b/drivers/iio/temperature/tmp006.c
> @@ -221,7 +221,7 @@ static int tmp006_probe(struct i2c_client *client,
>  	data->client = client;
>  
>  	indio_dev->dev.parent = &client->dev;
> -	indio_dev->name = dev_name(&client->dev);
> +	indio_dev->name = id->name;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->info = &tmp006_info;
>  
> 

  reply	other threads:[~2016-04-25 19:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22  3:43 Yong Li
2016-04-25 19:33 ` Jonathan Cameron [this message]
2016-04-25 20:59   ` Crestez Dan Leonard
2016-04-25 21:11     ` Jonathan Cameron
2016-04-26 10:57       ` Lars-Peter Clausen
2016-04-26 11:47         ` Yong Li
2016-04-26 12:01           ` Lars-Peter Clausen
2016-04-26 13:14             ` Yong Li
2016-04-26 15:21               ` Daniel Baluta
2016-04-27  3:42                 ` Yong Li
2016-04-27 16:58                 ` Crestez Dan Leonard
2016-04-28  8:25                   ` Lars-Peter Clausen
2016-04-28 13:24                     ` One Thousand Gnomes
2016-04-28 13:30                       ` Peter Meerwald-Stadler
2016-04-28 14:19                         ` Lars-Peter Clausen
2016-05-01 19:34                           ` Jonathan Cameron
2016-04-28 14:17                       ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43150fbd-37ac-2d51-dd87-f41670417b96@kernel.org \
    --to=jic23@kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=sdliyong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®