From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935413AbcHaOnv (ORCPT ); Wed, 31 Aug 2016 10:43:51 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:49177 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935154AbcHaOnt (ORCPT ); Wed, 31 Aug 2016 10:43:49 -0400 From: Arnd Bergmann To: Herbert Xu Cc: "David S. Miller" , Martin Schwidefsky , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] crypto: hide unused label Date: Wed, 31 Aug 2016 16:43:42 +0200 Message-ID: <43162306.qpl1kaeM3f@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160831143752.GA26616@gondor.apana.org.au> References: <20160829124050.3405624-1-arnd@arndb.de> <20160831143752.GA26616@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:HM+4mA1vH12oIMTiygwWh9+XZzTZXRnx4f/2d87A6nXbHI0Tlef qSRWkmStIZ16oIk0/FKv/gEx/DbggG19ZHf8QqGyuwGQWNTOOE1eY1xh4Fc3oK1wy6FRfQW 28gOUvmVWIW9+MXHsygshvEX82MoyzSAw8CsB8s0csSCAjEaUzOmjruomqVQUpVpbnlgQd9 AGhL0Cww4+6dvoW2qiByQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MOT+8ndtnMM=:crBYmSzxch8GpMSqHhGba/ Mha+f/dW/Jzi++qgdSQSb26EWoHS477VgW341DSCjr2TO2raAja2UKUsxSedxKqIidc1v0R/Z l3aikLDADszznc13UOcc7R+4/zbQLE+KnMiNGEwHZs71/xAE8TDBzMIYJs7pYJdCC9iy4Rue9 /D5XnyyHL3BfdHHUv8rJPqEJsOdHJUXWHTw7neCciV6NnfaOqo06xNrvk1IQiIcLf1IKYWk6X c/PxGNzTRISVVqRo6/MgcHe0rWy0CANXNszhtzh8s3EoRqW87NngBOQJu9B6JE2/q4y/lSGXU QUvXJ0NguAhfl3KmBmAm5Dae38kp7jJxTDvyZGLbZ/Ha+wNAzja53p8FJoA8q+hWAODRazVDC MBU0WjpuejdWUxEhsdca9yKqkUyyYcAvvgh3c5qDAnju13phywY/ESjQWGsDTzhZ1d/ydv+X8 dZZi/Jebfxwn43CuGc95TRnuvzZ1Mw1663Cle1uJK+SrJ4BY5riZu1LeimCyZ01T745UIqPmY /Bs/YUtDAj62rDhlYjxFr5SBo+wrZKM2xfGgSAP+4ANxrXRFNNFdkqa+yjca/ZQPxRK7pplQh qiu1446nPrRGPxnvft6maiwODzk7N8Ujmh8YBNefJ5RhIYbb6h3rnhFtJXY3C6SP/tbLudGaL ud388ok3pV6zwMNtWsT+S5yi0WrWNOp7pCF/ar37Vf2dvMbhxLHdZnnfMzOdkJSfgicmjqysY NREZhuxi53FNmYXL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 31, 2016 10:37:52 PM CEST Herbert Xu wrote: > On Mon, Aug 29, 2016 at 02:40:43PM +0200, Arnd Bergmann wrote: > > A recent change left an existing label unused in some configurations, > > as seen from a gcc warning: > > > > crypto/xor.c: In function 'calibrate_xor_blocks': > > crypto/xor.c:156:1: error: label 'out' defined but not used [-Werror=unused-label] > > > > This adds an #ifdef around it to match the one around the respective "goto". > > > > Signed-off-by: Arnd Bergmann > > Fixes: 39457acda913 ("crypto: xor - skip speed test if the xor function is selected automatically") > > Thanks for the patch. But I've already queued up a fix at > > https://patchwork.kernel.org/patch/9301603/ > Ok, that one looks like a nicer solution anyway. Arnd