From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B597E2D24A4 for ; Thu, 4 Sep 2025 12:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756988983; cv=none; b=Z4cD3s8emW/NKzoEeiZujrwhYSOg0kVVwtPNOdnDqDHcKp971t3NDFxVuvs16KOfYigb79GkpYff5uuC/+w0DgR2W/2cXp8wQSUZOPrXnPVxf+F9brOxMLBtvITrLJ0nEV/Sh+xyImKmnjT8sZK0lHwNcX+DjqhA8WYMRXUROgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756988983; c=relaxed/simple; bh=NaTSUK/YANwvnWqHuH4HFonnYt2wjCvewS1+Y4OYrpQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XOX80jKNq/695jcPah2z+QixAra2D274VxcVaorPnfO2D6KqVFPtt2AcbE/xPN7P8gllrPQiRT0Cb5NpVE8M3SLRWjC45MqKfBPhEUnBM4mO1E/uAP2xGQpZGOl/IVT7mUiDKfZBgSbFkWmuRVH+mAumHh/k8aZe0RQ2tZDMxBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fZpGWA3r; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fZpGWA3r" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5849X7iH013476 for ; Thu, 4 Sep 2025 12:29:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Pc3ppLOamamgYKL4ljuA5P2D +67aLZBUnwJLBZffFZM=; b=fZpGWA3roXcngdgQOTUEWduGYoO+2gm4KtS8ymWB HS+XgTBlCzKFZNyjaDvycJPmvZaQY/dfwKFNjr7EXJgoektZ6I1aSMwL+KICC+ey NkeE8pRqsSEy+NeDJOVn9on+m1/RBqPWdejjHFsJWsfwVW/4K4Pz7Jgag4V1AxIF SU18LU8LqZWyHeOwyjpSf0yO45xwE0+K33nW9Vj6HIQo27DPQCdsZJOWgh94tAoC /r+fih2dlLqXwbHBPIl0mIde4LhFTS5bmZzAYjw/chcZOuh8BHeGPqTma8shHqFC LjTOiHBqRpYYkefDch8a/3l7IXMpXA0P9yBoxH6sFUaU7w== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48w8wybbg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 04 Sep 2025 12:29:40 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b4f87c691a7so1379852a12.3 for ; Thu, 04 Sep 2025 05:29:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756988979; x=1757593779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pc3ppLOamamgYKL4ljuA5P2D+67aLZBUnwJLBZffFZM=; b=DByhUqDNIhueqPR98P3zVfNgJE+xCmtbRr84zzFQC6Zwl7rkwtpoZqd3m6loPlG2HW tQ5ACC/rw4iksGa8eQF0dbMm/TQWOwZ061MMrkWTnXXz7MDDB2lU8xR/SEI0/uKeiJf9 uuc/bunPm8xjSRPxMC7IF7lATSPCmoqKzoJ/vpMKuv0K8f3PYNKGA/UMpQl9stlPYGfI Qss5Ol6xplrl/zqnfpCkTPVqYvPbgpxvuR7zW2rI+/G/p2BBH9HDPWMcx5qb1DOu3xth Pm4q/suq+0+t6EMUv89p40uEUHg7slsnDSp6564qdhvgr8ZUl41/s0PngNBmETPIJNBv ni7Q== X-Forwarded-Encrypted: i=1; AJvYcCXAXHuEg0k/Jw5tvtWefH9H/B+deumt9QezfYuz85QdEsJb4C3m9R9X31jzGesgufWj42t5VgtbsqMqL90=@vger.kernel.org X-Gm-Message-State: AOJu0YzTezllmoLUiuds8uYrtpZYB+5HbzP7f8qPhNsyWM67dka/ruRq sCaaTTGyHW27L04tSgpYyWgJeiJnJD/CfGPuz4lKWEJGMso6RidEQx1jh7QGyjBitQKt+NJpFMa mMrekmGLTzqmifMkhWS4XoPYREXYLPlZA219pxoG3m+pDS5ha+1tnIfgLUAkPHqAs7Gg= X-Gm-Gg: ASbGncstUXgjxNTG3NZKFqg8d6hBENLs1EOYES6p1XsE/oJcUiU/Tl3t5bDZ9rTQJoO syR+L9fYknOQCPhl2qp7Vp+nERzwmq/XNtTRQ7YlgPZsMVloq3eqqP7Rtpnr4DYVpPqYJ2voOtO 23pZQz9wUHv5g45jWiiOnXXPfXVK/EB0zFBxedpb2QXOZf55BycZXWsexoJMjki8FJAzUjbu0os HPgGqadWfsMEIcvm2rWuMVCU+cNaZxpHjcuaRd31vZQZliux7ygpIJaBP3DsyLe7QMFTZLdm6GQ mMz2CcVMZMaTF97i9QI9BE8NhHJRnBEKJDBfKL4oIrvu9ExodRim9HdEa8vfPb5acW4JFn6Zsg= = X-Received: by 2002:a05:6a20:258a:b0:24c:2fa1:fdd8 with SMTP id adf61e73a8af0-24c2fa201efmr2769903637.49.1756988979383; Thu, 04 Sep 2025 05:29:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvPRvaReH6KDh8zVbVK8stgt0sMEICu2GPCxmS2taegtk3ckMVcnxPr1WUtE53eEOt0f3oFw== X-Received: by 2002:a05:6a20:258a:b0:24c:2fa1:fdd8 with SMTP id adf61e73a8af0-24c2fa201efmr2769852637.49.1756988978833; Thu, 04 Sep 2025 05:29:38 -0700 (PDT) Received: from hu-pkondeti-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7727bce1b58sm5747866b3a.9.2025.09.04.05.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Sep 2025 05:29:38 -0700 (PDT) Date: Thu, 4 Sep 2025 17:59:32 +0530 From: Pavan Kondeti To: Krzysztof Kozlowski Cc: Pavan Kondeti , hrishabh.rajput@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: Add binding for gunyah watchdog Message-ID: <4316b164-0d2e-48fa-bb0d-977c0b223c7a@quicinc.com> References: <20250903-gunyah_watchdog-v1-0-3ae690530e4b@oss.qualcomm.com> <20250903-gunyah_watchdog-v1-1-3ae690530e4b@oss.qualcomm.com> <5210a5e2-0d75-4532-b3ca-1cbdf8ea2a9e@quicinc.com> <16c0d8f4-4a6d-4d65-90ce-34c86ebecfa1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16c0d8f4-4a6d-4d65-90ce-34c86ebecfa1@kernel.org> X-Authority-Analysis: v=2.4 cv=Ycq95xRf c=1 sm=1 tr=0 ts=68b98634 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=yJojWOMRYYMA:10 a=E1Ov9k63nBnqAXplbvIA:9 a=CjuIK1q_8ugA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: fH74val2sVDz7jZrAMLYF6csjPDO17KC X-Proofpoint-ORIG-GUID: fH74val2sVDz7jZrAMLYF6csjPDO17KC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAxMDEwMSBTYWx0ZWRfX5+3eRIejSYLU NnNMAsHaoZSsWnpSxXFXjdQWLjWA94C649ef8dmoG6ZPg3Cbw0MaCXvFYwFb0cIYBCOZTn2paSb vS0tWL9I/p8I2xByjr4RPTBkGU3bpLMyLcTucK6t+iPSx808oK4eFZffrf7u3H8HVIGfVk8gsT6 XeNy54dNdYWGG83CwSDCXHeehREaGbyTdu0mHVdDeuMUvsPHwfQgZtcI8P+UTnH+R4l3EooJzq9 7pszZreiIxrHqULzVNUm5F00X/H3PNE+WiN/1aQfMXad4eAcnSThuk/VQH1tK50ehTGaugDvVYB Cau9QaNpobOhR4OwUYLJEHrks+ENkqDQx5wQ4JRwBDTW0Zizyx4Dro1fivi4ul4vKargOoaGGUu Dw/7Q9AY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-04_04,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509010101 On Thu, Sep 04, 2025 at 12:59:14PM +0200, Krzysztof Kozlowski wrote: > On 04/09/2025 12:49, Krzysztof Kozlowski wrote: > > On 04/09/2025 12:16, Pavan Kondeti wrote: > >>>> + compatible: > >>>> + allOf: > >>>> + - const: gunyah-hypervisor > >>>> + - const: simple-bus > >>> > >>> What? No. > >>> > >>> Don't create patches with AI. > >>> > >> I am next to Hrishabh when he is writing this patch. I can confirm he > >> did not use AI :-) not sure what tool Krzysztof is using to catch > > > > My brain? > > > >> patches being written with AI, that tool needs some improvement for > >> sure. > > > > Heh? Seriously, instead replying something like this think from how is > > it possible to come with such syntax? > > > > It does not exist. NOWHERE. > > > > It had to be completely hallucinated by AI because I cannot imagine > > coming with code which is completely different then EVERYTHING else. > > There is no single code looking like that. > > > > > >> > >> I will let Hrishabh share why he put simple-bus here. > > > > > > It is not about simple-bus! > > Ok, I see what we messed up there around compatible property when adding simple-bus. Sorry about this. > > And to clarify: it's not only about this part of the binding. Entire > binding is terrible, does not meet any basic standards, does not follow > basic principles of writing DTS. I cannot imagine this code passing > internal review, so hallucinated AI is the most reasonable explanation. > Sorry, if you send extremely poor code using patterns which do not > exist, that;s either huge waste of community time or AI-based waste of > community time. > Point taken. The intention is absolutely not to waste the time of reviewers or maintainers. We will make sure to apply the lesson learned here. Thanks again for your time. Thanks, Pavan