From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3FE2366558 for ; Tue, 3 Feb 2026 05:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770096169; cv=none; b=hJ2Tqnsf1H6NhbZJlMJnHbsZgX/5kzSkKBRE/0IVE87mIrsnB/aPb9Qw6h1CJDPl3t1FyjfknMbLNtxcXTvWlveqn6ki6i2rWYhtgSNAtB6azMSAomZFPSn0uBiI92Ir5J3KvHP6NuUwuY2BhDKEY2oN7cfJTQDoePxt+KDUTVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770096169; c=relaxed/simple; bh=7bp9e7/yYGqY+R+eEMrtPIC3mQknB9sD9uJ0aTgbrOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aH1eh+bP2XmU526sD9KLWSj9MehycHO2iPwHuygnpOsXQM2IV3HzECSlpUuuQJ8oJ4UVN4c4l3VB1e3hHUy6Ile8CKUyEpBEwbqPm+PysSAQ7RrKJdlQwNivyFXM6zPPplBj+IblOwRva10fy3HsdzgCrb57I32JNas0pZ4X6OY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=BlL2R6Ea; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mzs6H+lF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=BlL2R6Ea; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mzs6H+lF; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="BlL2R6Ea"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mzs6H+lF"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="BlL2R6Ea"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mzs6H+lF" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BE2CF5BCDB; Tue, 3 Feb 2026 05:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770096165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rh0xU695TVYBorZV9UppFbW847oFW59eekzt+WpK9WM=; b=BlL2R6Ea3iSC/PE9qp6O+6HWbZdgcIR3nBLpnkRbbytKae+wSZX9Cl8dEAkd6iYEh9xHht 8doTEWmReLLUsRZqbpAwSCU8wgFzPC+/whq5pc8d1IErRGfZdiuhnsmihl8OhNl/+3s3nQ zNti7PSQB0WGh5xTQWqFOlO1GQ6W0+A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770096165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rh0xU695TVYBorZV9UppFbW847oFW59eekzt+WpK9WM=; b=mzs6H+lFJGHgYT1O8MdXnFDBC9b+OmV1t3CXCNswkDIJpofYwNyV6st1WvS7AhfwtbJuHS ko/Ix1nsUO4GlrCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BlL2R6Ea; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mzs6H+lF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770096165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rh0xU695TVYBorZV9UppFbW847oFW59eekzt+WpK9WM=; b=BlL2R6Ea3iSC/PE9qp6O+6HWbZdgcIR3nBLpnkRbbytKae+wSZX9Cl8dEAkd6iYEh9xHht 8doTEWmReLLUsRZqbpAwSCU8wgFzPC+/whq5pc8d1IErRGfZdiuhnsmihl8OhNl/+3s3nQ zNti7PSQB0WGh5xTQWqFOlO1GQ6W0+A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770096165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rh0xU695TVYBorZV9UppFbW847oFW59eekzt+WpK9WM=; b=mzs6H+lFJGHgYT1O8MdXnFDBC9b+OmV1t3CXCNswkDIJpofYwNyV6st1WvS7AhfwtbJuHS ko/Ix1nsUO4GlrCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 032713EA62; Tue, 3 Feb 2026 05:22:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VO8fIiCGgWnNNAAAD6G6ig (envelope-from ); Tue, 03 Feb 2026 05:22:40 +0000 Message-ID: <431d225b-266f-431c-b3a5-03e033a2f63d@suse.de> Date: Tue, 3 Feb 2026 06:22:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/14] nvme: Implement cross-controller reset completion To: Mohamed Khalfella , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260130223531.2478849-1-mkhalfella@purestorage.com> <20260130223531.2478849-10-mkhalfella@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260130223531.2478849-10-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,purestorage.com:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[purestorage.com,broadcom.com,gmail.com,nvidia.com,lst.de,kernel.dk,kernel.org,grimberg.me]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[] X-Spam-Flag: NO X-Spam-Score: -4.51 X-Rspamd-Queue-Id: BE2CF5BCDB X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: On 1/30/26 23:34, Mohamed Khalfella wrote: > An nvme source controller that issues CCR command expects to receive an > NVME_AER_NOTICE_CCR_COMPLETED when pending CCR succeeds or fails. Add > sctrl->ccr_work to read NVME_LOG_CCR logpage and wakeup any thread > waiting on CCR completion. > > Signed-off-by: Mohamed Khalfella > --- > drivers/nvme/host/core.c | 49 +++++++++++++++++++++++++++++++++++++++- > drivers/nvme/host/nvme.h | 1 + > 2 files changed, 49 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 13e0775d56b4..0f90feb46369 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1901,7 +1901,8 @@ EXPORT_SYMBOL_GPL(nvme_set_queue_count); > > #define NVME_AEN_SUPPORTED \ > (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT | \ > - NVME_AEN_CFG_ANA_CHANGE | NVME_AEN_CFG_DISC_CHANGE) > + NVME_AEN_CFG_ANA_CHANGE | NVME_AEN_CFG_CCR_COMPLETE | \ > + NVME_AEN_CFG_DISC_CHANGE) > > static void nvme_enable_aen(struct nvme_ctrl *ctrl) > { > @@ -4866,6 +4867,47 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl *ctrl) > kfree(log); > } > > +static void nvme_ccr_work(struct work_struct *work) > +{ > + struct nvme_ctrl *ctrl = container_of(work, struct nvme_ctrl, ccr_work); > + struct nvme_ccr_entry *ccr; > + struct nvme_ccr_log_entry *entry; > + struct nvme_ccr_log *log; > + unsigned long flags; > + int ret, i; > + > + log = kmalloc(sizeof(*log), GFP_KERNEL); > + if (!log) > + return; > + > + ret = nvme_get_log(ctrl, 0, NVME_LOG_CCR, 0x01, > + 0x00, log, sizeof(*log), 0); > + if (ret) > + goto out; > + > + spin_lock_irqsave(&ctrl->lock, flags); > + for (i = 0; i < le16_to_cpu(log->ne); i++) { > + entry = &log->entries[i]; > + if (entry->ccrs == NVME_CCR_STATUS_IN_PROGRESS) > + continue; > + > + list_for_each_entry(ccr, &ctrl->ccr_list, list) { > + struct nvme_ctrl *ictrl = ccr->ictrl; > + > + if (ictrl->cntlid != le16_to_cpu(entry->icid) || > + ictrl->ciu != entry->ciu) > + continue; > + > + /* Complete matching entry */ > + ccr->ccrs = entry->ccrs; > + complete(&ccr->complete); > + } > + } > + spin_unlock_irqrestore(&ctrl->lock, flags); > +out: > + kfree(log); > +} > + > static void nvme_fw_act_work(struct work_struct *work) > { > struct nvme_ctrl *ctrl = container_of(work, > @@ -4942,6 +4984,9 @@ static bool nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result) > case NVME_AER_NOTICE_DISC_CHANGED: > ctrl->aen_result = result; > break; > + case NVME_AER_NOTICE_CCR_COMPLETED: > + queue_work(nvme_wq, &ctrl->ccr_work); > + break; > default: > dev_warn(ctrl->device, "async event result %08x\n", result); > } > @@ -5131,6 +5176,7 @@ void nvme_stop_ctrl(struct nvme_ctrl *ctrl) > nvme_stop_failfast_work(ctrl); > flush_work(&ctrl->async_event_work); > cancel_work_sync(&ctrl->fw_act_work); > + cancel_work_sync(&ctrl->ccr_work); > if (ctrl->ops->stop_ctrl) > ctrl->ops->stop_ctrl(ctrl); > } > @@ -5254,6 +5300,7 @@ int nvme_init_ctrl(struct nvme_ctrl *ctrl, struct device *dev, > ctrl->quirks = quirks; > ctrl->numa_node = NUMA_NO_NODE; > INIT_WORK(&ctrl->scan_work, nvme_scan_work); > + INIT_WORK(&ctrl->ccr_work, nvme_ccr_work); > INIT_WORK(&ctrl->async_event_work, nvme_async_event_work); > INIT_WORK(&ctrl->fw_act_work, nvme_fw_act_work); > INIT_WORK(&ctrl->delete_work, nvme_delete_ctrl_work); > diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h > index fa18f580d76a..a7f382e35821 100644 > --- a/drivers/nvme/host/nvme.h > +++ b/drivers/nvme/host/nvme.h > @@ -366,6 +366,7 @@ struct nvme_ctrl { > struct nvme_effects_log *effects; > struct xarray cels; > struct work_struct scan_work; > + struct work_struct ccr_work; > struct work_struct async_event_work; > struct delayed_work ka_work; > struct delayed_work failfast_work; This confuses me. Why do we call 'complete()' but do not have a corresponding 'wait_for_completion()' call? Please merge with the next patch to allow reviewers to have the full picture. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich