From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38DBC49361 for ; Sat, 19 Jun 2021 06:42:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FCC461285 for ; Sat, 19 Jun 2021 06:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233963AbhFSGoW (ORCPT ); Sat, 19 Jun 2021 02:44:22 -0400 Received: from ivanoab7.miniserver.com ([37.128.132.42]:51536 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232835AbhFSGoV (ORCPT ); Sat, 19 Jun 2021 02:44:21 -0400 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luUg5-00029l-IH; Sat, 19 Jun 2021 06:42:01 +0000 Received: from madding.kot-begemot.co.uk ([192.168.3.98]) by jain.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1luUg3-00029v-BT; Sat, 19 Jun 2021 07:42:01 +0100 Subject: Re: [PATCH] um: remove unneeded semicolon in um_arch.c To: Wan Jiabing , Jeff Dike , Richard Weinberger , Johannes Berg , Andrew Morton , Nick Desaulniers , Corey Minyard , Thomas Meyer , Andy Shevchenko , Joe Perches , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210619020301.77672-1-wanjiabing@vivo.com> From: Anton Ivanov Organization: Cambridge Greys Message-ID: <4320e0ea-1339-e2c1-03c0-271dbcd6e22d@cambridgegreys.com> Date: Sat, 19 Jun 2021 07:41:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210619020301.77672-1-wanjiabing@vivo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Clacks-Overhead: GNU Terry Pratchett Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/06/2021 03:02, Wan Jiabing wrote: > Fix following coccicheck warning: > ./arch/um/kernel/um_arch.c:284:34-35: Unneeded semicolon > > Signed-off-by: Wan Jiabing > --- > arch/um/kernel/um_arch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c > index f9f1463f0521..a149a5e9a16a 100644 > --- a/arch/um/kernel/um_arch.c > +++ b/arch/um/kernel/um_arch.c > @@ -281,7 +281,7 @@ static void parse_host_cpu_flags(char *line) > int i; > for (i = 0; i < 32*NCAPINTS; i++) { > if ((x86_cap_flags[i] != NULL) && strstr(line, x86_cap_flags[i])) > - set_cpu_cap(&boot_cpu_data, i);; > + set_cpu_cap(&boot_cpu_data, i); > } > } > static void parse_cache_line(char *line) > Thanks. I do not think the patch which introduces this ([v7,1/3] um: Add support for host CPU flags and alignment) has been merged yet. I do not see it in the tree as of this morning. I can see that it is already marked as done in patchwork so it is on its way. Richard, what do you want me to do - reissue a fixed one or we should accept the fix once the original is merged? -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/