From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbdIOQC1 (ORCPT ); Fri, 15 Sep 2017 12:02:27 -0400 Received: from mout.web.de ([212.227.15.14]:49244 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbdIOQCY (ORCPT ); Fri, 15 Sep 2017 12:02:24 -0400 Subject: [PATCH 2/2] [media] c8sectpfe: Improve two size determinations in c8sectpfe_frontend_attach() From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Patrice Chotard , Peter Griffin , Mauro Carvalho Chehab Cc: LKML , kernel-janitors@vger.kernel.org References: <3e5fcfbe-828a-8c15-12d4-c74e8a1f20f1@users.sourceforge.net> Message-ID: <432261cc-ecf1-0673-b8e2-9ca317ceb772@users.sourceforge.net> Date: Fri, 15 Sep 2017 18:02:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <3e5fcfbe-828a-8c15-12d4-c74e8a1f20f1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:fUl4BlzvilsLPLzKhBUdTU/cYEem/r7B1UXCOPxFVLFI7JxBpH5 WAebFUQVR6cTKWAeW1811r0K9mm03xqe8dRrsBDpU8iARn9EWpKjF6MRpLiyj0lGihIC1aP bXYsr4yBsINv585Dw8LBQjbRuVf6QhMDp8jfcfNHACKA9K3P/7ObDKwt+iuHZgcQ9weU8xg t5q/rbLdEeYPAOPvc1YRA== X-UI-Out-Filterresults: notjunk:1;V01:K0:JjGVdmOrWow=:N+P3sr4/d2z8NIGXuAQkjl y4JLVxMmsR0MXmE+WfSE+KTgrpjxX/LIM+Yos478A6lGPTV/MpF5bUHZ+hkuIy+EMVzZ9AwHT GlznGz3m/gOb/Asq2TFXGnThD9jYC5lYwC09Bp6yY1cLDgJKGZChXZfmnFzhtl3cqBFdGTBoe epEfPFmK1lZPw5NlOuzcXhLisaFnVdhT+IToIGgR9/fh0WhmtNp6F/Cdl+bFJB1OFcQiE4CFz xWInfATMYKaozgnL8qOBqqSaJEtpcaCVCSzF0b1W8ZuL3G1Jq1hPHXH8mG9koU5qD3Y7hbOX4 3EPp5F3ktPzZwH/90A+K+oOzPx1KxdgvGBGpenwfftDbu8IP24JvK7I2lpXQodAplzstBYRIY CWc7gS0ZJkGazIM/jm/8ypk+cuit8Hj/cT4o9ixOgu50TRYGm0f/Hzb4CxStFzCUPnIMNgkh9 4moRSDjYKabGth4ZALT+CfK/fgJJuSnrCjWXG1KoWwGCvbexdLuuo+e81p9gcm4GfgzfyIrLb gKsIjGZUvoTdPXCgbp9ieKO0vvEULQo/JvW9oRrYsyxDewzp+/gRchKJGMepmcsBQCuWfhcyV Lg7TZ6PtlgAOB6pgO5iJSRKGr204CGrLsE2HiHy+0Eh7LJD7VKLYDuePhfgviJRxPsAVsXLU9 a5IcY8gYAYkhmYZnNHJcqsmYSPvuGNjv5AFSHleqBBvQ+dOBMVt1qbnZrL7KYw/a/HK8kszPk McxO+1vHM/NwLZtpp6oF1TNS2MbKD9bIXhAHdLpvH9R55XeqlZlJTRVwIwnbaDsjTM/5ALuhV Xjzp7WoF3bpBzmmW2vwom6FcKwRdK9+wfNZPTU2PKa+cBZxlWY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 15 Sep 2017 17:30:38 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c index 1b23b188cd65..c3b09a9e30ec 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c @@ -164,12 +164,10 @@ int c8sectpfe_frontend_attach(struct dvb_frontend **fe, tda18212 = devm_kzalloc(c8sectpfe->device, - sizeof(struct tda18212_config), + sizeof(*tda18212), GFP_KERNEL); if (!tda18212) return -ENOMEM; - memcpy(tda18212, &tda18212_conf, - sizeof(struct tda18212_config)); - + memcpy(tda18212, &tda18212_conf, sizeof(*tda18212)); tda18212->fe = (*fe); tda18212_info.platform_data = tda18212; -- 2.14.1