From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC841C433F5 for ; Tue, 1 Feb 2022 13:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238331AbiBANGM (ORCPT ); Tue, 1 Feb 2022 08:06:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43122 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237005AbiBANGL (ORCPT ); Tue, 1 Feb 2022 08:06:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643720771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/JQQOEd58RWuQGlfFpmDXOvRRGfDXT71ddV8rPIIJl0=; b=UCi1fnIUNsEZ5DcUNRo6455Qu5KuTCo8jzMfSR4JnxGIbMaG7Y0oVL4AUK1NA2bJmVHmMC l82t2LD5wYpmzZDQ0+A164XQXb2Vu90U8IrV7HEvniwpVuEIpmLutsPYRMLSt8GQVo08za 5ZwpE0Xxn6ganJSOIf1WzYVjPRH7kXs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-590-MJ8r4tbhNiOsjx5ofOURcw-1; Tue, 01 Feb 2022 08:06:10 -0500 X-MC-Unique: MJ8r4tbhNiOsjx5ofOURcw-1 Received: by mail-wm1-f71.google.com with SMTP id q71-20020a1ca74a000000b003507f38e330so1560523wme.9 for ; Tue, 01 Feb 2022 05:06:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/JQQOEd58RWuQGlfFpmDXOvRRGfDXT71ddV8rPIIJl0=; b=kqEwWqQHmATEaGwiN+2y+6aJbwhV/7W/+t17yBwlpI2r3rfESFKD4UMR4o+ZexKQwE IDo5a5DcqpKozvzPqavjVgC0YRYNPprTlk16NTzZRYH40cR0x9j0CizoetPh5FEJULAJ CFmXhI9le3MVzUXM6ASanRRqB2aOtWIS3YbbkI55yAkoW/S0TlCFhR2nGenv7hXmkz9l F8WnBFlMRTS5bFEuSb3E0miXyPlVlRRi0NH9L94qK7PUX0Dg9dp+TQkzZCcGU4ePQVa/ LbBgt2R6xyQQ7j+m/ikGfi+o8bK+BCU03ZSMm+VtV8Tmlr7LmSCBxGVGcNV6QKL3PQ7h 8vpw== X-Gm-Message-State: AOAM531Ycv4spb8ZRyQib8fVGTVO+OT8P6jNsbLMFTb+UooKBVZgnSrf LsDVj5BqHm+VSYkNX0L/PwmzdsNvBwpxTa9X6sw4CllS8twhZmV4feaYhcEKW6K/W+OixT7Lanr ZLxoClx8F2kv/1qQ04OMtPjIX X-Received: by 2002:a1c:3586:: with SMTP id c128mr1752537wma.15.1643720769213; Tue, 01 Feb 2022 05:06:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzYHBjANBhvf+E+2paUEQ5NN7skEmnIc89W4J4poW5Ib7Aw4MHr3Wo/i0Jc5irQYQHxGDNJ+g== X-Received: by 2002:a1c:3586:: with SMTP id c128mr1752519wma.15.1643720769023; Tue, 01 Feb 2022 05:06:09 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id l4sm15793539wrs.6.2022.02.01.05.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 05:06:08 -0800 (PST) Message-ID: <4322f58b-dbeb-b90f-2770-d6881f8005b4@redhat.com> Date: Tue, 1 Feb 2022 14:06:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/4] drm: Add I2C connector type Content-Language: en-US To: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Sam Ravnborg Cc: linux-fbdev@vger.kernel.org, David Airlie , Daniel Vetter , Emil Velikov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Geert Uytterhoeven , Maxime Ripard , Thomas Zimmermann , Andy Shevchenko References: <20220131201225.2324984-1-javierm@redhat.com> <20220131201225.2324984-2-javierm@redhat.com> <4d9a56a7-da25-b411-61cc-372c6fa9011d@tronnes.org> From: Javier Martinez Canillas In-Reply-To: <4d9a56a7-da25-b411-61cc-372c6fa9011d@tronnes.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Noralf, On 2/1/22 13:58, Noralf Trønnes wrote: > > > Den 31.01.2022 21.52, skrev Sam Ravnborg: >> On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >>> There isn't a connector type for display controllers accesed through I2C, >>> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL. >>> >>> Add an I2C connector type to match the actual connector. >>> >>> As Noralf Trønnes mentions in commit fc06bf1d76d6 ("drm: Add SPI connector >>> type"), user-space should be able to cope with a connector type that does >>> not yet understand. >>> > > It turned out that I wasn't entirely correct here, mpv didn't cope with > unknown types. In the PR to add support Emil Velikov wondered if libdrm > should handle these connector names: > https://github.com/mpv-player/mpv/pull/8989#issuecomment-879187711 > I see, thanks for the information. What should we do then, just use the type DRM_MODE_CONNECTOR_Unknown then ? Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat