From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F66B403AE4 for ; Mon, 29 Jun 2026 12:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737260; cv=none; b=LAWiE9vhh35Tc9r1E7PXqj7iDa7uAajvk8ziUiZxxA1MWCIC+hoWk+kE80d5bGWR7ailSrynZxd0lW81Dvn7or3+9tKLAhkXTTWJGPLsxGsl+2/kHfPsLLUskoGV6IjJc76CxINtZiby/H01QE/JUouz+VTtE+wwfLDUsy6eJlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737260; c=relaxed/simple; bh=uOU7ruRgctPgg/Wix4v7+9GmqLcV0osZIBR40g8/VFw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hT0AnHklK4DjNx6MiTZkix4wghSmsLsj2gygBijlFSzFbtcJkpqHoISWJd5mFw92NMoP1Ot/xl/j5MsHHgTbHWriuB9to7ElHOUdy/dbVOKxG/k2rD8AJ6MbV9CaAmCWeNx3JNnZMzGTqEz1TePxUvrF20QIbYN9jlxfRIfgjFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q+MEznC2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F6WGxBMP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q+MEznC2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F6WGxBMP" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TATE6i2579144 for ; Mon, 29 Jun 2026 12:47:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wQL0usVdCCvSUM4dAKsCdGlSjRRi4QeM00uIctedMDM=; b=Q+MEznC2afK/uQ1D Zaoeg6E/nQBpLdYqzu7G9xFCG5/jZ0f0L3UJ7q5jM57nvZZ7K7pANwo1pwwFc717 c+EzFOXzo2cKG+xk5idbgoZ/f4EyKJ7F45NTiar5gvl9hyIWLUxkDNYUKvdMxDQp hrTX7FfdtHDRahWbpecCcqnmDKHSu7rEAN/QtFBIpfHhEQbkAUOtHn62O35ptzou aQhop/Ph3jFPWVSYYEP327OX+Nk+xgKOVkp5xqGZ4kTvlopWCjXcF7hm1aLRDw4l Tjtn92S2yztOGi3LHy4QCZNLd8QMxtFTzFB7ukFEW9eCy2ExTDv7xUVE54Yj+UOU ySymmQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3kp7hcp2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 12:47:38 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bfd1772d8so1873991cf.1 for ; Mon, 29 Jun 2026 05:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782737258; x=1783342058; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wQL0usVdCCvSUM4dAKsCdGlSjRRi4QeM00uIctedMDM=; b=F6WGxBMPAdKmQoHy/YJNvkjGHA5hn+O2sUSISBTMwMPoSBIa8tMcRygh73SRcPVLdN 2Nm8ijP7/cGoYRBNkYPsR5RBu9ykAtG4NjoWpxPreV617/rfJHXUp9ct4ZrI2oON6Ap3 YzR2h6GyjdcGDEbF8JMBXLkUJo5ViPoCjVaOXXI8flItc7SPsBfGShrjdx3Le88w4JaD IU9W9BsX7r5wdfueO87G8evrrMR9cnpSDmB6feFYbP0QJIaD5p4ORFDGsNXS7hzYhfNZ 1Nm4aBrXNtWmoiDamI52LGDw1DpxoUGFf9KlH94N7/vd2NOHxq/+6awb2nt5ivvUVnJc OPWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782737258; x=1783342058; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wQL0usVdCCvSUM4dAKsCdGlSjRRi4QeM00uIctedMDM=; b=cXMjfkNxtxH7CZp5bQK6fmwZg8Q6A2aCzoDIEm0u3GZneSn0/braij/fLzoVkptC0D jifMWUrTNAx8GwM03AYsYvVgCrZUAIrkmiLn6gybEzEKxu8Z6L17fhkUHveOymM3m200 Z6OwZ6VppRpqNHnyhiuVOBcYhw81dGX8IkFtzst8ER1GwRCKeA4oFA7f56d+7m/E9Hnd Ra/ehgOKBqrhvEPXYES0jegX7LvbFLTAWXP3687P1Jp5Ip3xIUAyQacBS3PK02sstupk 7yTr+AOpKscNaCbdapCv00U/cUbXcTFOoXiIiDhTTeKOHvC6YMGkQ/Va+YCWl5xZgNLz wqKQ== X-Forwarded-Encrypted: i=1; AFNElJ/3sU1p+zVxEb5d0iemgwGdXKBHbxvgFtM+kSPLXj6QPurZHsbTzkPJgCXhXjeiATTAUSY7BG0tqda6hKc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+gzBJ3bOXQ5Gme+2F7Kc/DDPsWZ8zVpRCRAgFFA3o7J4bQk3B 6qu4wiyARGiv91cpS2Pv98V5TU34Dt9JLkyg6gfTR/Fm2xUG57HHpEdbEChWj+Sbgv41+GEu+gb vw1IrpnkQFeKBMhZ+sXy/28hvE+LVI9Ygsw7GgkjVQWNRciIr+IHbzFPNRPaofgK/+EU= X-Gm-Gg: AfdE7cnUEfbuK3w2jN9vtpjB6V/xiRsNdguHeoRLtqSamIzBDtTQ3ILEVioUUCRyAyT sgiNkzgnms7lp+qxOU31ikAIuo1bmgGItCz6NZ1bvFbTYHeo1nuLg46pnpWFjCLsGBPakuHTjnl 44tMAmHq1FV6jqQEJdTrvMuBe881BY1KnbJTWxuMwZlqotNIud4zmKNTApRwrRnHc0By0rvZ3rq RM2pAZtygsjQWVQYA15ZW92SHUOkm6MdRMcXfH1HRV2odscRezl1XduclZC1QBYQibsVIL9Cpyu t7B9sTAVRQ6qr23jLLAgtAIHoNKbjlDfMOTc+Gm9FbihTtnFdJ7+W8+Z+ZfpKnaNAca58wIMA1H NvhJrqVOlZAYiNdP/xqlx3om8vT1KUmORPxA= X-Received: by 2002:a05:622a:1aa0:b0:51a:d45e:638d with SMTP id d75a77b69052e-51ad45e6f69mr78096721cf.8.1782737257598; Mon, 29 Jun 2026 05:47:37 -0700 (PDT) X-Received: by 2002:a05:622a:1aa0:b0:51a:d45e:638d with SMTP id d75a77b69052e-51ad45e6f69mr78096241cf.8.1782737256970; Mon, 29 Jun 2026 05:47:36 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3999afcb314sm71531191fa.15.2026.06.29.05.47.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 05:47:35 -0700 (PDT) Message-ID: <43293037-99bd-457a-b190-31fb24625b1c@oss.qualcomm.com> Date: Mon, 29 Jun 2026 14:47:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rpmsg: glink: Split protocol start out of native_probe To: Chunkai Deng , Bjorn Andersson , Mathieu Poirier Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, chris.lew@oss.qualcomm.com, tony.truong@oss.qualcomm.com References: <20260618-rpmsg-glink-split-protocol-start-v1-1-c4f93986cdb4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260618-rpmsg-glink-split-protocol-start-v1-1-c4f93986cdb4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDEwNSBTYWx0ZWRfX7sfbHnyDqEfB 37ZniXKmhlJwjMB9Jqrd+Qfw2v9G7p4aW+4gm6y7eAlCfpi3PTv05O6oz9Bek/Vf+dSxDpmEU1s Zphv/8b8me+UYTc73wnzGqYI/TURRss= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDEwNSBTYWx0ZWRfX39NH7wNRqDJB VsWt4XmURbtry3N24j2POp9osUnG9bFkrlzl3yef0xUjKUEhCBDNVUpVaLUijSMrIjNv9wbTIIx fd3aRBIFJCOfsNuCQGYqInzr/Qjk/IfhC4Y7XhLOIb+YU5Cd1wIbvOVNSYV9ZvY8W8GXsii6z1c gO8CyfTMz21umReAuzilHxWVunhsHruJEa04RLIZsNRT3ljTU5E50zL/GT1Hgmza83CFBgJUKES 6lra2xzsMMsmq8RzOr0cZu9u8ELd79JR7PXGhoMCzSMtVO1GZbZLK/QQDusxKLv8YAxXA2VBY0Y 6zSroZ4eGMPtEx9e0R009hQ7nRaIPnbv07cCm+37ERhwdUN0XZbIUaBFNyKHW4nmDoNhPJf9idE E+OlYjcMnpKHskQnvghxmIn205Po71dRVNBK+SpjzS3/cVqrVs+2kki4ox1wNKBbRdA98UOmYRF 3YFR5fXFvNd03i5mODQ== X-Proofpoint-ORIG-GUID: wkxTfgqz7NQvRLaCsmP7swTPlLhattxs X-Authority-Analysis: v=2.4 cv=MZJcfZ/f c=1 sm=1 tr=0 ts=6a42696a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=AXr40cIQNxmEwLS31UYA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: wkxTfgqz7NQvRLaCsmP7swTPlLhattxs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290105 On 6/19/26 7:01 AM, Chunkai Deng wrote: > The SMEM and RPM transports request their receive interrupt with > IRQF_NO_AUTOEN and enable it only after qcom_glink_native_probe() > returns. Since native_probe() sends the initial version command, the > remote may ACK before the local IRQ is enabled, stalling the version > handshake on a fast remote. > > Split the protocol start (qcom_glink_send_version() and > qcom_glink_create_chrdev()) into a new qcom_glink_native_start(). > Transports now enable their IRQ first, then call native_start(), so the > version ACK is guaranteed to be serviced. > > Signed-off-by: Chunkai Deng > --- Would it not be simpler to just move the devm_request_irq a bit down and remove the NO_AUTOEN flag then? Konrad