From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B601E9B37 for ; Mon, 15 Jun 2026 04:46:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781498764; cv=none; b=Gzods4IMWiJhIAAE2AZRibh4G4H47+h9HGVEACXm1U5LUCiRKX9V9ElRaRus8S94yZpCzIrYU9xkwsJwb4JLl4WBKAIPJuId0MqWQYJ/W7Q8fsLS2+xTCtUuazKElvJw+wL7Px/UzNKnMWPP0Ih8zPT6EvhzQQRSH2ZG7vQ0Fks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781498764; c=relaxed/simple; bh=JWiHeFDYut/lNpRe4jVppjxnuTFiIBDbHPlaQpSFS7w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IcHZrWRdsnG22jlvTHyeTJVyIqiQ+X+a9c9+wwTpQREp5MuxIwXIiXczfjMj8ylmlXovSY/O+RHNbRf8ZAStkNRzAC/njvxLh5bNPtbd/CYJYROERED5Xsxe4r9mdpJ/MmjiC1xcNjvATRtDGEdsV3JsffsV5QZ9ATe1vv4/cmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KxDVXswa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cvD2lWAu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KxDVXswa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cvD2lWAu" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65F1jJAC3089664 for ; Mon, 15 Jun 2026 04:46:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7B1Rri1bOKV6WrRa0Ahdi5sYNCs1jyUm85PYhWylAME=; b=KxDVXswaXB+WGYJ/ yiCJeN8HBMKIM6XpNpdP1qgzzBLp8yOi9HbsZXvR3uC2KnsktXDA9nlkPxkeOFaV TxbVfu2CZy8fRFlB50H21qmpnNqk1rdnwgdOWjUSsriXPzYxRS2wTFmsNlXirKvb IT3MHDlPiQ8CiCYdOm8KCSWHqVisWwA6ckRkwmvevgI4mnu1s6Is6pxpNtp4Aqx8 2R2jlB94cKfWM60/jNlK3WSs70Y8bWc2SPDDrGWl/NUpOQLu/Rf1/8687xPwDQfr q7u5+inO2ezS6T0HiH/RyGyd7NEF/jL/iQsGvZE2BUaMwCppAdATXVfYkq8x1i9f eJ6HbA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eryk6dent-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 04:46:01 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36b982ec27aso2106793a91.1 for ; Sun, 14 Jun 2026 21:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781498761; x=1782103561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7B1Rri1bOKV6WrRa0Ahdi5sYNCs1jyUm85PYhWylAME=; b=cvD2lWAu746iWZB2hVJoPwMF60UIOOT8QFpWOX3lJjLEAe0RGuqhVr9q3bpuZncBLH XgUxtDe9aR6ebe/N1WxXVL5t+s1TBrabE5aDycVG8SL/zhII/V94WdzLJMO8wjmHmouo cm7LypP2fW+t/xQBI7Ki0Yawg1ZaflZM0C5C0bjjXUAQmzufA+hqLWg8GFhrZOmeYC4e wTmgA+Xya4wswpfMBeWH1aCm750bmmCYhZGFRoy6la6pD3VBQa10B8YnxgF8lvLR1/Pn E59M6ra2coN6ZDR7rh+G9f3pUf8e3TkbDUfCGgDBzCv2DQV0ELuHl/Yl8CXxCtknm4aU wAxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781498761; x=1782103561; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7B1Rri1bOKV6WrRa0Ahdi5sYNCs1jyUm85PYhWylAME=; b=fVqQddmtQwCW5dnUfrsFHTE/1ew9rfuH+o+bkCewF9pzfi0AWYJDciNGOWrri8BxL8 N/Ooxdn/U8HrZrJ3t2Qem192GfmrSS8qKJllhE+PJ+JcoxIhTM368BTtJtgNjDlS/BqG WUeoBRBm+ufHxVKl0Mk5Hy9M/XG7sHi8qhn36wFC7QofDbgZmi25rAKDgirSYMqEH7iy 5aPRMCs/ydDdGWnfWbBZPlifrhHpOvWEk5nPfNs6nNuUhT5z6o3fUyJPR4pl2RuAWJO8 2vRw1Osvss9V6s8QWZjE33ju19AXywVEpxhPb+SG+8V+qycKJ1eXm3LaJX7CAW1guoLL P1PA== X-Forwarded-Encrypted: i=1; AFNElJ/GqAtmud6D+jOPCo8zS9tawEriKHhVLbre33EykwuLM1dyHuSUOqUTHgiHKz84MBKOelbIGfLmdptufiA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3Nn/Ff14jRS50UgZaP1vy6ZpRXZj5ozK/Nn/MSNGz2bpp8A1u mDePw4wE3vsjAR+t2GbgkothbzNtUaJXbXxOMuPFep1p/DETqceTca79pSmsfyAgz0k3ZBODEiq AtE784YBDgIKqOehIUi/2CYNY1vVfHD/DWpy27GPkzCjLsizFgfKXy77H/166p9/0WqDIUIGZLs s= X-Gm-Gg: Acq92OFJLxNfXVTeuxDl2NDVfLB9cP9g4lvsLfkBNMjKG9gAFSY/XsV0a9qyOV8cC08 532w0bEx2x0qxswVyWF+BA82l7/u8ohelpsahnT0YsVhVI+nWjLZIANvFKuyJx/BW5MoNjgzPaH BloNnes/tZ0euVtba9LBpgJUNhL1Gs3GFVkVSVgkDygST21ysItmbd/QmqBoL1lA5ms+Ibp3qfx nQM9sqBSQ7T5lBd3BiHQ2idHar/AV9BmM0Lq0/9W+UG6k4Qarx6cRl3l3SPzvlgB3NPbPfSR8pu TfGh1GrutG5ayWU2v86M3V1RRBY8UoGHxjQNrQA6OyoBu60FFmHchcMFY2T3BQvBNazQwFBYGGP /nWpWQe3Rms4pz7Hr3C1vc0z98VdglPjf5xMJjQaPASObcBU= X-Received: by 2002:a17:902:c402:b0:2b2:ebed:7af5 with SMTP id d9443c01a7336-2c66416349bmr112903575ad.13.1781498760600; Sun, 14 Jun 2026 21:46:00 -0700 (PDT) X-Received: by 2002:a17:902:c402:b0:2b2:ebed:7af5 with SMTP id d9443c01a7336-2c66416349bmr112903375ad.13.1781498760125; Sun, 14 Jun 2026 21:46:00 -0700 (PDT) Received: from [100.70.28.15] ([49.45.133.242]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5565sm86704935ad.1.2026.06.14.21.45.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2026 21:45:59 -0700 (PDT) Message-ID: <432f3a3b-3d28-4130-9a9c-61be04eade1d@oss.qualcomm.com> Date: Mon, 15 Jun 2026 06:45:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle To: Neeraj Soni , Kuldeep Singh , ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Abhinaba Rakshit References: <20260608041650.541502-1-neeraj.soni@oss.qualcomm.com> <20260608041650.541502-2-neeraj.soni@oss.qualcomm.com> <1a66f1a6-840b-4de4-8e65-a3456b654044@oss.qualcomm.com> <91a90c37-f93a-17c8-b4fb-290759645977@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US In-Reply-To: <91a90c37-f93a-17c8-b4fb-290759645977@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDA0NSBTYWx0ZWRfX5mgkbr57TM+n Z4aHRcHLzcoc7B+91x1Atsus/27oi836tAFFMcf+NAOTWEMLs+oe3m/mwCjglAd0bnGvEdPalEv 4h+W4DGjCW2lPP3pjgzbzBFiGgvRyok= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDA0NSBTYWx0ZWRfX5N813XOFwF0d 0Ib47XYrFHeBPDVVk+m9WFCIN+0xOy9OVvwj3fO/zI58oCNscCq418f340QDxLytpZ7VCh4rUnx Vf4qE7EFJOmMpM+7t3kIMTm2dvTRMLmqdrgPlOdCuet5KdSDfdbNyjDhxNweSLPL+5Qk/oE1yRj HpI6BgfihtECNAlbHGL82x7N0t+x3hNAruekX3GpL4dJbPO4FAGMsUSvhJrne8Nm/e9eJ0fzRi/ ejyvkvdnLlkawhIM/9zbFo/R6nbeQ6spV0smQQ6Va2iV/TQPbUcCq/MMgqWXbVIodyJGpOUOUip Wygi8UBs6XLvpzwaiTzAojFeHUkl8FEeuoGQpsTb4ejNYWYmalc4OIIaa8FL5dwQtY6bPgWQCJS 6yMmn5d78wqgVxgmLVKbXAaUW3KWU2jFejMKEvLS4TW2Vnb+yXnOWGtdtz0UjSKfN7MdGy6Ur7E MvXQ4uZikmk4m6QmQEA== X-Authority-Analysis: v=2.4 cv=NrThtcdJ c=1 sm=1 tr=0 ts=6a2f8389 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=0jymCCPDh6kUuRDdYuKZ0Q==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Kt5I_01B2RkASw4xh4EA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: m73Bd7b9QPZTHvAvUSuoyXdHyfzihRsh X-Proofpoint-ORIG-GUID: m73Bd7b9QPZTHvAvUSuoyXdHyfzihRsh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_01,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150045 On 13/06/2026 07:21, Neeraj Soni wrote: > > > On 6/9/2026 5:19 PM, Krzysztof Kozlowski wrote: >> On 09/06/2026 10:18, Neeraj Soni wrote: >>> >>> >>> On 6/8/2026 11:40 AM, Kuldeep Singh wrote: >>>> On 08-06-2026 09:46, Neeraj Soni wrote: >>>>> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >>>>> So add the qcom,ice property to reference it. >>>>> >>>>> To avoid double-modeling, when qcom,ice is present, disallow an embedded >>>>> ICE register region in the SDHCI node. Older SoCs without ICE remain >>>>> valid as no additional requirement is imposed. >>>>> >>>>> Co-developed-by: Abel Vesa >>>>> Signed-off-by: Abel Vesa >>>>> Co-developed-by: Abhinaba Rakshit >>>>> Signed-off-by: Abhinaba Rakshit >>>>> Reviewed-by: Kuldeep Singh >>>>> Reviewed-by: Krzysztof Kozlowski >>>>> Link: https://lore.kernel.org/r/20260310113557.348502-2-neeraj.soni@oss.qualcomm.com >>>>> Signed-off-by: Neeraj Soni >>>> >>>> Link should go below "---" to specify previous discussions. >>>> >>>> Usually maintainers add link of patchset being merged here while merging >>>> changes in their tree but authors don't add it here. >>>> >>> Do not see any such restrictions here https://www.kernel.org/doc/html/latest/process/submitting-patches.html >> >> What do you provide that Link for? What does it bring? >> > Kuleep highlighted a concern with the usage of "Link:" tag. The link i > provided guides on posting patches to upstream linux. Wanted to highlight > what i folloed and I did not find any specific comment/line in the guide > which prohibits author to use "Link:" tag in trailer section. If there This is reversed logic. You need to provide reasons WHY it is worth, not just claim it is not disallowed. Adding 100 Links to whatever website is not disallowed, so you are going to add them? > are guidelines otherwise please let me know and i will correct and post > new patch. The "Link:", not the URL itself. What does it bring? Linus made clear statement that you should not add links UNLESS you have a reason. So please share the reason. If you do not have, DO NOT ADD any "Link:". Best regards, Krzysztof