From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E88A8C001DD for ; Tue, 11 Jul 2023 14:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbjGKO7J (ORCPT ); Tue, 11 Jul 2023 10:59:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbjGKO7H (ORCPT ); Tue, 11 Jul 2023 10:59:07 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13681B6 for ; Tue, 11 Jul 2023 07:59:06 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4fba74870abso8747066e87.0 for ; Tue, 11 Jul 2023 07:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689087544; x=1691679544; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/BBSi3Y2p51GXr/kdqXZWgeltZiMvocxuPhmv54PXCk=; b=m+crFpHVwUmNM1IevtAkCKRHO2NdXi4Nv5/sUrEBbC/6G0nqVk8jGFXEAycB2kX3/L yvpyGo1nZPsvQ4GyyX94zgLaMZrnPUkVphABTvta+rc1eml+Om6KmMMO4if+VkCc8nnE RZE1XinaqSkpC3X7oR2fPKc479VXNwDGzIsXrzYOrRVxNtPGrJ7S2R6gHn0TFLuVKh0C g18BnSXimKeLS0zSqaCI37EeNROn24C5wMu4bX6B61wwlkKwyDqcfqCGMWfVui+WP4co 73Qj8z6Gln/VVpK0hrN3zfZDaXosWyu5cy62er1WWnY1FcXuqsNq0aeer9cm3PdNkqGK nScQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689087544; x=1691679544; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/BBSi3Y2p51GXr/kdqXZWgeltZiMvocxuPhmv54PXCk=; b=HjqHbgd/YXB6X+U1IwIzam+uiHSiSD8Ec0qj9/GvY/pLwfUSm3bpqoijpt9rwvRSZq SL1Wo4QhQp6cXKbIjRf3HCAPRrSeQPvN2J59R1KjxPraeBqjJ/80P3Ltwy0jyeR13+k1 IGn42ODQRV7l/Md8iFATm7xFnJOTVFHAxyijDvYVqp2UBqSebfJjbU0Xg+dReduRUz0u hw43BbxWm4X3H15WD8R1uLtwQ1kPsh0H3ENlZuX+tPxv0PdoT7UP6dZBJ++HE4SS9RUv d94MSE6tMUTnP9TdvNP+zmd02OMjJ9dxnBF3BhyPpX7LcHXENsMRN2E4f2urD4kzJmJl vp4Q== X-Gm-Message-State: ABy/qLZDSX9UmXT4aHfFKW1HgWrTORPOuDQvTo4KVTz8NTM0doBiZ9CW nxI2Q8K/RKsJyeyQMVPRH3mm/Q== X-Google-Smtp-Source: APBJJlEmv479eisRoP1W7B2jI6/9ZRK/5ke7XvBE3vPvencrHGUfD1y6xArNgZUCsv/KhIU2Uxl+bg== X-Received: by 2002:a05:6512:128a:b0:4f8:5ab0:68c4 with SMTP id u10-20020a056512128a00b004f85ab068c4mr16389336lfs.59.1689087544345; Tue, 11 Jul 2023 07:59:04 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id j14-20020a19f50e000000b004f7618c67a7sm349351lfb.76.2023.07.11.07.59.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 07:59:03 -0700 (PDT) Message-ID: <4330df82-77a9-27ce-3f24-144718cc082e@linaro.org> Date: Tue, 11 Jul 2023 17:59:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes Content-Language: en-GB To: Konrad Dybcio , Krzysztof Kozlowski , Rohit Agarwal , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1689054169-10800-1-git-send-email-quic_rohiagar@quicinc.com> <1689054169-10800-2-git-send-email-quic_rohiagar@quicinc.com> <2040226e-9b45-b409-3edd-a5b86d86daa8@linaro.org> <8a3124ce-a11d-2491-eaee-1695cec70b17@quicinc.com> <8c3468f0-3069-95e3-e2f1-279fca78a578@linaro.org> From: Dmitry Baryshkov In-Reply-To: <8c3468f0-3069-95e3-e2f1-279fca78a578@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2023 14:44, Konrad Dybcio wrote: > On 11.07.2023 08:22, Krzysztof Kozlowski wrote: >> On 11/07/2023 08:17, Rohit Agarwal wrote: >>> >>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >>>> On 11/07/2023 07:42, Rohit Agarwal wrote: >>>>> Add Generic RPMh Power Domain indexes that can be used >>>>> for all the Qualcomm SoC henceforth. >>>>> >>>>> Signed-off-by: Rohit Agarwal >>>>> Suggested-by: Konrad Dybcio >>>>> --- >>>>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>>>> 1 file changed, 30 insertions(+) >>>>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>>>> >>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>>>> new file mode 100644 >>>>> index 0000000..4da2e04 >>>>> --- /dev/null >>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >>>> Filename based on compatible. >>> This is not specific for SDX75. These are generic ones that should be >>> used for all other targets. >>> Konrad suggested in v1 to avoid target specific prefixes everytime and >>> to create a new generic >>> dt-bindings that can be reused. >>>>> @@ -0,0 +1,30 @@ >>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>>>> +/* >>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>>>> + */ >>>>> + >>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>>> + >>>>> +/* Generic RPMH Power Domain Indexes */ >>>>> +#define CX 0 >>>> These are very generic names, usually not used in global headers. Please >>>> use some reasonable prefix. >>> This was based on the suggestion from Konrad in v2 to drop the RPMHPD >>> prefix and we can go only with names like CX, etc. >> >> I don't think having so generic name in tree-wide header is good idea. > Conversely, I think that it would be very clear in files including this header. It is expected to be included into dtsi and into rpmhpd driver (only). However I'd also suggest adding some generic prefix (e.g. RPMHPD_CX). Just `CX' is too short and has a sensible possibility of getting a symbol conflict. > > Konrad >> CX can mean anything. >> >> Best regards, >> Krzysztof >> -- With best wishes Dmitry