From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1FB539CD0A for ; Thu, 6 Aug 2026 16:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786033078; cv=none; b=uss5ixKSdzHdOnU6+4qvuVUZXDVvotyqp6eN974xIu4N1/NwovQfv4ousSd86XL0DrdXBQuBF71N4eCpLqN3Ut2zOsTwETsm1YPF/hLQAs23PUEqlGX3IhDQgeFH637w2XY5Vl/l0olRL3HmTCYsdrGUxzXjnAIBjqp4YQWVPZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786033078; c=relaxed/simple; bh=h8+2Erq/wSaXTLvVyIseCSe6KFN1jiUdb+sF2rTDb44=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PpGPumZES9jXa8aEgIHLZrcET5uy3tXJV+ysvruRd01Tvfl1kN3nJjY6g6+2QHPym9BzAKKDixBPBaY0kadWNsr7xJTe5yz/r3h/ey4cBTvrzcK2zwQQjhRb1nmS4Yb9Uoyx+1IHem7l2nX3Eu3ZXsMeaNR0DnXKovkAmpO4aK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Gnij0g2r; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gnij0g2r" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso1530015f8f.1 for ; Thu, 06 Aug 2026 09:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1786033067; x=1786637867; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=s2TkJw4qV4dMHeSE8n4BR00N5vqDbN8wATqN3VEnGD4=; b=Gnij0g2rgQCYJ4K8bhohuTLp1zuzsMr7Dl/FiNfDF2pUb67J+eVu+Hs+X9q4kuYooG hYImAFmk0ljJDhSJeSbUv5BFB+97pG24smURdsDQMJnk2QN0R5z5RaWxB6h7s3JQesTQ Ls8vUZ09o5SvRojlWEiPoFOT1loBs8ozHCCZVNi96lpby1kFVMjNS19BaRLm91XccJYK Vi1WZ+QFJpdHl+3AVxVobCDaj/R2QgbI1yLDjZrxjcKt7xP2nDlFe6CkKLZhrVhyGR+E d75qxl3YYzX3qXs7AL5JJtRX74iTticGoH72VFRnxYKKtknDbp2GlI4W5CkoD8BEjKjG wSdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786033067; x=1786637867; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s2TkJw4qV4dMHeSE8n4BR00N5vqDbN8wATqN3VEnGD4=; b=osP0dcOe74nfwluEfFVqrR4ZiqHcli3lVvdTtlAhww2f83nEYSYS66k/HXgJYZDtsq 9pBh4W1MW8ocpRH1v0xqvsomQCTx5J0DusPcMMMBOI2PSRdZVl0Jh2OR/3ghby0bu1lY ep2mXxlg+V6nWSXfsiUECVtgkW1hgNyHNGxZOz3wW/jEWT6AhOqL6K5EKvDPksfk8V5C JTkeZBrk6Qo/Y85JOFVbWrj26gPatdR6HZ+ULRe1AJfnfMRuVO0E1wXGJIb9b8G1NhX1 iIknmxcHbjCG7p90Ceb6yMcm9S8C6fcadhYaa3kNVLXusiYDWpMjiEZ5yNdjg5ZrgXfQ engg== X-Forwarded-Encrypted: i=1; AHgh+RoPpzHx/Mc6/sPeXe/WRaPTOmKoY15RofpXhCKBCChd6TybaY+58QXJX+qbYLr2oz/7YT9Kg1VSDtoXTGU=@vger.kernel.org X-Gm-Message-State: AOJu0YxqzqbooUDMYxYSeozhaAZ+QMJVXySv30RKB79DnChx8DuSEL4N rmJVUo0B87E+76c86QstztiY74Gv7uZ4jkC0eWOW5fhA7bGyDy7Yz0KNuD5LGuzG28g= X-Gm-Gg: AR+sD10fEmMi2x6hZJX+j7EklWbJlSWUUKwsLGAAxOyzub5JW6ZzUhxAmiDH1pxtyYq zuLDtzS0TrKA0K1yp8oviBFa5fkQundPd3ExQ0fw3TNE0V3t4dk+72QKcTrVzLn38LsqRcmBQzr vvHTbvctxaR60ah1pS1X31wr8Tk/aW4t2mRtTB/oYY+1SEsO9H08huqz6pjxaJrR75iJVvKhXxz h7y+Le8esk4qRmM3OzPoGl5JqcrvpCxTd2LSeGGPrGbWaqX40sa+K1KdWA/LxoHKGw5jHPfzG+u jAkfztCqpFizLmUjNriccTMvdbOlUq20HSq2DT5rHHhZYAqwpo8a7NETxPJ44CgZgJVlbuu2AEr r0iBJtcAZGTk5TDFqdyIPJqsJAc5eNXi8AwQTwBjz9BvuQ/dh6vEsHspgrEozT31PLm1aihFfLc 52agb8HrgGim4/0aIsjVp2MMdCNEl1XfJKjtwagSAuMw/WEqL6xD0UQzPr3GfUmJrBdDTZOoy3F A== X-Received: by 2002:a5d:6f0a:0:b0:47f:8a1c:54d8 with SMTP id ffacd0b85a97d-47fec502df3mr23870212f8f.3.1786033067170; Thu, 06 Aug 2026 09:17:47 -0700 (PDT) Received: from [192.168.0.101] ([109.76.115.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff7b32487sm6964879f8f.34.2026.08.06.09.17.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 09:17:46 -0700 (PDT) Message-ID: <43327fb2-0085-4d86-b408-8723d852c258@linaro.org> Date: Thu, 6 Aug 2026 17:17:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] phy: rockchip-samsung-dcphy: factor MIPI D-PHY power on/off into helpers To: jason98166@gmail.com, Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Guochun Huang , Philipp Zabel Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260726-dcphy-rx-v1-v2-0-cf9cc34a412a@gmail.com> <20260726-dcphy-rx-v1-v2-2-cf9cc34a412a@gmail.com> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <20260726-dcphy-rx-v1-v2-2-cf9cc34a412a@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/07/2026 15:55, Jason Yang via B4 Relay wrote: > static int samsung_mipi_dcphy_power_on(struct phy *phy) > { > struct samsung_mipi_dcphy *samsung = phy_get_drvdata(phy); > @@ -1368,7 +1376,7 @@ static int samsung_mipi_dcphy_power_on(struct phy *phy) > > switch (samsung->type) { > case PHY_TYPE_DPHY: > - return samsung_mipi_dphy_power_on(samsung); > + return samsung_mipi_dphy_tx_power_on(samsung); > default: > /* CPHY part to be implemented later */ > return -EOPNOTSUPP; > @@ -1383,16 +1391,11 @@ static int samsung_mipi_dcphy_power_off(struct phy *phy) > > switch (samsung->type) { > case PHY_TYPE_DPHY: > - samsung_mipi_dphy_lane_disable(samsung); > - break; > + return samsung_mipi_dphy_tx_power_off(samsung); > default: > /* CPHY part to be implemented later */ > return -EOPNOTSUPP; > } > - > - samsung_mipi_dcphy_pll_disable(samsung); > - > - return 0; > } This looks a bit funny. Do you have an int method() {} with a final path that returns no value ? Tooling/compilers will definitely and rightly complain about that. --- bod