From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74227C76186 for ; Tue, 23 Jul 2019 18:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48210227D4 for ; Tue, 23 Jul 2019 18:31:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SeHacVK8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403826AbfGWSbl (ORCPT ); Tue, 23 Jul 2019 14:31:41 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36372 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727021AbfGWSbl (ORCPT ); Tue, 23 Jul 2019 14:31:41 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x6NIVaCT063191; Tue, 23 Jul 2019 13:31:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1563906696; bh=9cv0+/SVJMPPDN0ZhXDWZYsyy291EnVoJwpIzV02j8M=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=SeHacVK8t8RCkv+qAMQXCHTb6PB5lzmPbPg+KdmGrP+jyoTeiqZD0/n1ltfNLbthV x7QfW3TGGjmgaa/0bqdDHOHZUzwJjtHyA63cjRBgwevKfkv/g92Dr4/MBFo7eGzDD4 7oiKUwn7vFUJfLYTwAlaNeX2eS2s+o4s4RbIb+VY= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x6NIVaKB079235 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 23 Jul 2019 13:31:36 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 23 Jul 2019 13:31:36 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 23 Jul 2019 13:31:36 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x6NIVZ6q129119; Tue, 23 Jul 2019 13:31:36 -0500 Subject: Re: [PATCH 3/8] bus: ti-sysc: Fix handling of forced idle To: Tony Lindgren , CC: Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Keerthy , Nishanth Menon , Peter Ujfalusi , Roger Quadros , Tero Kristo , , References: <20190723112811.44381-1-tony@atomide.com> <20190723112811.44381-4-tony@atomide.com> From: Suman Anna Message-ID: <4336e7ef-3857-e42f-e67c-94809acc59b8@ti.com> Date: Tue, 23 Jul 2019 13:31:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190723112811.44381-4-tony@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/23/19 6:28 AM, Tony Lindgren wrote: > For some devices we can get the following warning on boot: > > ti-sysc 48485200.target-module: sysc_disable_module: invalid midlemode > > Fix this by treating SYSC_IDLE_FORCE like we do for the other bits > for idlemodes mask. > > Fixes: d59b60564cbf ("bus: ti-sysc: Add generic enable/disable functions") > Cc: Roger Quadros > Signed-off-by: Tony Lindgren Reviewed-by: Suman Anna regards Suman > --- > drivers/bus/ti-sysc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > --- a/drivers/bus/ti-sysc.c > +++ b/drivers/bus/ti-sysc.c > @@ -949,7 +949,7 @@ static int sysc_best_idle_mode(u32 idlemodes, u32 *best_mode) > *best_mode = SYSC_IDLE_SMART_WKUP; > else if (idlemodes & BIT(SYSC_IDLE_SMART)) > *best_mode = SYSC_IDLE_SMART; > - else if (idlemodes & SYSC_IDLE_FORCE) > + else if (idlemodes & BIT(SYSC_IDLE_FORCE)) > *best_mode = SYSC_IDLE_FORCE; > else > return -EINVAL; >