From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82EDD3CB2ED for ; Thu, 5 Mar 2026 15:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772725395; cv=none; b=YEh7E+WHB7H1pfBQPRET3JsUExH4i8eTVza81SStJDuXMDj3H7OY5Xy5boPpWFXKr9RfQGgk6vLnaKSrCyrXjvuhiscQJIzGh6OcT3+KkNyen+wrWFn7fh2I1DTAIKeKuJxAil5sfHPdzpE7ZKnrs781hPVZDz5kQNHPgBRpJ+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772725395; c=relaxed/simple; bh=wZwLapQXxG7D+Qlav1XZFe2kQjdkfUMBUlFhr2GSoR8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YzQEiBr0hfuKXIBfAiOV3TPRhnAofY7jRdifERgw7Q1sKLzUApFUQTvJ7aVq7fMcpJhi2YAouCguZJf4h+4nqP1sl/UDRoXR/3xLvRpXH0BHbPnblLuKfD6FLGVzdZ9qWLeANgxVEdAifG/v0oqFEityNlX0puWRAReRpb+C11k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hAB3pCoz; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hAB3pCoz" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2be26d11b95so4545904eec.0 for ; Thu, 05 Mar 2026 07:43:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772725391; x=1773330191; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9VHdXwqWfI2lXOxROY4OA5+qg4q5UeIXxvdk5YcxjXU=; b=hAB3pCozekmvwYsigwsTkjeZQNv56bN7N0oC9Jo1oFHK+SIbx8uN8aRAimE6TWR0p9 QVP3yze9c/zWkcqPcgBo5fc6BGLkKrFcyqRgMZAMx2YXbWRetPeNXnyRHq9fv+VgeKp7 /P8VH02hP0Xu2dkOZehW9365tal2eyV2GIQU26EzqAaFI7YfDkKJdqJTTt/3lR3p1CaK bLcrIlvTvaf+13RHASB2C0HabkFvvXhAKD9iioAmpI5gZru7U840QcGy5fcGTDjJLuhg mHsyXK4e2ZBeX/GGHPY2z62wgsAp0+nLr8qdXT9xBW61h9zPuDW6bSifb4QgpleY5R0Y brog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772725391; x=1773330191; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9VHdXwqWfI2lXOxROY4OA5+qg4q5UeIXxvdk5YcxjXU=; b=TgbG8CWdDbSqEu5cssJldotKcQCXvIOD6aVy9lCMVBQ140GT8SkLrvOr/qLOSkBv5y BXrv6oLTRsCpz8d6ZIE5KLPQ7Q4C/MeigYkpVSgGOB7FfcieiZ3kQYaC8VKcHN41tZm9 OmhVx/BqO1Qs8vHQvfAWrqrr1Vhl8za+n4TJmyICpbG6rSAU5NZpYg+RqiNZIKJW+YV4 9yHsVZQEH1Gcc7Mn/DTvNrpQMkHUA8ly+cYgcmBYbKdEDBbCpiRNu1pLUztq0uuGFTvS nXCiFsxVT5bQ5ViN8syFx0Ux36dWMljP4FrcC7YTZdpxa2H31NYNta7QofcfzvXpcYxY z9QA== X-Forwarded-Encrypted: i=1; AJvYcCVdYw/d2Hm0iIIAny8NxnCMCEMfmKnintJP9llJF8fdfLfif106pfZUhf8hyRlglJ6pEqlo1sOwVh5BJEI=@vger.kernel.org X-Gm-Message-State: AOJu0YzrNikLEtRivckarlC+M2tQdttosw0nUojP/4timQg+fAoKEgX9 llxjww2YYBD6FOv+EBlS4odrXt3zCfzYp0tvRRaH+GC9BbCV4PZbahp8 X-Gm-Gg: ATEYQzzrs5MaDh08OoRaCoVCQNDfJiF+hSg7kTqCGVCBJqsXzTlZ1qP00Sxju0BQEAP Iuq5cThJJIMQdX8YjH54n5rWwTXvkCa6XzWV72Va/0/69A5oQT1oJXsq1C2mqp6frHU+bp66TDN LE08T2yfkdX9psI+ZOzOlpBCGGdBgyaDczBE+qDlALJxHrW6xHST4/NuwkAIM6ctAOXqMO9DTE3 Ih8tiF5IgL5nt46EjrQyy+HokDAcXf50Gx0vG8mMoePVuqgtBmDNxVENdvqHTiBpfhJ4C4ULBNB lx+Y+H5WyI8nPORnokZFAWYKY9CM6Bay6itXIkXGgv+Twoh8euQdwZ/MKo8oCE9T9LAYWKEXsjq 8tPuV8zoub23g1YWq9ojCTRDp21RjXvMeug+a6UvkvFax7rEM9L7ROekTB5knIZ4GRS4+6xKpms Fs9jh2xHWNr7SX6x6HxW8rBrJXp01xbmdAP7NWENBTcKPTLBohPS4NQW8eOJfoFmm5r7xkesg= X-Received: by 2002:a05:7300:f18e:b0:2be:1dc7:99ae with SMTP id 5a478bee46e88-2be30fbcdbdmr2671438eec.6.1772725391326; Thu, 05 Mar 2026 07:43:11 -0800 (PST) Received: from ?IPV6:2620:10d:c085:21d6::12ef? ([2620:10d:c090:400::5:3cc2]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be2f5f1f4dsm3556315eec.25.2026.03.05.07.43.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 07:43:10 -0800 (PST) Message-ID: <43433a0f-f063-4b12-ad3a-16bd6aa9cc31@gmail.com> Date: Thu, 5 Mar 2026 07:43:08 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next V4 5/5] eth: mlx5: Move pause storm errors to pause stats To: Tariq Toukan , netdev@vger.kernel.org Cc: alexanderduyck@fb.com, alok.a.tiwari@oracle.com, andrew+netdev@lunn.ch, andrew@lunn.ch, davem@davemloft.net, dg573847474@gmail.com, donald.hunter@gmail.com, edumazet@google.com, gal@nvidia.com, horms@kernel.org, idosch@nvidia.com, jacob.e.keller@intel.com, kernel-team@meta.com, kory.maincent@bootlin.com, kuba@kernel.org, lee@trager.us, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux@armlinux.org.uk, mbloch@nvidia.com, mike.marciniszyn@gmail.com, o.rempel@pengutronix.de, pabeni@redhat.com, saeedm@nvidia.com, tariqt@nvidia.com, vadim.fedorenko@linux.dev References: <20260302230149.1580195-1-mohsin.bashr@gmail.com> <20260302230149.1580195-6-mohsin.bashr@gmail.com> Content-Language: en-US From: Mohsin Bashir In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/5/26 6:12 AM, Tariq Toukan wrote: > If we return here, tx_pause_storm_events remains unset, while rx/ > tx_pause_frames are already assigned. > Is that acceptable? I'm probably fine with it. Right. Since we are aggregating across all prio and if we fail mid-flight, IMO, we should not report partial sum which maybe inaccurate.