From: "Romli, Khairul Anuar" <khairul.anuar.romli@altera.com>
To: Dinh Nguyen <dinguyen@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ang, Tien Sung" <tien.sung.ang@altera.com>
Subject: Re: [PATCH v3 1/1] firmware: stratix10-svc: fix bug in saving controller data
Date: Mon, 3 Nov 2025 23:10:59 +0000 [thread overview]
Message-ID: <4343e9cc-9e22-46bf-b78b-7b934d888f28@altera.com> (raw)
In-Reply-To: <649ca547-ab05-40b6-8e20-b1121720e601@kernel.org>
On 3/11/2025 8:14 pm, Dinh Nguyen wrote:
>
>
> On 11/2/25 17:21, Khairul Anuar Romli wrote:
>> Fix the incorrect usage of platform_set_drvdata and dev_set_drvdata. They
>> both are of the same data and overrides each other. This resulted in the
>> rmmod of the svc driver to fail and throw a kernel panic for kthread_stop
>> and fifo free.
>>
>> Fixes: b5dc75c915cda ("firmware: stratix10-svc: extend svc to support
>> new RSU features")
>
> Trimming this to 12 characters SHA. I know that documentation says at
> least 12, and not exactly 12, but the normal procedure is to use exactly
> 12.
>
> Applied!
>
> Thanks,
> Dinh
Noted. Thanks for helping out to trim it to 12 chars.
Best Regards,
Khairul
prev parent reply other threads:[~2025-11-03 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1762125299.git.khairul.anuar.romli@altera.com>
2025-11-02 23:21 ` Khairul Anuar Romli
2025-11-03 12:14 ` Dinh Nguyen
2025-11-03 23:10 ` Romli, Khairul Anuar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4343e9cc-9e22-46bf-b78b-7b934d888f28@altera.com \
--to=khairul.anuar.romli@altera.com \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tien.sung.ang@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®