From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030210AbcFBLne (ORCPT ); Thu, 2 Jun 2016 07:43:34 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:59326 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030193AbcFBLnb (ORCPT ); Thu, 2 Jun 2016 07:43:31 -0400 From: Arnd Bergmann To: Tomasz Nowicki Cc: helgaas@kernel.org, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jchandra@broadcom.com, robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, liudongdong3@huawei.com, cov@codeaurora.org Subject: Re: [RFC PATCH 1/3] pci, acpi: Match PCI config space accessors against platfrom specific ECAM quirks. Date: Thu, 02 Jun 2016 13:42:43 +0200 Message-ID: <4347711.qDrKz2s8lr@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1464856864-18049-2-git-send-email-tn@semihalf.com> References: <1464856864-18049-1-git-send-email-tn@semihalf.com> <1464856864-18049-2-git-send-email-tn@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Y3yqM9APRnp2wTW4hwAyrOn3QvT94oBobIPxjcCKre0MGLQn8MJ avKs8m0CyQl/0fu2khqr83ZXtnVpsP17Vh3Vz3Z4W4ZBYj+R0lrkf9fnTYgM3SeIRxfFefc TFLYXomZuTiIJQ/64hWTSPTITnBZqxT/r2Yg15BLNShNEtIQk36afFboWDyLBzHIAxC5Z18 cAIvfEDP6+eN1YRwQq23Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:mLyR6cSRelw=:PiOPjMxEjccal4JfRqKwV3 I66DMwsC97rI/f1DvocbOIR9T0CaabTcax7FuRpszW6gXQ1Gm3blvVka90fIGC4XPKg92IevL Gl0fvmIYY++VLyczIt132JrNNfUoiep/uoGLJCQ3hsWN8xSJjhlIBzgFZO0FGUOR6fgadP7S8 Rxy+cG+4Ggc7CIu6vKtPachESG3BmbbmN94gZflphIUU/a7imxPxB/pS/bfwg6LW1FRqOnRxH EPDQc9T05iuDJ7Z2aniov8AABqg/94f0nNmhDTTNyybaC5KxcNIBMgs4AnSRb9mebdywDdNhn 5Hhob1MaJsQMXoQ/8BBCAQJrD2Aa8BgzW2kfOI8TFATEG1gmQZonGZgOmwo+/THeL/Qg9tRsK d+Yl+GP4hRkxhxFTh/0VF39UxREpv4WKwbtf80udIrO7ZslBrWiJwVzomPETf8ghIPfPLOStQ q32o3+cQKrumm9JTNeOslkeiwlk8hnYxQRNXvWMQdAwbugrmTOJEKvF2j2lBlK/ops/6ZN1jb +Kh6k+/r1TflI8k2oZM75t2b15mkSE6XgqaCCQYHAIk3fqDIj/lkqhPHqacxsJES0C53VAnv5 9MwWE/oOUzDt5MLL6mV9DLr5VyH14QH1J64Uku7pXCIzZvyp1cIVWOtJaQN3ZCLPv/Oai0sJM LnZugK2A47gYg7j1ccgXmPrx4WLHCER9UMiLf4s+Ez0D506ATR7dsOiyRBD3oClb9yrU9ECvt bkhhJQeNtEPBAw6D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, June 2, 2016 10:41:01 AM CEST Tomasz Nowicki wrote: > +struct pci_ecam_ops *pci_mcfg_get_ops(struct acpi_pci_root *root) > +{ > + int bus_num = root->secondary.start; > + int domain = root->segment; > + struct pci_cfg_fixup *f; > + > + if (!mcfg_table) > + return &pci_generic_ecam_ops; > + > + /* > + * Match against platform specific quirks and return corresponding > + * CAM ops. > + * > + * First match against PCI topology then use OEM ID and > + * OEM revision from MCFG table standard header. > + */ > + for (f = __start_acpi_mcfg_fixups; f < __end_acpi_mcfg_fixups; f++) { > + if ((f->domain == domain || f->domain == PCI_MCFG_DOMAIN_ANY) && > + (f->bus_num == bus_num || f->bus_num == PCI_MCFG_BUS_ANY) && > + (!strncmp(f->oem_id, mcfg_table->header.oem_id, > + ACPI_OEM_ID_SIZE)) && > + (f->oem_revision == mcfg_table->header.oem_revision)) > + return f->ops; > + } > + /* No quirks, use ECAM */ > + return &pci_generic_ecam_ops; > +} > + > int pci_mcfg_lookup(struct acpi_pci_root *root) Can you explain the use of pci_ecam_ops instead of pci_ops here? I was hoping we'd be able to fold all of pci-ecam code into the generic PCI layer at some point and get rid of pci_ecam_ops in the process. Arnd