From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1479A22425B; Mon, 26 Jan 2026 17:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769448557; cv=none; b=FMRhU7fLHct0j4+lVgeAKKD2z26uWcxqnd6Ns8o48r7/kHcFTHh8QUys1dFK4wkJdlg5JIh06voVROZ8Wo4+E4s5B85K28FbftbFixFgx/kyKFxCdoDFcJxgz6qED+tmsh3Qm9d0rp7/qZq3NyMt8kYWai7QeqMgUuYBXAymYGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769448557; c=relaxed/simple; bh=ZoI4QG8Qr7DoTAoBBmichT7W1VBiBOIrbJAzWe7mPWE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b+a9gDy+lMrQNPxntOJM6r4RoAIcc61vQqOIZxQvNmr6ejKKCb7WpCf+cxGyLlitb0YMh77OKm5N3t5Yz7v2lM4dA3vakig40sU2UnqftYj2iM5ltQsJiBkdHbZEg2LeZfBacR7wxSDJZ+ZOin6yyRtlOpGBeffUYdiJChAqdVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [192.168.2.221] (p57bd931f.dip0.t-ipconnect.de [87.189.147.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id A4ED24C4430092; Mon, 26 Jan 2026 18:28:30 +0100 (CET) Message-ID: <4347b1f7-dcd5-40a1-aebd-40060e9769f2@molgen.mpg.de> Date: Mon, 26 Jan 2026 18:28:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [iwl-net PATCH v2] idpf: change IRQ naming to match netdev and ethtool queue numbering To: Brian Vazquez , Brian Vazquez Cc: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, David Decotigny , Li Li , Anjali Singhai , Sridhar Samudrala , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, emil.s.tantilov@intel.com, Brett Creeley , Aleksandr Loktionov References: <20260126144624.2319784-1-brianvv@google.com> Content-Language: en-US From: Paul Menzel In-Reply-To: <20260126144624.2319784-1-brianvv@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Brian, Thank you for your patch. Am 26.01.26 um 15:46 schrieb Brian Vazquez via Intel-wired-lan: > The code uses the vidx for the IRQ name but that doesn't match ethtool > reporting or netdev naming, this makes it hard to tune the device and > associate queues with IRQs. Sequentially requesting irqs starting from > '0' makes the output consistent. > > Before: > > ethtool -L eth1 tx 1 combined 3 > > grep . /proc/irq/*/*idpf*/../smp_affinity_list > /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 > /proc/irq/68/idpf-eth1-TxRx-1/../smp_affinity_list:0 > /proc/irq/70/idpf-eth1-TxRx-3/../smp_affinity_list:1 > /proc/irq/71/idpf-eth1-TxRx-4/../smp_affinity_list:2 > /proc/irq/72/idpf-eth1-Tx-5/../smp_affinity_list:3 > > ethtool -S eth1 | grep -v ': 0' > NIC statistics: > tx_q-0_pkts: 1002 > tx_q-1_pkts: 2679 > tx_q-2_pkts: 1113 > tx_q-3_pkts: 1192 <----- tx_q-3 vs idpf-eth1-Tx-5 > rx_q-0_pkts: 1143 > rx_q-1_pkts: 3172 > rx_q-2_pkts: 1074 > > After: > > ethtool -L eth1 tx 1 combined 3 > > grep . /proc/irq/*/*idpf*/../smp_affinity_list > > /proc/irq/67/idpf-Mailbox-0/../smp_affinity_list:0-55,112-167 > /proc/irq/68/idpf-eth1-TxRx-0/../smp_affinity_list:0 > /proc/irq/70/idpf-eth1-TxRx-1/../smp_affinity_list:1 > /proc/irq/71/idpf-eth1-TxRx-2/../smp_affinity_list:2 > /proc/irq/72/idpf-eth1-Tx-3/../smp_affinity_list:3 > > ethtool -S eth1 | grep -v ': 0' > NIC statistics: > tx_q-0_pkts: 118 > tx_q-1_pkts: 134 > tx_q-2_pkts: 228 > tx_q-3_pkts: 138 <--- tx_q-3 matches idpf-eth1-Tx-3 > rx_q-0_pkts: 111 > rx_q-1_pkts: 366 > rx_q-2_pkts: 120 > > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") > Signed-off-by: Brian Vazquez > Reviewed-by: Brett Creeley > Reviewed-by: Aleksandr Loktionov > --- > V2: Add mising Fixes tag > > drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > index c2a1fe3c79ec..c1f8dfc570ce 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > @@ -4093,7 +4093,7 @@ static int idpf_vport_intr_req_irq(struct idpf_vport *vport, > continue; > > name = kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name, if_name, > - vec_name, vidx); > + vec_name, vector); > > err = request_irq(irq_num, idpf_vport_intr_clean_queues, 0, > name, q_vector); With Andrew’s comment addressed in the commit message, this looks sensible. Reviewed-by: Paul Menzel Kind regards, Paul