[PATCH] i386: fix stack alignment for signal handlers (ia64) This fixes the setup of the alignment of the signal frame, so that all signal handlers are run with a properly aligned stack frame. The current code "over-aligns" the stack pointer so that the stack frame is effectively always mis-aligned by 4 bytes. But what we really want is that on function entry ((sp + 4) & 15) == 0, which matches what would happen if the stack were aligned before a "call" instruction. [ This patch fixes ia64. i386 and x86_64 are already fixed by git commit d347f372273c2b3d86a66e2e1c94c790c208e166 ] Signed-off-by: Markus F.X.J. Oberhumer Index: linux-2.6.git/arch/ia64/ia32/ia32_signal.c =================================================================== --- linux-2.6.git.orig/arch/ia64/ia32/ia32_signal.c +++ linux-2.6.git/arch/ia64/ia32/ia32_signal.c @@ -810,7 +810,11 @@ } /* Legacy stack switching not supported */ - return (void __user *)((esp - frame_size) & -8ul); + esp -= frame_size; + /* Align the stack pointer according to the i386 ABI, + * i.e. so that on function entry ((sp + 4) & 15) == 0. */ + esp = ((esp + 4) & -16ul) - 4; + return (void __user *) esp; } static int