From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Peter Yin <peteryin.openbmc@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/5] ARM: dts: aspeed: Harma: Revise GPIO line name
Date: Tue, 12 Nov 2024 10:23:24 +1030 [thread overview]
Message-ID: <434b2dab17050643badc60c50b361153631b7cdd.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20241111094349.2894060-4-peteryin.openbmc@gmail.com>
Hi Peter,
On Mon, 2024-11-11 at 17:43 +0800, Peter Yin wrote:
> Add:
> "ac-power-button",
> "asic0-card-type-detection0-n"
> "asic0-card-type-detection1-n"
> "asic0-card-type-detection2-n"
>
> "cpu0-prochot-alert",
> "cpu0-thermtrip-alert",
>
> "irq-uv-detect-alert",
> "irq-hsc-alert",
>
> "uart-switch-button"
> "uart-switch-lsb"
> "uart-switch-msb"
>
> "leakage-detect-alert",
>
> "power-card-enable",
> "power-fault-n",
> "power-hsc-good",
> "power-chassis-good"
> "presence-post-card",
> "presence-cmm"
> "pvdd11-ocp-alert"
>
> "reset-control-cmos-clear"
> "reset-cause-pcie",
> "reset-cause-platrst",
>
> "P0_I3C_APML_ALERT_L",
Rather than list the identifiers that are already contained in the
patch, can you please discuss what functionality these identifiers
enable, how different functions are related, and why this must all be
done in one patch?
>
> Rename:
> "power-cpu-good" to "host0-ready",
> "host-ready-n" to "post-end-n
On the other-hand, explicitly calling out these changes is helpful, but
please also discuss the motivation and impact.
Andrew
next prev parent reply other threads:[~2024-11-11 23:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 9:43 [PATCH v1 0/5] Revise Meta(Facebook) Harma BMC(AST2600) Peter Yin
2024-11-11 9:43 ` [PATCH v1 1/5] ARM: dts: aspeed: Harma: Revise node name Peter Yin
2024-11-11 9:43 ` [PATCH v1 2/5] ARM: dts: aspeed: Harma: Add retimer device Peter Yin
2024-11-11 9:43 ` [PATCH v1 3/5] ARM: dts: aspeed: Harma: Revise GPIO line name Peter Yin
2024-11-11 23:53 ` Andrew Jeffery [this message]
2024-11-12 9:45 ` Peter Yin
2024-11-11 9:43 ` [PATCH v1 4/5] ARM: dts: aspeed: Harma: add e1s power monitor Peter Yin
2024-11-11 9:43 ` [PATCH v1 5/5] ARM: dts: aspeed: Harma: fan board io-expander Peter Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434b2dab17050643badc60c50b361153631b7cdd.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peteryin.openbmc@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®