From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
"open list:SAMSUNG THERMAL DRIVER" <linux-pm@vger.kernel.org>,
"open list:SAMSUNG THERMAL DRIVER"
<linux-samsung-soc@vger.kernel.org>,
"moderated list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] drivers/thermal/exymos: Use guard notation when acquiring mutex
Date: Thu, 13 Mar 2025 08:49:36 +0100 [thread overview]
Message-ID: <43506f83-13d7-46c5-b022-473ac78f0cab@kernel.org> (raw)
In-Reply-To: <CANAwSgTeZ83oqatrsWQxT+4RYwEtEqma=R4XX_iGrP2N=phz9Q@mail.gmail.com>
On 12/03/2025 15:59, Anand Moon wrote:
>>
>>> + mutex_lock(&_T->lock), mutex_unlock(&_T->lock))
>>> +
>>> /*
>>> * TMU treats temperature as a mapped temperature code.
>>> * The temperature is converted differently depending on the calibration type.
>>> @@ -256,7 +260,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
>>> unsigned int status;
>>> int ret = 0;
>>>
>>> - mutex_lock(&data->lock);
>>> + guard(mutex)(&data->lock);
>>
>> Which you do not use... Please don't use cleanup.h if you do not know
>> it. It leads to bugs.
>>
> Ok, I will drop this include of cleanup.h.
So the guards as well...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-13 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 14:34 [PATCH v4 0/4] Exynos Thermal code improvement Anand Moon
2025-03-10 14:34 ` [PATCH v4 1/4] drivers/thermal/exynos: Refactor clk_sec initialization inside SOC-specific case Anand Moon
2025-03-12 14:58 ` Anand Moon
2025-03-10 14:34 ` [PATCH v4 2/4] drivers/thermal/exymos: Remove redundant IS_ERR() checks for clk_sec clock Anand Moon
2025-03-10 14:34 ` [PATCH v4 3/4] drivers/thermal/exymos: Fixed the efuse min max value for exynos5422 Anand Moon
2025-03-10 14:34 ` [PATCH v4 4/4] drivers/thermal/exymos: Use guard notation when acquiring mutex Anand Moon
2025-03-11 16:56 ` kernel test robot
2025-03-11 17:30 ` Krzysztof Kozlowski
2025-03-12 14:59 ` Anand Moon
2025-03-13 7:49 ` Krzysztof Kozlowski [this message]
2025-03-13 10:35 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43506f83-13d7-46c5-b022-473ac78f0cab@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bzolnier@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®