From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42C681CFEAE for ; Sat, 26 Oct 2024 10:07:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729937225; cv=none; b=W+/qqIx2CtzK3WHvkIcQwgSLKwdh3xMl23Koi0fBdJHNMeJRJcYQ1KAGSSmdJCdbHW3uDKmpx2GjB5aAkCSr7WlbwFDr5ocGCHVgtnPiXcmorrZJwo1rH4TbY9CUC3PNVNZ9NsAHSk6Tog27QZy2Jtq898Jp6jripwhcqUWNiK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729937225; c=relaxed/simple; bh=Po2WhAGk+nn0G+JmrLGovSM4EdZzo3bdkB0GXDapSYw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cySlnaDYSVKJTZazTZ3O9HQ9N0LG7ua/6F74NipQ66Kt/KSuFaORH+X8ufMEQuT+8gdvDFGWrUqDc23iNJP8iTzSvtYb0N+UrWn8u+qKwu96Rtc4z8GN28hm47Z5x1Z0lkpLbi9JuRUFr4Oxpru17gJzkxjskjDGJsdXk8x3PzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YvEKHBXy; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YvEKHBXy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729937221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/f46nXkqUvA/6x0RaCqyiuYSQxfxcwYkp5yUsnCKJ8U=; b=YvEKHBXyrYR+yz5HHBtxn09wd+Ya1HcRS2jcwmcIe9nETbQGAVsBIEhsF1o0WOE8pXU6jp E+XD/aQ/ziS0fA87v+8enUBm48eo3vEawPoj6rJrzh+majV7ogvvtYU8nY2UIQjWLTvcHG 9q/a8dQkjC3ekEqerNQTMIHV4Kc0sDs= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-91mN_ss4P1CQAG2qX07fyQ-1; Sat, 26 Oct 2024 06:06:59 -0400 X-MC-Unique: 91mN_ss4P1CQAG2qX07fyQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a99fd71e777so220610166b.2 for ; Sat, 26 Oct 2024 03:06:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729937218; x=1730542018; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/f46nXkqUvA/6x0RaCqyiuYSQxfxcwYkp5yUsnCKJ8U=; b=JwdhBtJ7XRacWdYyVsS4IV7XFiwrlvdLte0P+Sx93WOpelB7w20W/ynbhXx7/qF+GX ElKH8AII0kXkxoo1OkhGwk6bIR2lJceC/z51UpLr5h+m1NBSaZnPCjX0vEk0N4uKo7Li H2r92bkU549CdOYa4B352cVmgP+xEzHrHCSdA138W82rdy/FMrKDKkFQ77DXZUSUABJj N03PKIATtFUlNixmZtU1BjIGjWReHvuqmHdcwCiJTu/dC8ArPJSm08ENZEYdCeX8mqqu x5Y24HWJAgksHPcf/tKI79P/fAl8GCtGGWLV0y6dZvcBN9QyGPWZjmNatxTU16z7uwv/ fl+Q== X-Forwarded-Encrypted: i=1; AJvYcCWmBQre6YuPhsOfoC6yW3SyUFr9Shj2x0o+umWQ+cNlY7AVAs1b4wRISZPwQRWeRFk96wUp5qGkQy/Ox70=@vger.kernel.org X-Gm-Message-State: AOJu0YzNcTovV/xKqXbo+DA0Di5AokKIZNLS9K6hdqb3gU/xiPkqxMD3 cpI98wp+EBbrgH1EAO1WSpBQ9QfbxTQKjoNn/8Ew+teuuLVSlykENsTvU684mRAvS/pbKC0fWZP NgYEVM+KMCLAOsClU0r51L2WO1H8e5SXAAbRs/mJw32iqAcXWXZghHstM2/vdpw== X-Received: by 2002:a17:907:9495:b0:a9a:5d15:26c2 with SMTP id a640c23a62f3a-a9de619c888mr155001666b.45.1729937217910; Sat, 26 Oct 2024 03:06:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYMCrnHwyTvN8DPXvX36EqqcDSeIpa76Zk1xpz15ECT52CeCo+y+8lODC9roJOeWDkY6qDIQ== X-Received: by 2002:a17:907:9495:b0:a9a:5d15:26c2 with SMTP id a640c23a62f3a-a9de619c888mr154999366b.45.1729937217426; Sat, 26 Oct 2024 03:06:57 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b3a08477bsm158255366b.201.2024.10.26.03.06.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Oct 2024 03:06:56 -0700 (PDT) Message-ID: <4350a4f0-fa9d-43a6-bec5-68f752d1395c@redhat.com> Date: Sat, 26 Oct 2024 12:06:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] platform/surface: aggregator: Add platform handler pointer to device To: Mario Limonciello , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: "Rafael J . Wysocki" , Len Brown , Maximilian Luz , Lee Chun-Yi , Shyam Sundar S K , Corentin Chary , "Luke D . Jones" , Ike Panhc , Henrique de Moraes Holschuh , Alexis Belmonte , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Ai Chao , Gergo Koteles , open list , "open list:ACPI" , "open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER" , "open list:THINKPAD ACPI EXTRAS DRIVER" , Mark Pearson , Matthew Schwartz References: <20241025193055.2235-1-mario.limonciello@amd.com> <20241025193055.2235-3-mario.limonciello@amd.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20241025193055.2235-3-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 25-Oct-24 9:30 PM, Mario Limonciello wrote: > To be able to reference the platform handler in remove, add > a pointer to `struct ssam_device`. > > Tested-by: Matthew Schwartz > Signed-off-by: Mario Limonciello Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/surface/surface_platform_profile.c | 1 + > include/linux/surface_aggregator/device.h | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/drivers/platform/surface/surface_platform_profile.c b/drivers/platform/surface/surface_platform_profile.c > index 61aa488a80eb5..958afd7bce223 100644 > --- a/drivers/platform/surface/surface_platform_profile.c > +++ b/drivers/platform/surface/surface_platform_profile.c > @@ -210,6 +210,7 @@ static int surface_platform_profile_probe(struct ssam_device *sdev) > return -ENOMEM; > > tpd->sdev = sdev; > + sdev->tpd = tpd; > > tpd->handler.name = "Surface Platform Profile"; > tpd->handler.profile_get = ssam_platform_profile_get; > diff --git a/include/linux/surface_aggregator/device.h b/include/linux/surface_aggregator/device.h > index 8cd8c38cf3f30..6a72b5bdc8782 100644 > --- a/include/linux/surface_aggregator/device.h > +++ b/include/linux/surface_aggregator/device.h > @@ -164,6 +164,7 @@ enum ssam_device_flags { > * @dev: Driver model representation of the device. > * @ctrl: SSAM controller managing this device. > * @uid: UID identifying the device. > + * @tpd: Platform profile device data. > * @flags: Device state flags, see &enum ssam_device_flags. > */ > struct ssam_device { > @@ -171,6 +172,7 @@ struct ssam_device { > struct ssam_controller *ctrl; > > struct ssam_device_uid uid; > + struct ssam_platform_profile_device *tpd; > > unsigned long flags; > };