From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77AF9C001E0 for ; Mon, 23 Oct 2023 09:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232517AbjJWJBo (ORCPT ); Mon, 23 Oct 2023 05:01:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbjJWJBl (ORCPT ); Mon, 23 Oct 2023 05:01:41 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A07D6B for ; Mon, 23 Oct 2023 02:01:37 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-32da4ffd7e5so1687882f8f.0 for ; Mon, 23 Oct 2023 02:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent.com; s=google; t=1698051696; x=1698656496; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mf+nKan86pP9YxvqNtFB3ioqbhRgtPm5GTm7s8KJe0I=; b=QWfXkwqLCedWOyUHj73NFxHU0uVI8X9lDly8xxsv/mWpNgdxIkSjrHEtMvSVOGLohX tjhuVyngYNeVeyhQ3yfLJXiT+G559gciUv9pwrF8aslWiX/v3zcgGcp/LQr/rmDeqsVE G+O1144nSgElor2Df5Fb336SW5g8+FKdreYn5UgSldu/i1Xwd3h3gx0fJqRbjQmUwklp sYm4vYigJ91xTgSJtC4fKGwKdTPAWf88dn8QGoZgTho7g5yHbnkYAInNlshLLVxTuMqa 3SwbfNthaALXa6MTU0S8Sa7P7uVRNJzWyyBLEqQ2HpZQ4URtdTs61RHwS3bqHqbhrxnj R3vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698051696; x=1698656496; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mf+nKan86pP9YxvqNtFB3ioqbhRgtPm5GTm7s8KJe0I=; b=OrjjosbAppkZG3Tj3pJb1NBF9+gjmmfokxZJ+FrAVXst35GqTJVfi6JMBeT848Gn8a xG1UOdc8ZBQtev18d+7j/QGGi8PpkSgzai9jjYaao1pkddZzf7xT8PnKaQGEjnqnAeRe DjNEL6x+54juiYD84pnIqgKj645e3abu2jsIQfXBil19qDaiO7mU55dn4YCXjE0gA495 enmNTUEsd8qFkTnt1KLidQpPcEi/5I+6YYV+TEgPuekwAYWW8RrHwbjWFMa5bIN1F22L bdrkvA0PV+JSnbiwxj0dc5gFygrzD/fGn6p+lQg+wvw9A/kytHgFZG5boPtSm6mFDU65 qlvw== X-Gm-Message-State: AOJu0YyKB3TU09d3MKcOSsmd/HHnd//7tafMj3uL3kYzgUFdornD+uxs wxuO/tFnL8t8D8qnobX8CN4Gpg== X-Google-Smtp-Source: AGHT+IGpWjcofGaS/GHzmAITo9rLeiMobJbEAZDzaHpa22JV7SGE2SfbIE4YVP8+tHl7DnA+Q7wPRA== X-Received: by 2002:adf:e487:0:b0:32d:84a5:bf5f with SMTP id i7-20020adfe487000000b0032d84a5bf5fmr7402288wrm.28.1698051695873; Mon, 23 Oct 2023 02:01:35 -0700 (PDT) Received: from ?IPV6:2a02:8011:e80c:0:68fb:b41e:9c58:360c? ([2a02:8011:e80c:0:68fb:b41e:9c58:360c]) by smtp.gmail.com with ESMTPSA id k17-20020a5d66d1000000b00327cd5e5ac1sm7371699wrw.1.2023.10.23.02.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 02:01:35 -0700 (PDT) Message-ID: <435424a7-efba-4438-917c-61823c374770@isovalent.com> Date: Mon, 23 Oct 2023 10:01:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] perf parse-events: Remove BPF event support Content-Language: en-GB To: Manu Bretelle , Arnaldo Carvalho de Melo Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Fangrui Song , Anshuman Khandual , Andi Kleen , Leo Yan , Madhavan Srinivasan , Carsten Haitzler , Ravi Bangoria , "Naveen N. Rao" , Athira Rajeev , Kan Liang , Yang Jihong , James Clark , Tiezhu Yang , Eduard Zingerman , Andrii Nakryiko , Yonghong Song , Rob Herring , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev, Wang Nan , Wang ShaoBo , YueHaibing , He Kuang , Brendan Gregg References: <20230810184853.2860737-1-irogers@google.com> <20230810184853.2860737-2-irogers@google.com> From: Quentin Monnet In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/10/2023 23:37, Manu Bretelle wrote: > On Fri, Oct 20, 2023 at 05:39:25PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Thu, Oct 19, 2023 at 03:48:56PM -0700, Manu Bretelle escreveu: >>> On Thu, Oct 19, 2023 at 06:08:33PM -0300, Arnaldo Carvalho de Melo wrote: >>>> I wonder how to improve the current situation to detect these kinds of >>>> problems in the future, i.e. how to notice that some file needed by some >>>> Makefile, etc got removed or that some feature test fails because some >>>> change in the test .c files makes them fail and thus activates fallbacks >>>> like the one above :-\ >> >>> I think it is tricky. Specifically to this situation, some CI could try to build >>> the different combinaison of bpftool and check the features through the build >>> `bpftool --version`. >> >> Right, if the right packages are installed, we expect to get some >> bpftool build output, if that changes after some patch, flag it. Correct, this is what we do on the CI on the GitHub mirror (checking that the mirrored version builds correctly, with the expected features). >> >> Does bpftool have something like: >> >> ⬢[acme@toolbox perf-tools-next]$ perf version --build-options >> perf version 6.6.rc1.ga8dd62d05e56 >> dwarf: [ on ] # HAVE_DWARF_SUPPORT >> dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT >> syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT >> libbfd: [ OFF ] # HAVE_LIBBFD_SUPPORT >> debuginfod: [ on ] # HAVE_DEBUGINFOD_SUPPORT >> libelf: [ on ] # HAVE_LIBELF_SUPPORT >> libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT >> numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT >> libperl: [ on ] # HAVE_LIBPERL_SUPPORT >> libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT >> libslang: [ on ] # HAVE_SLANG_SUPPORT >> libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT >> libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT >> libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT >> zlib: [ on ] # HAVE_ZLIB_SUPPORT >> lzma: [ on ] # HAVE_LZMA_SUPPORT >> get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT >> bpf: [ on ] # HAVE_LIBBPF_SUPPORT >> aio: [ on ] # HAVE_AIO_SUPPORT >> zstd: [ on ] # HAVE_ZSTD_SUPPORT >> libpfm4: [ on ] # HAVE_LIBPFM >> libtraceevent: [ on ] # HAVE_LIBTRACEEVENT >> bpf_skeletons: [ on ] # HAVE_BPF_SKEL >> ⬢[acme@toolbox perf-tools-next]$ >> >> ? >> > > It has > > $ ./tools/bpf/bpftool/bpftool --version -j | jq .features > { > "libbfd": false, > "llvm": true, > "skeletons": true, > "bootstrap": false > } > > > Maybe Quentin knows of something else. This, or ldd on the binary (unless it was a static build). But "bpftool version" should be enough to tell whether the LLVM disassembler is built in or not, so we haven't needed something else so far. Quentin