From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbcFNGkP (ORCPT ); Tue, 14 Jun 2016 02:40:15 -0400 Received: from gloria.sntech.de ([95.129.55.99]:33403 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbcFNGkN (ORCPT ); Tue, 14 Jun 2016 02:40:13 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: weiyj_lk@163.com Cc: Kishon Vijay Abraham I , Wei Yongjun , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe() Date: Tue, 14 Jun 2016 08:39:57 +0200 Message-ID: <4354296.6MbJoqdM2Z@diego> User-Agent: KMail/4.14.10 (Linux/4.5.0-2-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1465860707-26005-1-git-send-email-weiyj_lk@163.com> References: <1465860707-26005-1-git-send-email-weiyj_lk@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk@163.com: > From: Wei Yongjun > > In case of error, the function devm_kzalloc() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. > > Signed-off-by: Wei Yongjun obviously correct, thanks for catching. Reviewed-by: Heiko Stuebner