Re: [PATCH v7 0/2] phy: Add USB PHY support on Intel LGM SoC

["Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>]

Hi Andy,

On 27/7/2020 7:09 pm, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 1:08 PM Ramuthevar,Vadivel MuruganX
> <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>>
>> The USB PHY provides the optimized for low power dissipation while active, idle, or on standby.
>> Requires minimal external components, a single resistor, for best operation.
>> Supports 10/5-Gbps high-speed data transmission rates through 3-m USB 3.x cable
>> ---
> 
>> v7:
>>    - No Change
> 
> I guess it's not the correct changelog entry.
> You moved file to another subsystem, didn't you?

Already added in v5 changelog, kindly please see below , Thanks!

> 
>> v6:
>>    - No Change
>> v5:
>>    - As per Felipe and Greg's suggestion usb phy driver reviewed patches
>>      changed the folder from drivers/usb/phy to drivers/phy
>>    - Reviewed-By tag added in commit message
>> v4:
>>    - Andy's review comments addressed
>>    - drop the excess error debug prints
>>    - error check optimized
>>    - merge the split line to one line
>> v3:
>>    - Andy's review comments update
>>    - hardcode return value changed to actual return value from the callee
>>    - add error check is fixed according to the above
>>    - correct the assignment in redundant
>>    - combine the split line into one line
>> v2:
>>    - Address Phillip's review comments
>>    - replace devm_reset_control_get() by devm_reset_control_get_exclusive()
>>    - re-design the assert and deassert fucntion calls as per review comments
>>    - address kbuild bot warnings
>>    - add the comments
>> v1:
>>    - initial version
>>
>> ---
>> dt-bindings: usb: Add USB PHY support for Intel LGM SoC
>> v7:
>>    - Fixed the bot issue: usb-phy@e7e00000: '#phy-cells' is a required property
>> v6:
>>    - Fixed the bot issue.
>>    - replace node-name by usb-phy@ in example
>> v5:
>>    - Reviewed-By tag added
>> v4:
>>    - No Change
>> v3:
>>    - No Change
>> v2:
>>    - No Change
>> v1:
>>    - initial version
>>
>>
>> Ramuthevar Vadivel Murugan (2):
>>    dt-bindings: phy: Add USB PHY support for Intel LGM SoC
>>    phy: Add USB3 PHY support for Intel LGM SoC
>>
>>   .../devicetree/bindings/phy/intel,lgm-usb-phy.yaml |  58 +++++
>>   drivers/phy/Kconfig                                |  11 +
>>   drivers/phy/Makefile                               |   1 +
>>   drivers/phy/phy-lgm-usb.c                          | 278 +++++++++++++++++++++
>>   4 files changed, 348 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml
>>   create mode 100644 drivers/phy/phy-lgm-usb.c
>>
>> --
>> 2.11.0
>>
> 
>