From: "Antonino A. Daplas" <adaplas@gmail.com>
To: 7eggert@gmx.de
Cc: Pozsar Balazs <pozsy@uhulinux.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix vgacon blanking
Date: Fri, 21 Oct 2005 08:17:10 +0800 [thread overview]
Message-ID: <43583386.6070400@gmail.com> (raw)
In-Reply-To: <E1EShsL-0000tJ-Fr@be1.lrz>
Bodo Eggert wrote:
> Pozsar Balazs <pozsy@uhulinux.hu> wrote:
>
>> This patch fixes a long-standing vgacon bug: characters with the bright
>> bit set were left on the screen and not blacked out.
>> All I did was that I lookuped up some examples on the net about setting
>> the vga palette, and added the call missing from the linux kernel, but
>> included in all other ones. It works for me.
>
> This is strange, since according to my documentation, the value should have
> been initialized to 0xff and never been changed. Can you test setting this
> value during initialisation (around line 259, if I read correctly) instead?
> I don't know if I can test it myself soon enough.
Actually, I don't see the palette mask (0x3c6) set anywhere in vgacon. The code
in line 259 sets the first 16 entries of the internal palette (0x3c0: 0x0-0xf)
so it points to the first 16 entries of the DAC.
Tony
next prev parent reply other threads:[~2005-10-21 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4ZLja-4gH-5@gated-at.bofh.it>
2005-10-20 21:23 ` Bodo Eggert
2005-10-20 21:54 ` Pozsar Balazs
2005-10-21 0:17 ` Antonino A. Daplas [this message]
2005-10-20 16:13 Pozsar Balazs
2005-10-20 20:27 ` Bob Copeland
2005-10-21 0:01 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43583386.6070400@gmail.com \
--to=adaplas@gmail.com \
--cc=7eggert@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pozsy@uhulinux.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome