From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD8B9C54EE9 for ; Fri, 16 Sep 2022 04:16:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229608AbiIPEQz (ORCPT ); Fri, 16 Sep 2022 00:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbiIPEQv (ORCPT ); Fri, 16 Sep 2022 00:16:51 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE339F747; Thu, 15 Sep 2022 21:16:50 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B3D845C0082; Fri, 16 Sep 2022 00:16:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 16 Sep 2022 00:16:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1663301809; x= 1663388209; bh=hjMcp89C2jkXIYsBxRnx/xoB4u1WmalrxLV/Xe3flCk=; b=m DBiIIiCyDyFeVeQm3ja9dS8EX6NCDF9tzHhW8DHE09A7U3kAckcnhqzJicrEhrrt 8vv7t7QuSRe/U1OTpQWipnepf/O9GA+6tNblM8XGeQaxyU0eZa+PZZqvmTVQsxeL k2kVgGikUoWx10lU1UOmd4wrUeQXGGuN0Rd9wjmT+G30KzjRKlBDP3XEaLr/2zCb tho4/T47Y7J2TtT1SB/Vy8yAzd6zIHeSBVBRzL108Gg9r2kUvmC3sI/pZWt+Sztc /lTvzc5SJuVYhnXjnqsvSD2bL7QNjNmCghLOdCTSIyn+sQQH1KwnG6dr9PDHV6yN PGJMUz8XQam13QdK7Q5UQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663301809; x= 1663388209; bh=hjMcp89C2jkXIYsBxRnx/xoB4u1WmalrxLV/Xe3flCk=; b=C CYWWIVEE4m7VNW7jhFBd1UIjfS1EslnN1EGBqP4+EgN4Z9hGnYPeKhiBAimVwVkW r8mbXSfdg2aFESQ9CpvZ3G1GGHKoeEPxbCuhBEaIj0xoT1oPI9G38cTLmg14VUqn X+hO4XoBd0+op2WAj7yqtRVMl9Q0UyNOrO1Ez7FeH6pAKftfwRWjvtVt8shqriUw yXj0uz+qiZ0j/B58Nvs0Ib+YIYqMDVHcLy7Or+YHDfKcNSftldjHwVROafz5DicP IoF0pJO74a6/I2Cpw1c1pwTeUJ+em3BRXqtnPVEIKRAHfYl9CvedWXN+cw0rFXG9 lW0G4oDobqJZBxK7SbJvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduledgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfvfevfhfhufgjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpeejgfffhfdujeeftdeuudeguedttefgieetffffheejuefguedv heejteeftdfftdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 00:16:48 -0400 (EDT) Message-ID: <4358760c-92b1-f77e-9bed-42e647afbc3e@sholland.org> Date: Thu, 15 Sep 2022 23:16:47 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: wens@csie.org Cc: Lee Jones , Linus Walleij , "open list:GPIO SUBSYSTEM" , devicetree , Krzysztof Kozlowski , Rob Herring , Bartosz Golaszewski , linux-kernel , Jernej Skrabec , linux-sunxi@lists.linux.dev References: <20220621034224.38995-1-samuel@sholland.org> <20220621034224.38995-5-samuel@sholland.org> From: Samuel Holland Subject: Re: [PATCH v2 4/4] ARM: dts: axp22x/axp809: Add GPIO controller nodes In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/26/22 08:03, Chen-Yu Tsai wrote: > On Tue, Jun 21, 2022 at 11:42 AM Samuel Holland wrote: >> >> These PMICs all contain a GPIO controller. Now that the binding is >> documented, wire up the controller in the device tree. >> >> Signed-off-by: Samuel Holland >> --- >> >> (no changes since v1) >> >> arch/arm/boot/dts/axp22x.dtsi | 18 ++++++++++++++++++ >> arch/arm/boot/dts/axp809.dtsi | 19 +++++++++++++++++++ >> 2 files changed, 37 insertions(+) >> >> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi >> index a020c12b2884..5c233c84be92 100644 >> --- a/arch/arm/boot/dts/axp22x.dtsi >> +++ b/arch/arm/boot/dts/axp22x.dtsi >> @@ -67,6 +67,24 @@ battery_power_supply: battery-power { >> status = "disabled"; >> }; >> >> + axp_gpio: gpio { >> + compatible = "x-powers,axp221-gpio"; >> + gpio-controller; >> + #gpio-cells = <2>; >> + >> + /omit-if-no-ref/ >> + gpio0_ldo: gpio0-ldo-pin { >> + pins = "GPIO0"; >> + function = "ldo"; >> + }; >> + >> + /omit-if-no-ref/ >> + gpio1_ldo: gpio1-ldo-pin { >> + pins = "GPIO1"; >> + function = "ldo"; >> + }; >> + }; >> + > > We have > > reg_ldo_io0: ldo-io0 { > pinctrl-names = "default"; > pinctrl-0 = <&gpio0_ldo>; > /* Disable by default to avoid conflicts with GPIO */ > ... > } > > in axp81x.dtsi . Should we add it here and for axp803.dtsi as well? Actually, I don't think these pinctrl nodes should exist at all. The regulator already sets the pinmux, because that is the only way to turn the regulator on/off. So I think we should leave it alone here. Regards, Samuel > Otherwise, > > Reviewed-by: Chen-Yu Tsai