From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB5D72EDD6B for ; Mon, 25 May 2026 17:19:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779729570; cv=none; b=AHDitCyGIiLm5gS9tdGzFSmUVcBGLXS3esds0MZJtddV3owZdyg7heVmEEOPCvPoWwQ1L29YfsY3rwxikWDLKTfA/BfZ2k5MWwmUDuYNvc3DniPh5aTX1aCqs0uanFwftd0aohH1+quDc64UdSaIswd358eNOkhaWijsyOeUTCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779729570; c=relaxed/simple; bh=zkiXMJywtjomH4ExA3n9dnkhW7Al5fabmbNNmU6ozYc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V7zk23G4IIBLyFv5s1TblQ+mAIiSP2RDOCdQzSDxVehbqgyUOlpL5uIjRQ1xidRmh55krXOJ1Z//PTJ4ZrZ/39CKa+XuXRHPSMXEmWBlHDSF3B73OF5jstLIQWbW8PIofHxpQ7H1wILSYOf3x5z8h/VDcyvnVr7D+KqrNiAW100= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H9LzIX3l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RQCCLneE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H9LzIX3l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RQCCLneE" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64PBPWaP3263566 for ; Mon, 25 May 2026 17:19:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rUOvn3MZp/wvYfz05jfdn7SBbQ984RFb/LCTbznHnzs=; b=H9LzIX3lQ6ZM9Mkf BO71saemv1DolZfqttLvgjY5Wlr36zPWYk7fR2jjsjQy2DNFU22czPFlygWhBlCi xs37o3MICpASRq0bma/0zeCFFMXeuUNitzX24vsEHpGm+tuDkXl8kPi2u8FynyDq LWQV6CkEDW7w0tvdxzMN7gxEfYDUSf/sA8/ufgTdv0G6QMiwQ03maFMpNhdmeA3g mJIBzNw5UIxlPiJubERRK7LUDqFKdeROatQ2CM6kmkIR5COb1IQ90dgkWkMGpCDR /1Rl5dQdK2V9/fNrMdf1wuHXIeYOQZcF7AoVkbNTYJyWC2ofThXkr0KqLm4rLXS8 B4aPJQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ecnhs14nm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 17:19:27 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c828cee4fcdso4627586a12.3 for ; Mon, 25 May 2026 10:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779729567; x=1780334367; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rUOvn3MZp/wvYfz05jfdn7SBbQ984RFb/LCTbznHnzs=; b=RQCCLneELZ4gKaQ495slG4BRL3NDQBXmwfFdoyv94ZnClPd0GZ+N/NWH6sO0zBV0aK dfIlidfDc0Ptz1m1LnRUcAd8TxiWrq/HVm1jyTvhMZPhveEj6QkJ0gQaX6AL2ABXwXvr GI7CuQD+XWPfNoWonfTksGPgEvxs+/W21OBE3C9OGJAgwaSlYliSa3nwy4Ny4+iwFpW/ zIp/adEiwuOW3pglhAyaSrYO3zp1iNjM29NdDfyl8FR6YV53JtswBCFHU6V2LNeJH57d gklLAPQDzvVjQNdhVh9Q0jYMPNYdXw7TF2cNVuu2axPYah/FGlc/VqMOdx0ZTxJ9xQDT Y0Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779729567; x=1780334367; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rUOvn3MZp/wvYfz05jfdn7SBbQ984RFb/LCTbznHnzs=; b=C7ur1AbXt2Iu5voIxcLXExQeb8DdROVXluManGmklx64EJGgm7dOcX7Pt+S4eWgPes Y3AYtvONGtEAFzG2KmjSyekTvvp1mNshZAzBVQiSrN645KDqQyOw3QYtxbOl2PNBhmai Pi1hRFlF2SMSsA0wcNjOZj48uYdzOOsltFyaxSxdZGkr48dMcwvLy6m0KC+V1XWogwjT 5XbcJUWGc1sjXn0TJS64Nu5HleMEMXy+mVn1HSLN3vOmxyOAOhnznbpH+b7aGllAvYl0 lpeIabTpRAdp+hDoNLJOdoecGPSWmzwvdMP6tjdTMJCaJ+MA8eY8T5n/HuCl9VFowOQg UesQ== X-Forwarded-Encrypted: i=1; AFNElJ8g6ti75ESZ8VbHHCBJxCgPynJPN7t9S984c6OChgG4/Conz6CP810qvGHegmoOdHIzGcE/Mv0qXXatEyc=@vger.kernel.org X-Gm-Message-State: AOJu0YwKKDktWotEmTSXX0rDwy+UE7GRekFSn5/mAjz7uSwvby0zIb+U SoIfpYXotDN1q8qaVMP+AUPRIluqi6qt4+ohVFmJvhvj0jEI9kZmWOzPJSRh8oKClRNsg38dudV 9a5SObUi4YYAiIAjdLHi4I0O4o0pqhV88SO8o4w8sFrO5x0IWkzKcp2e5/Irml3poprE= X-Gm-Gg: Acq92OHC7hmcBHag1uDE5D4Ob62BwpLQ49GWc+d2gafiUCeagOUpQQuylq3Cu7FyriD k/jBTY09kSVRH5cZuMhP5QeKT+65kbAysoaPTgN2gjFfmOom4iipSVmn4P1FSLloi58hORaw8ep pMc0EQSL2ZgZlMQRDTJSGbnchSoha6876LGC5e7vMv0uXHf/6h+97RjXKPqQnhJb7y5myG8qnY7 t1nTfijC6BzU/32b6l61yQkojvUrKxaWBXJdFFZQW5AeN8HiJfjdpF7i6VR1L9PUzJ1SWSinLcg nQ6dyPVi96pTZJAcTc2qPywYQ7x5B4FqwqhGY81YEOs6lvUDubGs4JzqK3eNpqyXKvfQJVm7wo9 6etD+GmCcGGFpW7G0x2HOJtO1ihyJYEx9TOsmKV3RSiM5xiQcZkK1Fwc6Z8HPcst5 X-Received: by 2002:a05:6a00:2d8c:b0:838:9e25:f128 with SMTP id d2e1a72fcca58-8415f32f29dmr14561534b3a.26.1779729566587; Mon, 25 May 2026 10:19:26 -0700 (PDT) X-Received: by 2002:a05:6a00:2d8c:b0:838:9e25:f128 with SMTP id d2e1a72fcca58-8415f32f29dmr14561519b3a.26.1779729566092; Mon, 25 May 2026 10:19:26 -0700 (PDT) Received: from [192.168.1.6] ([122.164.82.72]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164ea09a9sm11481158b3a.31.2026.05.25.10.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 10:19:25 -0700 (PDT) Message-ID: <4358d0b5-48ae-49f2-a50c-115a54958505@oss.qualcomm.com> Date: Mon, 25 May 2026 22:49:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260525-ipq5424_drop_clk_ignore_unused-v1-1-7ec63e347f2a@oss.qualcomm.com> <005d1637-ec56-4f4e-be99-04386efc2524@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vd3H+lp9 c=1 sm=1 tr=0 ts=6a14849f cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=oxN+qIFH97EF7WOLwtTw/A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=3oT0bc5pQZFKanLxOPEA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: Vf_lOlHSFtAy2RJ2aqxGqJi-Dsr0zhd1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDE3NCBTYWx0ZWRfX6/keUAT4tzWR SnIs4wxzV6IADtlZjxdMzrLaGpUw4xf7OeHe9jX/6FjrPg/CZxos40hxwuQ2arAkLgbLdOIOZKu ibNfwAnOIBhKqCo47m21EUjpnwkZuFGu2Ol/ikHDfO8R7pMR9/fPAEV2ums0cL02u3ATaOg3P6u 1uWCyV9RnY8/QpHyDkOi2i5SDAoTB6d/Q6x9sY52mNsCM59MywM1KeWTXi7oxcmcoCoHgEkvHPJ qvHrh17li37dfi4XV6gtTNdl6Ow41anCTvmo6BfQjJ6wu97HTGNv76ShTAAbbkyq7krnQK7ZTP1 AboxZUb5FAy+HrW/HiUJ4gLZMCjnqBbRZ6fYuhPS4QeXPoYP6URGnRSnHriqsIFE5tM0ej3iWT9 jtMnEpC+3Gr6Rez/FToVKv6jgQdwDjCGFGtlBsBMQTG+6cbXRccMBTSBjcaClWHTSy4g8Tb3j50 bOkRJQ82pBiiovNdt1g== X-Proofpoint-ORIG-GUID: Vf_lOlHSFtAy2RJ2aqxGqJi-Dsr0zhd1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_05,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250174 On 5/25/2026 8:55 PM, Dmitry Baryshkov wrote: > On Mon, May 25, 2026 at 08:35:16PM +0530, Kathiravan Thirumoorthy wrote: >> On 5/25/2026 3:39 PM, Dmitry Baryshkov wrote: >>> On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy wrote: >>>> Now that Linux has the consumer for the GPLL4, drop the >>> what is the consumer? When was it added? >> PCIe and USB are the major consumers, which got added with the below commits >> and landed in v6.16 and v6.14 respectively. >> >> ab7f31a3830d ("arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller >> nodes") >> >> 113d52bdc820 ("arm64: dts: qcom: ipq5424: Add USB controller and phy nodes") >> >> While I was revisiting the code found that this flag is not removed. Hence I >> sent this. >> >> Shall I reword the commit message as below for the next spin? >> >> -- >> >> Since PCIe and USB are enabled and consume GPLL4, there is no need to >> keep the CLK_IGNORE_UNUSED flag. Drop it. > Yes, it would be perfect. BTW: what happens if both are disabled (or not > probed at the boot time)? Until all the drivers probed, icc_sync_state() will not disable the ICC clocks which will in turn keep GPLL4 in ON state. If we disable the nodes, then system will go for the reboot without much information. > >