From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932335AbdCIOlJ (ORCPT ); Thu, 9 Mar 2017 09:41:09 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:12854 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbdCIOlG (ORCPT ); Thu, 9 Mar 2017 09:41:06 -0500 Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() To: Greg Kroah-Hartman References: <20170308121943.29340-1-vigneshr@ti.com> <20170308123417.GA3981@kroah.com> CC: Jiri Slaby , , , From: Vignesh R Message-ID: <435d73f7-d057-631b-8d00-8639d764414f@ti.com> Date: Thu, 9 Mar 2017 20:07:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170308123417.GA3981@kroah.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday 08 March 2017 06:04 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 08, 2017 at 05:49:43PM +0530, Vignesh R wrote: >> Passing "serial" as name during request_irq() results in all serial port >> irqs have same name. This does not help much to easily identify which >> irq belongs to which serial port instance. Therefore pass dev_name() >> during request_irq() so that better identifiable name is listed for >> serial ports in cat /proc/interrupts output. >> >> Output of cat /proc/interrupts >> Before this patch: >> 26: 689 0 GICv2 309 Edge serial >> After this patch: >> 26: 696 0 GICv2 309 Edge 2530c00.serial >> >> Signed-off-by: Vignesh R > > I need a "full" name here, unless you really do sign legal documents > with just one letter as a last/sur-name? > Its perfectly alright not to expand surname here in India. FWIW, my ID cards also have the same name. I have been contributing to the kernel with above Signed-off-by line in the past and would want to continue to use the same. -- Regards Vignesh