From: James Smart <james.smart@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>, Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lpfc: nvmet_fc: fix format string
Date: Mon, 29 May 2017 16:02:20 -0700 [thread overview]
Message-ID: <4367de5c-9778-a48c-f37e-0fbde57f3f15@broadcom.com> (raw)
In-Reply-To: <20170519080447.1043039-1-arnd@arndb.de>
Patch is fine.
Signed-off-by: James Smart <james.smart@broadcom.com>
-- james
On 5/19/2017 1:04 AM, Arnd Bergmann wrote:
> The lpfc_nvmeio_data() tracing helper always takes a format string and
> three additional arguments. The latest caller has a format string with
> only two integer arguments, causing this harmless warning:
>
> drivers/scsi/lpfc/lpfc_nvmet.c: In function 'lpfc_nvmet_xmt_fcp_release':
> drivers/scsi/lpfc/lpfc_nvmet.c:802:25: error: too many arguments for format [-Werror=format-extra-args]
> lpfc_nvmeio_data(phba, "NVMET FCP FREE: xri x%x ste %d\n", ctxp->oxid,
>
> We could add a dummy argument here, but it seems reasonable to print
> the 'abort' flag as the third argument.
>
> Fixes: 19b58d9473e8 ("nvmet_fc: add req_release to lldd api")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
next prev parent reply other threads:[~2017-05-29 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 8:04 Arnd Bergmann
2017-05-20 10:28 ` Joe Perches
2017-05-20 19:10 ` Arnd Bergmann
2017-05-21 0:43 ` Joe Perches
2017-05-24 2:36 ` Martin K. Petersen
2017-05-29 23:02 ` James Smart [this message]
2017-06-01 2:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4367de5c-9778-a48c-f37e-0fbde57f3f15@broadcom.com \
--to=james.smart@broadcom.com \
--cc=arnd@arndb.de \
--cc=dick.kennedy@broadcom.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®