From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE56947042D for ; Fri, 28 Aug 2026 14:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787928062; cv=none; b=ECRjYFGPSaneyvRhwIvwS574SnaPyGmLVQI6H7Ad0K469OxpLpNpQnjEHBQ1E60UizTOZhjUHfYLZl5JBQS6estjGhqwqkaZTrq93hjDelXPsfc8N8Qi1F5FCbPUaTwNPB53b3qxkaFWvIDRZqr+v3yFiSzI77BaKWs322My5wY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787928062; c=relaxed/simple; bh=Gp5cNpvqC7YnJtgTQ7as6KDz2NHZgVd+cRvOfbagt4M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mRfcfS6NuVOMtGuvXULJXFeztib2+xbSkA4iVCy1nXHRf3FpPEX5oxy2KWEDK7G+OAbKzrJTTcA70UX18tq4aDxp7rpmNiT7vRnL6Qlz7iMljK2WjhEexsb8zInCNkYztm8ylTVuEZL4hDWublaK9ibxIJGxl5NCT5SnBKWNBMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nOwr2w0C; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jEL16IB5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nOwr2w0C"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jEL16IB5" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67SDkdkN3279832 for ; Fri, 28 Aug 2026 14:40:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bOnsUsh8Wpvj84UUQA6eFNHOjYX12MlSNu7SoY1Zd+U=; b=nOwr2w0CXUmoTKuT hUt/J/AQUWqI7HpQzuuQIwfNcc00QVT88jHKRYBWipO/oYGa5hsQ5ZMwnD+CtEDt BNvfr+6hozp0aXCMwQw4HIFkYmw7smmiRf7ksjeBPKbg8mFSv7mNTnSlQhjh7Z6J U7g8E2sZdECdUNch279hX0bbGW4E4XMzoQfqVeOMIdiaXYYWPuvfVMtWVDqjcBEB 2ee0AD6EIEON/ds6iXB4N7+51/rrmeKoby6lGQQwbJYuYIeX5mZkNM8uOE4QS+cF BSmoVcYba+d9ecfbEgShY1o6YRbRoii1If6TSixgkB4QUdjtEJhJjpmrVu9BK7o0 bNWeKQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gb62h1q7u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Aug 2026 14:40:59 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cc640dfde3so13126155ad.1 for ; Fri, 28 Aug 2026 07:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787928058; x=1788532858; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bOnsUsh8Wpvj84UUQA6eFNHOjYX12MlSNu7SoY1Zd+U=; b=jEL16IB5/pcItpVVyD3o7Bjjjipcg1LsvtNbfXsN6+d0QD2NlXwLclBgAy4pyrWIhg cK029wJgvMJLMHre8NWJdK3ZzHFnVaJLimWtZI7KkWqYpq1WFKUnEKoebbzDmZkACZbt 5B2mcKI1MTtJUPPWxiDsKxVqT1Lm74o4VDX2kY8PHqZkFphTZHCtmohqUKSYCIvmL2tK fq6BHU4Gs8+hpfYgEoT5nfrrtTBni48UDfh4zsjO8imAlU1yG9ga1WYXS2pFBcyBEZUq RpT4PzoKGLhT8/U15HA9juMKPYu8MHRW69Wp8poC0+zu76KcW5el5LMUp3AO1fh3z5/W MM9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787928058; x=1788532858; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bOnsUsh8Wpvj84UUQA6eFNHOjYX12MlSNu7SoY1Zd+U=; b=N+gn5H6qGA1AnwszZq99wwFLtddGsJJDyiALC1mK8wmgCHG7u0zhTpmhmcexcphNJJ PFvBVPI0vIc/1Yqxaa726Puu5xoFCkwBCNntPes1sRy5K2eXe72wwsNSk1OwgI4MJT90 bFgomRkxh828EUWRQyLcVPsMq2a+fB7QhEe1hmzTGNCGaMJoaRNhD/flKZHPWAZ9ox78 r0znYrqJqCl8FrnBKHd1M0ZLf2sei5vXXFuaIeSsISl9XAhmFde61epeHNQnEQ3PbFTe PgNbFo6srk36IEwrsT76n2KSujfMQQgwhDsiA/yEmRJL/6HpO5uhTYJYnK1Aq/5z5JyN s6Fg== X-Forwarded-Encrypted: i=1; AHgh+Rr3T3+aZHqNStFa5dfAiJAHpDzLyjyWqBmnRgUcVQf/3dRZsdXWGtn7GnU1YUlQ5F0wbm5vRws1V5Jvods=@vger.kernel.org X-Gm-Message-State: AFuF++l5iQk/ykdqrlsuYsDzUI4WnAqYw74ft+QvPODI7uhOf+4WOQpG 0v3KKcahJwW4vkDuqGThEWDjmk3Jir/zp2ZKcTnAEJvJ5A4njb94mTKo9iKlTmWDdeH+XdTKZSb tx2hOwcMSFYEhsZIlVBmukRR0O+mfHBKvlLgOxrzgV38++Zi4bYx/RlJhJ/JylZB4Ie0= X-Gm-Gg: AR+sD13dKWK7u77oe5K/6g5s5wlE3gljrZrYNF9nFZrmbT+vwgSvI1+47VXR2tDRxTB JXkBv/zByLMEzAZ1wOieUCzCyiSG8QNojDhIOktDPsnGbWT5o8lZI2kgui6G40jhHhteUt19ua3 D7USp6KgJSDpLOTllufpOyTvliQ7c5WGfu9Z1bEY2mjgWkMS3xtYTegfb+hghX+SuBYdcZB11Oj WXLOoRB8U5+gB++OZ0z95LOhe/36OdC1bpU9CBiPkel/3ASiGobKvVVgRiEjmBbqBzufBiiGJuH V7vPGX+UY3XtWI7mG6dGgfL2ScvrKqos5oZggr0Vd2TC2TbOW2csGGpmb9RI7OWYD+NMV71eBE2 5E3gZSQ0eTsD7qPMaHgkS9nIzXs1KR0L4 X-Received: by 2002:a17:903:1ad0:b0:2d6:f9e2:af7f with SMTP id d9443c01a7336-2d74dca2148mr159874715ad.1.1787928058410; Fri, 28 Aug 2026 07:40:58 -0700 (PDT) X-Received: by 2002:a17:903:1ad0:b0:2d6:f9e2:af7f with SMTP id d9443c01a7336-2d74dca2148mr159873985ad.1.1787928057780; Fri, 28 Aug 2026 07:40:57 -0700 (PDT) Received: from [192.168.0.5] ([49.204.106.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d75986d2ebsm5934585ad.45.2026.08.28.07.40.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 07:40:57 -0700 (PDT) Message-ID: <4368e295-c734-41a2-8725-433525b3db90@oss.qualcomm.com> Date: Fri, 28 Aug 2026 20:10:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] serial: qcom-geni: Fix unbalanced runtime PM resume for no_console_suspend To: Abel Vesa , Greg Kroah-Hartman , Jiri Slaby Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20260828-serial-qcom-geni-fix-unbalanced-rpm-resume-v1-1-af3e5aef17a6@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <20260828-serial-qcom-geni-fix-unbalanced-rpm-resume-v1-1-af3e5aef17a6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI4MDEyNyBTYWx0ZWRfX2DTTQ54gBoZR hNnz+BxNvsa2B1JqVkxoWbg5+QD/NqH26m5M7EBqVl0d8IZ69t3MMxr+aJ/ivYxy6SDYntNRDz8 bgrQvHUOpCl+8C194yIN1k2ZUWDISU8= X-Proofpoint-GUID: fKtVW653Eos5MXaZYa_Czt1ZkWtNZvgj X-Proofpoint-ORIG-GUID: fKtVW653Eos5MXaZYa_Czt1ZkWtNZvgj X-Authority-Analysis: v=2.4 cv=I5dVgtgg c=1 sm=1 tr=0 ts=6a919dfb cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=JqI1KGPJ/fv+aVyoZTfG2w==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=D0tFkimwtIXZEwdZqEwA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI4MDEyNyBTYWx0ZWRfXyMpVZWkuWmwV rjqMQm9TDFfKygmvsoMwj1CYAVFQI3u6L/ExQOw0npPnDpRHuxWx3KNe+qGCkb1qB/snxd40y8K pvOGKICPS+BgFduVXEFF/0/W4dZGLvfo2OHivC3Eu+co6FJ8VXW4FBm/9w/Q1SSlMFDgprFBK9w Gy8UTu21VRJJxmw3DvYrEgijDKt1RHuPD+LziaZ+AE3YL68CAbyfcrCuURD/Qa1ad+utmRRsq+H 0YfVyXJCmHgFGgLOL3e5VAX+6rWMXIMVHic8mBAWh5UJo9POX/1RVaWMsyEmuhIn5z0NF+rH5vN U6Zgs0o4mUvrZ955CixH6uaXoXhyAZfjJ57QxRRjknPAA0Gmu33d5vFnLG2Dr9vC1Ter/Koa5w+ Hck0t/WU8kC7dxGc2Kx7tw56110Q10Ydd6xjRNyJndZmAQ6ykqYEnoCH+7rCiBLmUZh52kpAX5w SH9y24b8cL2MYC815Ag== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-28_04,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608280127 Hi On 28-08-2026 20:02, Abel Vesa wrote: > When no_console_suspend is set for the serial console, the system > suspend callback skips pm_runtime_force_suspend() to keep the console > active. The resume callback still unconditionally calls > pm_runtime_force_resume(), which triggers an "Unbalanced > pm_runtime_enable!" warning. > > Only force resume when the suspend callback force suspended the device. > > Fixes: d0cd9c8d0fd5 ("serial: qcom-geni: add force suspend/resume to system sleep callbacks") > Signed-off-by: Abel Vesa > --- > drivers/tty/serial/qcom_geni_serial.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 3633723acef8..a180a00c9e23 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -2099,9 +2099,11 @@ static int qcom_geni_serial_resume(struct device *dev) > struct uart_port *uport = &port->uport; > struct qcom_geni_private_data *private_data = uport->private_data; > > - ret = pm_runtime_force_resume(dev); > - if (ret) > - return ret; > + if (console_suspend_enabled || !uart_console(uport)) { > + ret = pm_runtime_force_resume(dev); > + if (ret) > + return ret; > + } Reviewed-by: Praveen Talari Thanks, Praveen Talari > > ret = uart_resume_port(private_data->drv, uport); > if (uart_console(uport)) { > > --- > base-commit: 3d83758432b5e6ed9507500a57efb0f3af41ee7d > change-id: 20260828-serial-qcom-geni-fix-unbalanced-rpm-resume-814e630326b9 > > Best regards, > -- > Abel Vesa >