From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbdEHVxq (ORCPT ); Mon, 8 May 2017 17:53:46 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34147 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbdEHVxp (ORCPT ); Mon, 8 May 2017 17:53:45 -0400 Subject: Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path To: Jon Mason , Florian Fainelli References: <1494280115-9252-1-git-send-email-jon.mason@broadcom.com> Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com From: Florian Fainelli Message-ID: <43692ac5-6db4-2ab1-737c-424be7db20f7@gmail.com> Date: Mon, 8 May 2017 14:53:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494280115-9252-1-git-send-email-jon.mason@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2017 02:48 PM, Jon Mason wrote: > If an error is encountered in mdio_mux_init(), the error path will call > mdiobus_free(). Since mdiobus_register() has been called prior to > mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This > causes a BUG_ON() in mdiobus_free(). To correct this issue, add an > error path for mdio_mux_init() which calls mdiobus_unregister() prior to > mdiobus_free(). > > Signed-off-by: Jon Mason > Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs") Acked-by: Florian Fainelli -- Florian