From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952AbdBCXBm (ORCPT ); Fri, 3 Feb 2017 18:01:42 -0500 Received: from 5.mo173.mail-out.ovh.net ([46.105.40.148]:48352 "EHLO 5.mo173.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbdBCXBi (ORCPT ); Fri, 3 Feb 2017 18:01:38 -0500 Subject: Re: [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug To: Jon Mason , David Miller References: <1486156133-5639-1-git-send-email-jon.mason@broadcom.com> <1486156133-5639-3-git-send-email-jon.mason@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hari Vyas From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <43694eda-e7fd-0df5-6bec-147770e04d5c@milecki.pl> Date: Fri, 3 Feb 2017 22:44:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1486156133-5639-3-git-send-email-jon.mason@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 18002858036235243246 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelgedrjedugdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2017 10:08 PM, Jon Mason wrote: > From: Hari Vyas > > ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to > bgmac_set_mac_address() but code assumed u8 *. This caused two bytes > chopping and the wrong mac address was configured. > > Signed-off-by: Hari Vyas > Signed-off-by: Jon Mason > Fixes: 4e209001b86 ("bgmac: write mac address to hardware in ndo_set_mac_address") I think you were going to Cc stable?