From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752997AbbKIQ3d (ORCPT ); Mon, 9 Nov 2015 11:29:33 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:64630 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752706AbbKIQ32 (ORCPT ); Mon, 9 Nov 2015 11:29:28 -0500 From: Arnd Bergmann To: John Garry Cc: JBottomley@odin.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxarm@huawei.com, john.garry2@mail.dcu.ie, hare@suse.de, xuwei5@hisilicon.com, zhangfei.gao@linaro.org Subject: Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization Date: Mon, 09 Nov 2015 17:28:46 +0100 Message-ID: <4369607.QVA3rBnZUm@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1447086757-147706-12-git-send-email-john.garry@huawei.com> References: <1447086757-147706-1-git-send-email-john.garry@huawei.com> <1447086757-147706-12-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:SXUZSJQL522aQ/ruq1I/l2+9AmKdqy7ZVuZLvNVxXsd3/6pAtPq eYov66Pp8mw9zQGlQmx6BSmq+g0pPbCsfgGEUNKOHf1TbymzJ5ZPlgdnncENIFNCUSyf1TF sRLyfAita8JFwuepvJrVA2ALRYWTRAjlLaPnLE6DjGWsy5DHNnb0h2E67p/+dyIOUqZRIp4 kj3AW9HCygPDsPCK+E1bQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:LnlH5CDTOis=:7/TA+jwqvMAcpruDJvnVBz BsX7o6INrQPj0aeYFddL1vUoILyUgI2UIQslfyhbawFMp8KPTi48GvclQn/9NFQ4SKjDFhF2x pNGxy7Uv9zVmXQhbp2Jaegikp0DUHkcdKFWzSLUzgJSEADgOxj4Sy39UcqPM7T6uYVurm0meu rlNg6e/Pht2iB4+vfAXkuwPPYIrePYWeSk3jJ6GQnDduYGsN1O4mI+iz2D7FFcmMPefTRt6hj HPZDzx9VKBwLTQVCk1Ng3ywDlBxJ2eda4q+r3folcYTeRX1/MyZIvN+9S3XEmHpASs38ONKDR 52mEjLvSilWflmV65fzFuQi0Rf+KBDrpqtSCz6LslJpbN/ezActxYRAlhCh6imdzeaVbAgZSy VvcR379gTczUdPGXhD4iTgTWJ7Ft3wAV5Grdc61uBGWnMX7x73UaFMxMlNjY6Xot+us749ogz bRykL9PrOxB1KYxflNpPDKiyUz/ZTxdPbCkoEcOEmPCXia9Pn6D66ueBqQemgEQCVujlf/x0y TFskHO3fBExHJgkP/t6snRbXLCkxk+CivmKzLY/NMyiyzeVEAJ4odJR6AtQOPF4qRT0cRznTX ujpwLMei/rib1HRB+BgTQ9WrLcFXnFiAxSj7Ruw5GufKT3HlfYj9JxYjXmuz6X/8vpNl/Q77v 2qoxRk0U3MsX36q0r+LZKkjB0TBntxF3WGrqpEg8DIiKGZHg4cLjR9kJWqBg+WoNSOIUhUPo2 N8lKmlt6Z1pUYDuA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 November 2015 00:32:16 John Garry wrote: > } > > +static void hisi_sas_init_add(struct hisi_hba *hisi_hba) > +{ > + int i; > + > + for (i = 0; i < hisi_hba->n_phy; i++) > + memcpy(&hisi_hba->phy[i].dev_sas_addr, > + hisi_hba->sas_addr, > + SAS_ADDR_SIZE); > +} I don't know the background here, but I thought it would have to be a different address on each phy. Are you sure this is not the case? Arnd