mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: "Andreas Kleen" <ak@suse.de>
Cc: <linux-kernel@vger.kernel.org>, <discuss@x86-64.org>
Subject: [PATCH] x86_64: fix page fault from show_trace()
Date: Mon, 07 Nov 2005 15:45:25 +0100	[thread overview]
Message-ID: <436F7695.76F0.0078.0@novell.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

The introduction of call_softirq switching to the interrupt stack
several releases earlier resulted in a problem with the code in
show_trace, which assumes that it can pick the previous stack pointer
from the end of the interrupt stack.

From: Jan Beulich <jbeulich@novell.com>

(actual patch attached)

[-- Attachment #2: linux-2.6.14-x86_64-call-softirq.patch --]
[-- Type: application/octet-stream, Size: 925 bytes --]

The introduction of call_softirq switching to the interrupt stack
several releases earlier resulted in a problem with the code in
show_trace, which assumes that it can pick the previous stack pointer
from the end of the interrupt stack.

From: Jan Beulich <jbeulich@novell.com>

--- 2.6.14/arch/x86_64/kernel/entry.S	2005-10-28 02:02:08.000000000 +0200
+++ 2.6.14-nlkd/arch/x86_64/kernel/entry.S	2005-11-07 14:56:02.000000000 +0100
@@ -1024,17 +1024,15 @@ ENTRY(machine_check)
 ENTRY(call_softirq)
 	CFI_STARTPROC
 	movq %gs:pda_irqstackptr,%rax
-	pushq %r15
-	CFI_ADJUST_CFA_OFFSET 8
-	movq %rsp,%r15
-	CFI_DEF_CFA_REGISTER	r15
+	movq %rsp,%rdx
+	CFI_DEF_CFA_REGISTER	rdx
 	incl %gs:pda_irqcount
 	cmove %rax,%rsp
+	pushq %rdx
+	/*todo CFI_DEF_CFA_EXPRESSION ...*/
 	call __do_softirq
-	movq %r15,%rsp
+	popq %rsp
 	CFI_DEF_CFA_REGISTER	rsp
 	decl %gs:pda_irqcount
-	popq %r15
-	CFI_ADJUST_CFA_OFFSET -8
 	ret
 	CFI_ENDPROC

                 reply	other threads:[~2005-11-07 14:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436F7695.76F0.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®