From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12FA20DC4 for ; Mon, 9 Sep 2024 15:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725896005; cv=none; b=t/5WHR2d7zYpjUcnR6o4I7blyhaF3rD2f+nMKPB491D07SLBhxqakAL0PL7b3+cgm5kb9dp11hZ4SMvKQ2I/mudVyc4ykWhjZiVXvpik+WF5M9gMSVRGOFKVAOYkdrtxx9vmxJTeOTW/CrCNwLYPVqdfpK/empFjexVpF6ozgs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725896005; c=relaxed/simple; bh=RQstpKYBysV0fJEEMraqxwfamzRl6MqPGS9YNkTUTmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YkHiM4V1cIP3M7La0tBnkfrkDb85yG3EKijuxsH2fIyzUF74Nf9p+cHdtjTHA1XGR/9+FAtcCNOfDDEtPkeOFo7L/Z4YIh1k4kzW6U3F9o4mCECLM8yJ4P0fdb42jsKjFNgFAtjD9bLaYlqw8TruaK46pDNcrTFJF0NskNG3J0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F73yS21D; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F73yS21D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725896002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=W4pNeMR/cD4qSUUyt8Fkj7gag9Lbiv2YrjkcbcuIMIs=; b=F73yS21DwNM7aygGYe6cuKdCxfMVp6TNC5eas4TBDNSc8pZylvwM45s8BM31mBPZ+NTPRm LfBRiemgJGiYfgrOer8N5iN6vdgtaQk6ikkwxtPQoZiw4dKYZYJq5O0EHuByMwLPZiirgf jOCDQGodSlk7PJu000TMeo8XoNMeCa4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-sd-GHo7gNPObwYXQfK1aZg-1; Mon, 09 Sep 2024 11:33:20 -0400 X-MC-Unique: sd-GHo7gNPObwYXQfK1aZg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb2c5d634so13697805e9.0 for ; Mon, 09 Sep 2024 08:33:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725895999; x=1726500799; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W4pNeMR/cD4qSUUyt8Fkj7gag9Lbiv2YrjkcbcuIMIs=; b=Eu4GCNaIRGWkPwXX+agQNFk8Xqa9hw8KNOPMWPNKsjGPwOWGTr8A73zx5+W6+qyJ2c sCZNufkUJolvtcMDZmTGZ3nEA3m8K+eXWSp2mtG+aYsS4S0WETcGjUQOuDzwDSVcTg35 bjRuldQPgPHAi+zEUHaIKO0pNwRR7FRdRaOKTwpa8yaTAJVRsqYWPR4tI9uQreKpaarl JoyC0v01c3Nfmm4zc3jVkeoncHWSsX5zya6oJJSlsgoVc84KiWBkGNqQZi8M10uRD7m/ oVErWwegbfNvlydsAKJ5fOYpu9zAas873qWE2IQ2gfTEobA8u1LbMkC8BY5usEGORQf0 hIMQ== X-Forwarded-Encrypted: i=1; AJvYcCXPSJs7tKmc4wN/SntKTWCje9EKGB7wycLCm83liJis24e+irPhMmoUoi8z722Zwovx70J8+l+jV5BJjq4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8wK0xCOSgNvpdkNWn5lG4F4Ain9Iw3r5ql/I+bz4P7runUtjv r1E+X8GPsRNa8evYXBmYyQVdWFvLXHzhd8AihQRshxaZkGYsizgUsyL6JDw4mwI26/KX8vt06aX xIRRWg6sNNxHlbYKVU1BYs2TF5t7NuHAD93ACoiidAcJ6wo2viCcAO8QnW/mGQg== X-Received: by 2002:a05:600c:1f8c:b0:42c:b6db:4270 with SMTP id 5b1f17b1804b1-42cb6db448cmr28843875e9.11.1725895999646; Mon, 09 Sep 2024 08:33:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGaj3y8JQ3aF22TN52GILlj8S4cIebL43Sb8l1rA7fdsZWasSFPvXBy3m4SBuHYEF4OlFNLAg== X-Received: by 2002:a05:600c:1f8c:b0:42c:b6db:4270 with SMTP id 5b1f17b1804b1-42cb6db448cmr28843645e9.11.1725895999136; Mon, 09 Sep 2024 08:33:19 -0700 (PDT) Received: from [192.168.10.81] ([151.95.101.29]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-42caeb8afc9sm80727185e9.44.2024.09.09.08.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2024 08:33:18 -0700 (PDT) Message-ID: <436b8525-e4be-4c1e-b2e4-2e4356379cc4@redhat.com> Date: Mon, 9 Sep 2024 17:33:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/21] KVM: TDX: Set per-VM shadow_mmio_value to 0 To: Rick Edgecombe , seanjc@google.com, kvm@vger.kernel.org Cc: kai.huang@intel.com, dmatlack@google.com, isaku.yamahata@gmail.com, yan.y.zhao@intel.com, nik.borisov@suse.com, linux-kernel@vger.kernel.org References: <20240904030751.117579-1-rick.p.edgecombe@intel.com> <20240904030751.117579-13-rick.p.edgecombe@intel.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20240904030751.117579-13-rick.p.edgecombe@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/4/24 05:07, Rick Edgecombe wrote: > diff --git a/arch/x86/kvm/mmu/spte.c b/arch/x86/kvm/mmu/spte.c > index 46a26be0245b..4ab6d2a87032 100644 > --- a/arch/x86/kvm/mmu/spte.c > +++ b/arch/x86/kvm/mmu/spte.c > @@ -94,8 +94,6 @@ u64 make_mmio_spte(struct kvm_vcpu *vcpu, u64 gfn, unsigned int access) > u64 spte = generation_mmio_spte_mask(gen); > u64 gpa = gfn << PAGE_SHIFT; > > - WARN_ON_ONCE(!vcpu->kvm->arch.shadow_mmio_value); > - > access &= shadow_mmio_access_mask; > spte |= vcpu->kvm->arch.shadow_mmio_value | access; > spte |= gpa | shadow_nonpresent_or_rsvd_mask; > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > index 0c08062ef99f..9da71782660f 100644 > --- a/arch/x86/kvm/vmx/tdx.c > +++ b/arch/x86/kvm/vmx/tdx.c > @@ -6,7 +6,7 @@ > #include "mmu.h" > #include "tdx.h" > #include "tdx_ops.h" > - > +#include "mmu/spte.h" > > #undef pr_fmt > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > @@ -344,6 +344,19 @@ int tdx_vm_init(struct kvm *kvm) > { > kvm->arch.has_private_mem = true; > > + /* > + * Because guest TD is protected, VMM can't parse the instruction in TD. > + * Instead, guest uses MMIO hypercall. For unmodified device driver, > + * #VE needs to be injected for MMIO and #VE handler in TD converts MMIO > + * instruction into MMIO hypercall. > + * > + * SPTE value for MMIO needs to be setup so that #VE is injected into > + * TD instead of triggering EPT MISCONFIG. > + * - RWX=0 so that EPT violation is triggered. > + * - suppress #VE bit is cleared to inject #VE. > + */ > + kvm_mmu_set_mmio_spte_value(kvm, 0); > + > /* > * This function initializes only KVM software construct. It doesn't > * initialize TDX stuff, e.g. TDCS, TDR, TDCX, HKID etc. Reviewed-by: Paolo Bonzini