From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11E9C7619A for ; Mon, 27 Mar 2023 03:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231956AbjC0DMt convert rfc822-to-8bit (ORCPT ); Sun, 26 Mar 2023 23:12:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjC0DMq (ORCPT ); Sun, 26 Mar 2023 23:12:46 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCE593A9F; Sun, 26 Mar 2023 20:12:43 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 2CB7424E309; Mon, 27 Mar 2023 11:12:37 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 27 Mar 2023 11:12:37 +0800 Received: from EXMBX168.cuchost.com ([fe80::3c2d:dee5:4938:3fc4]) by EXMBX168.cuchost.com ([fe80::3c2d:dee5:4938:3fc4%16]) with mapi id 15.00.1497.044; Mon, 27 Mar 2023 11:12:36 +0800 From: JiaJie Ho To: Herbert Xu CC: "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support Thread-Topic: [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support Thread-Index: AQHZVbQZd9+lAcQFW0yunvw0rKV1eK8JONIAgATPZGA= Date: Mon, 27 Mar 2023 03:12:36 +0000 Message-ID: <436f7f43f79b43209d3477c9d99addf6@EXMBX168.cuchost.com> References: <20230313135646.2077707-1-jiajie.ho@starfivetech.com> <20230313135646.2077707-5-jiajie.ho@starfivetech.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Mar 13, 2023 at 09:56:46PM +0800, Jia Jie Ho wrote: > > > > +static void starfive_hash_dma_callback(void *param) { > > + struct starfive_cryp_dev *cryp = param; > > + > > + complete(&cryp->tx_comp); > > +} > > Please get rid of tx_comp and do the rest of the processing here. Hi Herbert, Thanks for reviewing the patch. I'll update this in next version. Best regards, Jia Jie