Re: 2.6.14-git4 suspend fails: kernel NULL pointer dereference

[Patrizio Bassi <patrizio.bassi@gmail.com>]

Pavel Machek ha scritto:

>Hi!
>
>  
>
>>>diff --git a/kernel/power/main.c b/kernel/power/main.c
>>>--- a/kernel/power/main.c
>>>+++ b/kernel/power/main.c
>>>@@ -167,7 +167,7 @@ static int enter_state(suspend_state_t s
>>>{
>>>	int error;
>>>
>>>-	if (pm_ops->valid && !pm_ops->valid(state))
>>>+	if (pm_ops && pm_ops->valid && !pm_ops->valid(state))
>>>		return -ENODEV;
>>>	if (down_trylock(&pm_sem))
>>>		return -EBUSY;
>>>
>>>
>>> 
>>>
>>>      
>>>
>>i'm using ACPI.
>>i'?ll try the patch and report asap.
>>    
>>
>
>ok, not sure what is going on, then. Fill enter_state() with printks()
>so that we know where it fails... then kill klogd before attempting
>suspend.
>								Pavel
>  
>
that **seems** to be fixed, even if i run ACPI.

now i have

Stopping tasks:
===============================================================|
Freeing memory... done (42120 pages freed)
usbfs 2-2:1.0: no suspend?
Could not suspend device 2-2: error -16
Some devices failed to suspend
Restarting tasks... done

this was fixed by a patch Len Brown gave me privatly.
it's due to a pci-usb card.
it seems has not been applied yet.
can you notify him? he knows :)

good job.

Patrizio